hg: jdk8/tl/jdk: 8001569: Regression test GetPeerHost uses static port number

2012-11-09 Thread xuelei . fan
Changeset: 9edfa0e761b9 Author:xuelei Date: 2012-11-09 01:15 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9edfa0e761b9 8001569: Regression test GetPeerHost uses static port number Reviewed-by: weijun ! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/ServerHandshaker/Ge

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-09 Thread Chris Hegarty
Sean, Thank you for adding a test. Rather than creating a dependency on rt.jar it may be best to have the test use the java.util.jar API to create a small temporary jar file. The problem with the dependency on rt.jar is that the test will fail if run against a development build where the ima

Re: JDBC bug: Incorrect number of conflicts is reported by CachedRowSetWriter.writeData

2012-11-09 Thread Lance Andersen - Oracle
Frank, If you can please post the bug info here, I will take a look at your patch Best Lance On Nov 8, 2012, at 10:01 PM, Frank Ding wrote: > Hi guys, > We discovered a bug in CachedRowSetWriter.writeData method where incorrect > number of conflicts is reported. I searched in Oracle bug datab

Re: Request for review: 7201156 : jar tool fails to convert file separation characters for list and extract

2012-11-09 Thread Alan Bateman
On 09/11/2012 04:31, Sean Chou wrote: Hello Chris, Alan, and Xueming, I added the testcase, please take a look. webrev: http://cr.openjdk.java.net/~zhouyx/7201156/webrev.01/ Thanks for adding a test, I agree with Chris that it would be great if the test didn't use rt.jar. As Chris mentions, r

RFR: 6244047: impossible to specify directories to logging FileHandler unless they exist

2012-11-09 Thread Jim Gish
Please review http://cr.openjdk.java.net/~jgish/Bug6244047-FileHandler-CheckLockLocation/ This updates the logging FileHandler to actually check the directory passed to it via the pattern to ensure that it exists a

RE: RFR: 6244047: impossible to specify directories to logging FileHandler unless they exist

2012-11-09 Thread Jason Mehrens
Jim, You might just want to change the code to create and close a FileOutputStream in a way that doesn't truncate or damage the target file. Or maybe use the NIO file code if that is possible. See BUG ID 4420020. Jason > Date: Fri, 9 Nov 2012 16:37:02 -0500 > From: jim.g...@oracle.com >