Re: Adding field to BatchUpdateException

Hi Lance, As a general comment, I would prefer release-specific information ("As of Java SE 8...") to appear not in javadoc, but in the non-javadoc comments in a class. Such release-specific notes in the specification quickly become out of date. I suggest explicitly documenting how the two

RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

Please review this fix for the java/util/TimeZone/Bug6912560.java test. The problem with the test is that it fails when running with Java Flight Recorder enabled. This is because JFR will call TimeZone.getDefault() when it starts up, before the main() method is called. This will cause TimeZone t

Re: RFR: 8003322: Add instrumentation points for tracing of I/O calls

Alan, Mandy: thanks for the reviews! On 26 nov 2012, at 19:31, Mandy Chung wrote: > On 11/26/12 1:40 AM, Staffan Larsen wrote: >> >> A webrev for the changes going into 7u12 is here: >> http://cr.openjdk.java.net/~sla/8003322/webrev.jdk7.00/ > > The changes look fine for 7u12.Thanks for l

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

Hi Staffan, On 27/11/2012 8:22 PM, Staffan Larsen wrote: Please review this fix for the java/util/TimeZone/Bug6912560.java test. The problem with the test is that it fails when running with Java Flight Recorder enabled. This is because JFR will call TimeZone.getDefault() when it starts up, be

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

On 27/11/2012 10:22, Staffan Larsen wrote: Please review this fix for the java/util/TimeZone/Bug6912560.java test. The problem with the test is that it fails when running with Java Flight Recorder enabled. This is because JFR will call TimeZone.getDefault() when it starts up, before the main()

Re: 8003949: LogManager, downgrade normative reference to ${java.home}/lib/logging.properties

On Nov 26, 2012, at 4:52 PM, Alan Bateman wrote: > On 26/11/2012 15:18, Paul Sandoz wrote: >> Hi Alan, >> >> + * If neither of these properties is defined then the LogManager uses its >> + * default configuration. The default configuration is typically loaded >> from the >> + * properties file

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

On 27/11/2012 10:22, Staffan Larsen wrote: Please review this fix for the java/util/TimeZone/Bug6912560.java test. The problem with the test is that it fails when running with Java Flight Recorder enabled. This is because JFR will call TimeZone.getDefault() when it starts up, before the main()

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

On 27/11/2012 06:47, Martin Buchholz wrote: : On Solaris bi-arch I think you need only one jprochelper, not two, since a 32-bit helper can exec a 64-bit subprocess. This is a good point, it needs to know if the target program is 32-bit or 64-bit and chose the appropriate trampoline/helper.

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

On 27 November 2012 02:12, Mike Duigou wrote: > In the original patch which added the basic lambda functional interfaces, > CR#8001634 [1], none of the interfaces extended other interfaces. The reason > was primarily that the javac compiler did not, at the time that 8001634 was > proposed, supp

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

On 27 nov 2012, at 12:02, Alan Bateman wrote: > On 27/11/2012 10:22, Staffan Larsen wrote: >> >> Please review this fix for the java/util/TimeZone/Bug6912560.java test. >> >> The problem with the test is that it fails when running with Java Flight >> Recorder enabled. This is because JFR will

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

On 27 nov 2012, at 11:45, David Holmes wrote: > Hi Staffan, > > On 27/11/2012 8:22 PM, Staffan Larsen wrote: >> Please review this fix for the java/util/TimeZone/Bug6912560.java test. >> >> The problem with the test is that it fails when running with Java Flight >> Recorder enabled. This is b

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

On 11/27/2012 03:12 AM, Mike Duigou wrote: In the original patch which added the basic lambda functional interfaces, CR#8001634 [1], none of the interfaces extended other interfaces. The reason was primarily that the javac compiler did not, at the time that 8001634 was proposed, support exten

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

On 27/11/2012 12:26, Staffan Larsen wrote: : The test installs a security manager and that has to be present during the call to getDefault() when getDefault() does the real work (not just reading from the cache). Setting -Duser.timezone will not help as the only fix. What I mean is change

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

Setting -Djava.security.manager on the @run gives me an AccessControlException from jtreg. I could work around this by creating a policy file, I guess. Exception in thread "main" java.security.AccessControlException: access denied ("java.io.FilePermission" "/Users/staffan/mercurial/jdk8-tl/jdk/

Re: RFR (S): 7155168: java/util/TimeZone/Bug6912560.java: expected Asia/Tokyo

I suspect this test will fail with java agents too, say when doing code coverage during test runs. It might be better to just change the @run tag to specify -D user.timezone= Asia/Tokyo, assuming this solves the problem too. This test runs in othervm mode by default. Any java agents calling in

hg: jdk8/tl/jdk: 8003833: Spurious NPE from Socket.getIn/OutputStream

Changeset: ddf97baea570 Author:chegar Date: 2012-11-27 17:15 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/ddf97baea570 8003833: Spurious NPE from Socket.getIn/OutputStream Reviewed-by: alanb, dsamersoff ! src/share/classes/java/net/AbstractPlainSocketImpl.java + test/java/

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

On Nov 27 2012, at 03:56 , Stephen Colebourne wrote: > On 27 November 2012 02:12, Mike Duigou wrote: >> In the original patch which added the basic lambda functional interfaces, >> CR#8001634 [1], none of the interfaces extended other interfaces. The reason >> was primarily that the javac comp

JavaDoc for default methods (Was: Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces)

On 11/27/2012 05:56 AM, Stephen Colebourne wrote: There is also no Javadoc on the default method override. In this case, passing a null to either parameter will result in an NPE. This should be documented. More generally, you/Oracle should define a standard form of words for describing what a de

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

On Tue, Nov 27, 2012 at 3:06 AM, Alan Bateman wrote: > On 27/11/2012 06:47, Martin Buchholz wrote: > > : > > On Solaris bi-arch I think you need only one jprochelper, not two, since > a 32-bit helper can exec a 64-bit subprocess. > > This is a good point, it needs to know if the target program

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

On 27/11/2012 17:45, Martin Buchholz wrote: On Tue, Nov 27, 2012 at 3:06 AM, Alan Bateman > wrote: On 27/11/2012 06:47, Martin Buchholz wrote: : On Solaris bi-arch I think you need only one jprochelper, not two, since a 32-bit helper can exec

Re: Request for Review : CR#8004015 : Add interface extends and defaults for basic functional interfaces

On 27 November 2012 17:32, Mike Duigou wrote: >> It is vitally important to get this kind of formatting/style correct. > >> Developers the world over will be copying what the style is in these >> classes. > > I totally agree that we should be consistent but I don't believe that there's > a consen

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

I'll put a test together for this before sending out another review. I was sure I had some sort of issue with this in testing before, but perhaps it was IPC related. -Rob On 27/11/12 17:48, Alan Bateman wrote: On 27/11/2012 17:45, Martin Buchholz wrote: On Tue, Nov 27, 2012 at 3:06 AM,

Re: Request for Review: 5049299: (process) Use posix_spawn, not fork, on S10 to avoid swap exhaustion

$javahome/lib/jexec is a precedent for implementation detail executables not found in $javahome/bin

Review request: 8003851: MethodHandleNatives dependency on java.sql.DriverManager

java.lang.invoke has a new dependency to java.sql.DriverManager and java.util.logging which are undesirable as they are currently not in jigsaw's base module. This also impacts the Profile work as JDBC is currently proposed in Compact2 and the JDBC dependency means a reference from Compact1 to

Re: Review request: 8003851: MethodHandleNatives dependency on java.sql.DriverManager

On 27/11/2012 19:34, Mandy Chung wrote: java.lang.invoke has a new dependency to java.sql.DriverManager and java.util.logging which are undesirable as they are currently not in jigsaw's base module. This also impacts the Profile work as JDBC is currently proposed in Compact2 and the JDBC depen

Re: Review request: 8003851: MethodHandleNatives dependency on java.sql.DriverManager

On 11/27/2012 11:46 AM, Alan Bateman wrote: On 27/11/2012 19:34, Mandy Chung wrote: java.lang.invoke has a new dependency to java.sql.DriverManager and java.util.logging which are undesirable as they are currently not in jigsaw's base module. This also impacts the Profile work as JDBC is curr

hg: jdk8/tl/langtools: 8004068: Fix build problems caused by on-demand imports

Changeset: 4d68e2a05b50 Author:jjg Date: 2012-11-27 13:55 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/4d68e2a05b50 8004068: Fix build problems caused by on-demand imports Reviewed-by: jjg Contributed-by: eric.casp...@amd.com ! src/share/classes/com/sun/tools/javac/c

8003562: Provide a command-line tool to find static dependencies

As part of prepare for modules [1], this RFE is to provide a command-line tool in JDK8 so that developers can understand the static dependencies of their applications and libraries.As part of Project Jigsaw, a useful class analyzer [2] was developed that makes it very easy to identify the depen

hg: jdk8/tl/jdk: 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests

Changeset: 40311b5f478f Author:robm Date: 2012-11-28 00:47 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40311b5f478f 8003597: TEST_BUG: Eliminate dependency on javaweb from closed net tests Reviewed-by: chegar + test/java/net/ResponseCache/Test.java + test/java/net/Socket/

Re: Review request: 8003851: MethodHandleNatives dependency on java.sql.DriverManager

On 28/11/2012 5:34 AM, Mandy Chung wrote: java.lang.invoke has a new dependency to java.sql.DriverManager and java.util.logging which are undesirable as they are currently not in jigsaw's base module. This also impacts the Profile work as JDBC is currently proposed in Compact2 and the JDBC depend

hg: jdk8/tl/jdk: 8004088: hg push for bug#4235519 failed to push all files

Changeset: c6ed2c238d4f Author:sherman Date: 2012-11-27 22:07 -0800 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c6ed2c238d4f 8004088: hg push for bug#4235519 failed to push all files Summary: pushed all base64 files Reviewed-by: alanb, mduigou + src/share/classes/java/util/Base