JDK-8010495: Update JAXP NetBeans project - add support for generating javadoc

Hi guys, I'd like to propose a small change to jaxp/build.xml and jaxp/nbproject/project.xml - in order to allow editing JAXP sources in NetBeans, as well as generating the JAXP javadoc for previewing purposes. I actually stole the javadoc target from jdk/make/netbeans/common/shared.xml The cha

Re: 8010309 : PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

Hi Laurent, Mandy, MethodHandles.guardWithCheck() rocks! Out of curiosity, I put the MethodHandles in latest JDK8 build to the test. It turns out that they are surprisingly good. I optimized the dispatch logic of the most critical method: PlatformLogger.isLoggable(int) which I have shown in p

hg: jdk8/tl/jdk: 8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java failed after fix for 8009869

Changeset: d92a96dcbfe1 Author:sundar Date: 2013-03-25 19:25 +0530 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d92a96dcbfe1 8010704: The test closed/java/lang/SecurityManager/CheckPackageDefinition.java failed after fix for 8009869 Reviewed-by: lagergren, hannesw ! src/share/l

Re: 8010309 : PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

Hi Peter, thanks for your microbench tool ! It works well and avoid me to do my own (caliper is a well known one) I do not know what MethodHandle is but its performance is impressive ! Here are my results (Oracle jdk 1.7_13 vs OpenJDK 8 patched): java -Xms8m -Xmx8m JDK 1.7_13 run: >> JVM STAR

hg: jdk8/tl/jdk: 8010668: builtin JNI libraries should not be unloaded

Changeset: 5d0c891264bf Author:chegar Date: 2013-03-25 14:29 + URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5d0c891264bf 8010668: builtin JNI libraries should not be unloaded Reviewed-by: chegar, alanb Contributed-by: Bill Pittore ! src/share/native/java/lang/ClassLoader.c

Re: Request for review fix for 8010668

Thanks for the review and thanks to Chris for pushing it. bill On 3/23/2013 7:15 AM, Alan Bateman wrote: On 22/03/2013 21:02, BILL PITTORE wrote: This fixes a problem with the recently committed changes for JNI static libraries. On an error condition or explicit unload request, statically lin

Re: JDK-8010495: Update JAXP NetBeans project - add support for generating javadoc

Hi Daniel, Thanks for doing this. JAXP doesn't have these packages: "java/", "org/ietf/jgss/", and "org/omg/". Since this is the jaxp repo, it would be fine if only 'javax/' and 'org/' are included, or 'com/' be excluded. Regards, Joe On 3/25/2013 4:45 AM, Daniel Fuchs wrote: Hi guys, I'

Re: 8010309 : PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

Well, Laurent, Mandy, It turns out that the dispatch speed-up (or lack of slow-down to be precise) is possible without MethodHandles too. Maybe some VM guru could shed some light on this, but the following is currently the fastest variant: http://dl.dropbox.com/u/101777488/jdk8-tl/PlatformLog

Re: JDK-8010495: Update JAXP NetBeans project - add support for generating javadoc

On 3/25/13 5:20 PM, huizhe wang wrote: Hi Daniel, Thanks for doing this. JAXP doesn't have these packages: "java/", "org/ietf/jgss/", and "org/omg/". Since this is the jaxp repo, it would be fine if only 'javax/' and 'org/' are included, or 'com/' be excluded. OK - I just copied the pattern

Re: JDK-8010495: Update JAXP NetBeans project - add support for generating javadoc

On 3/25/2013 9:35 AM, Daniel Fuchs wrote: On 3/25/13 5:20 PM, huizhe wang wrote: Hi Daniel, Thanks for doing this. JAXP doesn't have these packages: "java/", "org/ietf/jgss/", and "org/omg/". Since this is the jaxp repo, it would be fine if only 'javax/' and 'org/' are included, or 'com/' be

Re: RFR: Project files for Solaris Studio / NetBeans

Jesper, Tried to apply your patch as I'm quite interesting to have really working NB project for jdk and hotspot. 1. Directory structure looks strange (see screenshot1) 2. netbeans doesn't work for JDK tests (see screenshot2) - netbeans doesn't pick files from test directory (JDK-only pro

Re: RFR: Project files for Solaris Studio / NetBeans

Jesper, Tryed to apply your patch as I'm quite inetresting to have really working NB project for jdk and hotspot. 1. Directory structure looks strange (see screenshot1) 2. netbeans doesn't work for JDK tests (see screenshot2) - netbeans doesn't pick files from test directory (JDK-only pro

Re: RFR: Project files for Solaris Studio / NetBeans

Hi Jesper, first of all I highly welcome your initiative! Nevertheless I have some questions: - Who will support these project files? As far as I can see, they will have to be updated at least every time a file will be added, renamed or deleted. Experience shows that such kind of project files t

Re: 8010309 : PlatformLogger: isLoggable performance / waste due to HashMap leads to Integer allocations (boxing)

Peter, Here are the results Sorry I have no performance gain ! maybe I should use java server VM ? Any idea ? java -Xms8m -Xmx8m jdk7_13 >> JVM START: 1.7.0_13 [Java HotSpot(TM) 64-Bit Server VM 23.7-b01] SEVERE: PlatformLogger started # # isLoggableFinest: run duration: 5 000 ms, #of logica

Re: RFR: Project files for Solaris Studio / NetBeans

Jesper, On 2013-03-25 22:35, Jesper Wilhelmsson wrote: > Dmitry Samersoff skrev 25/3/13 6:11 PM: >> Jesper, >> >> Tryed to apply your patch as I'm quite inetresting to have really >> working NB project for jdk and hotspot. >> >> 1. Directory structure looks strange (see screenshot1) > > The struc

Re: RFR: Project files for Solaris Studio / NetBeans

On Mon, Mar 25, 2013 at 7:03 PM, Jesper Wilhelmsson < jesper.wilhelms...@oracle.com> wrote: > Volker Simonis skrev 25/3/13 6:15 PM: > > Hi Jesper, >> >> first of all I highly welcome your initiative! >> > > This is a joint initiative with Vladimir Voskresensky who works in the > Solaris Studio te

Re: Review 8007703: Remove com.sun.servicetag API

On 2/15/13 1:53 AM, David Holmes wrote: Hi Mandy, On 15/02/2013 9:31 AM, Mandy Chung wrote: Remove com.sun.servicetag that we no longer support. This includes updates the makefiles and so include build-infra to review this change. This will require a tweak to profile-rtjar-includes.txt once

netbeans and openjdk

Hi all, I am trying to set up a netbeans project for JDBC within openjdk leveraging the existing projects that are already in jdk/make/netbeans I have getting the following error and not sure why so wondered if anyone has encountered this before: ---

Re: netbeans and openjdk

Hi Lance, Are you setting it up as a free-form project? In a free-form project, the custom build script is separate from those generated by the IDE. Although you can map targets from the custom build script to project actions, you won't see properties such as source in the script reflected

Re: netbeans and openjdk

Hi Joe, On Mar 25, 2013, at 5:12 PM, huizhe wang wrote: > Hi Lance, > > Are you setting it up as a free-form project? In a free-form project, the > custom build script is separate from those generated by the IDE. Although > you can map targets from the custom build script to project actions

Re: RFR-8008118

Since we're all on this perfectionist quest for quality here, I noticed that we could replace allocation for path components with a single allocation using NUL as a separator. I think I'll go code that up. Also note to all: if java VMs are created and destroyed without the process terminating, th

RFR: Project files for Solaris Studio / NetBeans

Hi, Sorry for cross posting, but I think this could be useful for several areas. I would like to add Solaris Studio / NetBeans project files for the entire OpenJDK project. To clarify: One project that contains the entire OpenJDK. With the new build infrastructure in JDK 8 building the entir

Re: hg: jdk8/tl/jdk: 8001642: Add Optional, OptionalDouble, OptionalInt, OptionalLong

Has the optional classes been verified to serialize/deserialize correctly? I noticed it tries to use the null object pattern with the use of EMPTY private instance. When I have implemented the NULL pattern I have used a private subclass of the object as opposed to an instance variable to insure it

Re: RFR: Project files for Solaris Studio / NetBeans

Dmitry Samersoff skrev 25/3/13 6:11 PM: Jesper, Tryed to apply your patch as I'm quite inetresting to have really working NB project for jdk and hotspot. 1. Directory structure looks strange (see screenshot1) The structure in the Projects tab shows the NetBeans project hierarchy. It's not re

Re: RFR: Project files for Solaris Studio / NetBeans

Volker Simonis skrev 25/3/13 8:59 PM: On Mon, Mar 25, 2013 at 7:03 PM, Jesper Wilhelmsson mailto:jesper.wilhelms...@oracle.com>> wrote: Volker Simonis skrev 25/3/13 6:15 PM: Hi Jesper, first of all I highly welcome your initiative! This is a joint initiative with Vl

Re: RFR: Project files for Solaris Studio / NetBeans

Volker Simonis skrev 25/3/13 6:15 PM: Hi Jesper, first of all I highly welcome your initiative! This is a joint initiative with Vladimir Voskresensky who works in the Solaris Studio team. Nevertheless I have some questions: - Who will support these project files? As far as I can see, the

Re: RFR: Project files for Solaris Studio / NetBeans

Dmitry, Dmitry Samersoff skrev 25/3/13 7:56 PM: Jesper, On 2013-03-25 22:35, Jesper Wilhelmsson wrote: Dmitry Samersoff skrev 25/3/13 6:11 PM: Jesper, Tryed to apply your patch as I'm quite inetresting to have really working NB project for jdk and hotspot. 1. Directory structure looks stran

Re: CFR - updated 8001667: Comparator combinators and extension methods

That would get me the functionality I want. It's the route Guava took, with ordering.onResultOf(function). If you do go this route, I suggest "appliedTo" as another possibility for the name. I do see this solution as a big improvement over what's there currently. It works great for most of the

Re: [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

All these tests compile and run under all OSs, not MacOS only. There are a lot of awt and swing tests that depend on test.java.awt.regtesthelpers, they are in the openjdk repo. Almost none of regression tests are ever run without JTREG. Konstantin 11.03.2013 23:53, Phil Race пишет: Konstantin

Re: [8] Review request for CR 7145406 - [macosx] Migrate Apple tests from macosx-port to 7u

Phil, 12.03.2013 0:22, Phil Race wrote: On 3/11/2013 1:07 PM, Konstantin Shefov wrote: All these tests compile and run under all OSs, not MacOS only. I find that very difficult to believe. \re\jdk\8\promoted\latest\binaries\windows-i586\bin\javac APIPresent.java APIPresent.java:31: error: pa

Re: netbeans and openjdk

Hi Lance, On 3/25/2013 2:28 PM, Lance Andersen wrote: Hi Joe, On Mar 25, 2013, at 5:12 PM, huizhe wang > wrote: Hi Lance, Are you setting it up as a free-form project? In a free-form project, the custom build script is separate from those generated by the I

Re: netbeans and openjdk

On Mar 25, 2013, at 5:28 PM, Lance Andersen wrote: > Hi Joe, > > On Mar 25, 2013, at 5:12 PM, huizhe wang wrote: > >> Hi Lance, >> >> Are you setting it up as a free-form project? In a free-form project, the >> custom build script is separate from those generated by the IDE. Although >>

Re: netbeans and openjdk

On Mar 25 2013, at 14:28 , Lance Andersen wrote: > > So I changed the values above just now from 1.5 and 1.6 to both be 1.7 > > Which worked much better. > > > This works in a jdk7 repository. > > It looks like shared.xml was changed for jdk8 so it does not have the values > above. I made

Re: netbeans and openjdk

On Mar 25, 2013, at 5:54 PM, Mike Duigou wrote: > > On Mar 25 2013, at 14:28 , Lance Andersen wrote: >> >> So I changed the values above just now from 1.5 and 1.6 to both be 1.7 >> >> Which worked much better. >> >> >> This works in a jdk7 repository. >> >> It looks like shared.xml was ch

Re: Review 8007703: Remove com.sun.servicetag API

Hi Mandy, On 26/03/2013 6:11 AM, Mandy Chung wrote: On 2/15/13 1:53 AM, David Holmes wrote: Hi Mandy, On 15/02/2013 9:31 AM, Mandy Chung wrote: Remove com.sun.servicetag that we no longer support. This includes updates the makefiles and so include build-infra to review this change. This wi

hg: jdk8/tl/jdk: 8007703: Remove com.sun.servicetag API

Changeset: 5e383a73386a Author:mchung Date: 2013-03-25 17:19 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5e383a73386a 8007703: Remove com.sun.servicetag API Reviewed-by: dholmes, alanb, erikj ! make/com/sun/Makefile ! make/common/Release.gmk ! makefiles/CopyFiles.gmk ! ma

hg: jdk8/tl/jdk: 8010787: changeset for 8007703 is missing the deleted files

Changeset: 335d2156222e Author:mchung Date: 2013-03-25 18:14 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/335d2156222e 8010787: changeset for 8007703 is missing the deleted files Reviewed-by: dholmes, alanb, erikj - make/com/sun/servicetag/Makefile - src/share/classes/com/

hg: jdk8/tl/corba: 2 new changesets

Changeset: c3ec80715805 Author:mfang Date: 2013-03-25 16:53 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/c3ec80715805 8010521: jdk8 l10n resource file translation update 2 Reviewed-by: naoto, yhuang ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_de.pr