Re: REASSERT Code review request for 8012044: Give more information about self-suppression from Throwable.addSuppressed

On 04/23/2013 07:51 AM, Joe Darcy wrote: Hi David, On 04/22/2013 10:25 PM, David Holmes wrote: Hi Joe, On 23/04/2013 9:05 AM, Joseph Darcy wrote: Hello, Just reasserting the request for a review of the latest version of this patch: http://cr.openjdk.java.net/~darcy/8012044.2 I believe

Re: Add getChars to CharSequence

On 22/04/2013 20:45, Martin Buchholz wrote: Another preliminary webrev is out at http://cr.openjdk.java.net/~martin/webrevs/openjdk8/getChars/ Alan et al: Before continuing, can we: Have thumbs up on the changes to out of bound

Re: Add getChars to CharSequence

On 23/04/2013 12:17, Alan Bateman wrote: On 22/04/2013 20:45, Martin Buchholz wrote: Another preliminary webrev is out at http://cr.openjdk.java.net/~martin/webrevs/openjdk8/getChars/ Alan et al: Before continuing, can we: Hav

Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Bug description: https://jbs.oracle.com/bugs/browse/JDK-8012453 http://bugs.sun.com/view_bug.do?bug_id=8012453 Here is the suggested trivial fix: http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8012453/webrev.00/ Summary: -- Summary: Since the changes f

hg: jdk8/tl/jdk: 8012930: (fs) Eliminate recursion from FileTreeWalker

Changeset: 8b07b318f713 Author:alanb Date: 2013-04-23 15:01 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8b07b318f713 8012930: (fs) Eliminate recursion from FileTreeWalker Reviewed-by: chegar ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/ni

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

I believe so. Alex Buckley recommended the exact wording. On 04/22/13 22:09, Joseph Darcy wrote: > Hello, > > 240 * Returns the number of formal parameters (whether explicitly > 241 * declared or implicitly declared or neither) for the executable > > Are there parameters that are ne

hg: jdk8/tl/jdk: 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans

Changeset: b456f25c2075 Author:lancea Date: 2013-04-23 11:17 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b456f25c2075 8011620: adding free form netbeans project for jdbc to jdk/make/netbeans Reviewed-by: chegar ! make/netbeans/common/shared.xml + make/netbeans/jdbc/README

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Random comments from a former maintainer: I was never brave enough to tackle windows argument parsing or trying to change legacy behavior. I'm surprised you used LinkedList, which is almost never useful. Why not ArrayList? Windows has arcane command line parsing rules, which are rather difficul

RE: REASSERT Code review request for 8012044: Give more information about self-suppression from Throwable.addSuppressed

> I still find the use of addSuppressed in initCause to be questionable. > Given: > > catch(SomeException s) { >sharedException.initCause(s); // oops already has a cause > throw sharedException; > } > > then the ISE isn't suppressing 's', but replacing/suppressing > sharedException in m

Re: Math.round(...) and bug 6430675

FYI this came through as http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8010430. Brian On Feb 2, 2013, at 1:40 AM, Jeff Hain wrote: > > >Would you mind filing an issue so that this may be tracked? > > Done: "Math.round has surprising behavior for odd values of ulp 1" > > -Jeff >

Re: RFR: 8005051: optimized defaults for Iterator.forEachRemaining

On 04/20/2013 01:42 PM, Ulf Zibis wrote: Am 20.04.2013 01:59, schrieb Akhil Arora: Please review the addition of optimized defaults for Iterator's forEachRemaining to ArrayList, LinkedList, Vector and CopyOnWriteArrayList. The unit test has a performance comparison test (disabled by default) tha

Re: RFR: 8005051: optimized defaults for Iterator.forEachRemaining

On 04/22/2013 11:42 AM, Alan Bateman wrote: On 20/04/2013 00:59, Akhil Arora wrote: Please review the addition of optimized defaults for Iterator's forEachRemaining to ArrayList, LinkedList, Vector and CopyOnWriteArrayList. The unit test has a performance comparison test (disabled by default) th

Re: Add getChars to CharSequence

Hi Ulf! On Mon, Apr 22, 2013 at 9:11 PM, Ulf Zibis wrote: > Am 22.04.2013 21:45, schrieb Martin Buchholz: > >> Another preliminary webrev is out at >> http://cr.openjdk.java.net/~**martin/webrevs/openjdk8/**getChars/< >> http://cr.o

Re: Review request: JDK-8012453 (process) Runtime.exec(String) fails if command contains spaces [win]

Alexey, I plan to review this, just don't have time to do a detailed review today. At a high-level then I think the approach looks reasonable. If someone has gone to the trouble of quoting a program path with spaces in it, then the fallback should handle it. It's important that the security m

Re: Add getChars to CharSequence

Yes, all-or-nothing behavior on errors is worth something, and we should get it right, especially when it's cheap. On Tue, Apr 23, 2013 at 4:52 AM, Alan Bateman wrote: > One other observation, but as the 2-arg getChars doesn't have explicit > bounds checking then it may have have copied some cha

Re: Add getChars to CharSequence

Hi Martin, (cc'd core-libs-dev) Am 23.04.2013 21:36, schrieb Martin Buchholz: Hi Ulf! On Mon, Apr 22, 2013 at 9:11 PM, Ulf Zibis mailto:ulf.zi...@cosoco.de>> wrote: Am 22.04.2013 21:45, schrieb Martin Buchholz: Another preliminary webrev is out at http://cr.openjdk.java.

RFR: JDK-8012650 and JDK-8011918

Hi, Please review static Stream factory methods and methods for Arrays. Webrev is at http://cr.openjdk.java.net/~henryjen/tl/8012650-8011918.0 Stream methods are covered in a test suite which will be put back soon once all depends part is in place. Arrays setAll and parallelSetAll methods has t

hg: jdk8/tl/jaxws: 2 new changesets

Changeset: 8abe95530f58 Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/8abe95530f58 Added tag jdk8-b86 for changeset a5e7c2f093c9 ! .hgtags Changeset: 9d251e1ec1eb Author:lana Date: 2013-04-23 09:27 -0700 URL: http://h

hg: jdk8/tl/corba: Added tag jdk8-b86 for changeset 44a8ce4a759f

Changeset: f1709874d55a Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/f1709874d55a Added tag jdk8-b86 for changeset 44a8ce4a759f ! .hgtags

hg: jdk8/tl: 6 new changesets

Changeset: bee6ff988f9c Author:katleman Date: 2013-04-12 15:21 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/rev/bee6ff988f9c 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! common/autoconf/compare.sh.in ! common/bin/compare.sh Changeset: 8c5b18d6

hg: jdk8/tl/hotspot: 6 new changesets

Changeset: b0301c02f38e Author:katleman Date: 2013-04-12 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/b0301c02f38e 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! make/bsd/makefiles/fastdebug.make ! src/share/vm/services/diagnost

hg: jdk8/tl/nashorn: 7 new changesets

Changeset: e7e82c1e9aed Author:katleman Date: 2013-04-12 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/e7e82c1e9aed 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! docs/JavaScriptingProgrammersGuide.html ! src/jdk/nashorn/api/scri

hg: jdk8/tl/jaxp: 3 new changesets

Changeset: 9550aab82b5d Author:katleman Date: 2013-04-18 10:30 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/9550aab82b5d Added tag jdk8-b86 for changeset ca71ec37b2ef ! .hgtags Changeset: eddbc8ad2435 Author:lana Date: 2013-04-23 09:27 -0700 URL: http://hg

hg: jdk8/tl/langtools: 7 new changesets

Changeset: 2b585be0da7a Author:katleman Date: 2013-04-12 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/2b585be0da7a 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! test/com/sun/javadoc/testAnnotationOptional/TestAnnotationOption

hg: jdk8/tl/jdk: 19 new changesets

Changeset: e5c5e369af6a Author:katleman Date: 2013-04-12 15:22 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e5c5e369af6a 8012048: JDK8 b85 source with GPL header errors Reviewed-by: iris, mduigou, jjg ! src/share/classes/com/sun/crypto/provider/GaloisCounterMode.java ! src

Re: Proxy.isProxyClass scalability

Hi Peter, Sorry for the delay. On 4/20/2013 12:31 AM, Peter Levart wrote: Hi Mandy, I have another idea. Before jumping to implement it, I will first ask what do you think of it. For example: - have an optimal interface names key calculated from interfaces. - visibility of interfaces and ot

Re: Review Request for JDK-8012937: Correct errors in javadoc comments

Acknowledged; thanks for checking, -Joe On 4/23/2013 7:46 AM, Eric McCorkle wrote: I believe so. Alex Buckley recommended the exact wording. On 04/22/13 22:09, Joseph Darcy wrote: Hello, 240 * Returns the number of formal parameters (whether explicitly 241 * declared or implic

Re: RFR(XS) : JDK-8008687 - MethodHandle code: allow static and invokespecial calls to interface methods

On 4/22/2013 2:06 PM, John Rose wrote: On Apr 19, 2013, at 9:41 AM, Bharadwaj Yadavalli wrote: I would like to request for a review of code changes made to support lambda related modifications to allow static and invokespecial calls to interface methods per spec version 0.6.2 (http://cr.ope

Re: RFR(XS) : JDK-8008687 - MethodHandle code: allow static and invokespecial calls to interface methods

On Apr 23, 2013, at 6:26 PM, Bharadwaj Yadavalli wrote: > I modified the assertion in referenceKindIsConsistent() to allow > REF_invokeSpecial to reference interface method. I have uploaded the modified > webrev. Good, thanks. — John

Re: RFR(XS) : JDK-8008687 - MethodHandle code: allow static and invokespecial calls to interface methods

On Apr 23, 2013, at 6:26 PM, Bharadwaj Yadavalli wrote: > Reran lambda tests successfully. Just in case, be sure the jtreg tests in test/java/lang/invoke/ also pass, with -ea -esa turned on. That's probably already true, but if there is a false fire in the assertions, you'll want to catch it

Re: Proxy.isProxyClass scalability

More comments in addition to what I replied earlier On 4/23/2013 4:43 PM, Mandy Chung wrote: Each ClassLoader maintains explicit hard-references to all Class objects for classes defined by the loader. So proxy Class object can not be GC-ed until the ClassLoader is GC-ed. AFAIU, a class

Re: Proxy.isProxyClass scalability

Hi Mandy, On 04/24/2013 01:43 AM, Mandy Chung wrote: Hi Peter, Sorry for the delay. On 4/20/2013 12:31 AM, Peter Levart wrote: Hi Mandy, I have another idea. Before jumping to implement it, I will first ask what do you think of it. For example: - have an optimal interface names key calcul