On 03/06/2013 12:55, David Holmes wrote:
Hi Otavio,
I've put these into a webrev here:
http://cr.openjdk.java.net/~dholmes/8015470/webrev/
The changes touch a number of areas but hopefully are trivial enough
that we can keep the review on core-libs. As I've put this together
I'll be looking
On 03/06/2013 21:00, Nabeel Memon wrote:
Simply running 'make jdk_util' under the test folder is failing and
throwing the same exception:
java.lang.SecurityException: Prohibited package name: java.util.stream...
for all test sources under under:
java/util/stream/test/* and
Hi Alan,
On 4/06/2013 4:00 PM, Alan Bateman wrote:
On 03/06/2013 12:55, David Holmes wrote:
Hi Otavio,
I've put these into a webrev here:
http://cr.openjdk.java.net/~dholmes/8015470/webrev/
The changes touch a number of areas but hopefully are trivial enough
that we can keep the review on
On 04/06/2013 06:11, huizhe wang wrote:
Hi,
The default restriction in JDK8 is too strict. We've heard enough of
complaints and decided to remove it. Below is the quick fix to remove
the default restriction setting.
Also, there was a bug in XMLSchemaFactory's setFeature method where
the
Hi,
On Jun 4, 2013, at 1:34 AM, Brent Christian brent.christ...@oracle.com wrote:
Hi, Paul
If a HashMap is created via serialization or clone(), we don't check if the
table needs resizing when adding entries, but still need to check if a bin
should be converted to a TreeBin. In this
Changeset: 25cf25fb8c68
Author:sla
Date: 2013-06-04 09:45 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25cf25fb8c68
8015856: Remove java/lang/instrument/IsModifiableClassAgent.java from
ProblemList.txt
Reviewed-by: dholmes
! test/ProblemList.txt
I forgot to say please don't let this hold up getting the patch into TL. I
think it more important to get the code in then iterate on it.
Paul.
On Jun 4, 2013, at 9:45 AM, Paul Sandoz paul.san...@oracle.com wrote:
Hi,
On Jun 4, 2013, at 1:34 AM, Brent Christian brent.christ...@oracle.com
On Jun 3, 2013, at 10:33 PM, Henry Jen henry@oracle.com wrote:
Hi,
Please review
http://cr.openjdk.java.net/~henryjen/tl/8015522.0/webrev/
This webrev is based on previous suggestion from Martin Buchholz while
keep the lazy-binding nature without seize the length at construction
On 06/04/2013 04:27 AM, Brian Burkhalter wrote:
A) Is there some particular approach that should be used in testing
these algorithms for relative performance?
The number one approach is peer review. Is there the JMH project with
microbenchmarks somewhere? Sergey (cc'ed) knows a lot about
Changeset: 5223d3228658
Author:bchristi
Date: 2013-06-04 10:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5223d3228658
8005698: Handle Frequent HashMap Collisions with Balanced Trees
Summary: HashMap bins with many collisions store entries in balanced trees
Reviewed-by:
when building openjfx8 with jdk8b92 i encountered this error :
Total time: 5.313 secs
:buildSrc:clean
:buildSrc:generateGrammarSource
error(10): internal error: Can't get property indirectDelegates using
method ge
t/isIndirectDelegates from org.antlr.tool.Grammar instance :
On 03/06/2013 21:33, Henry Jen wrote:
Hi,
Please review
http://cr.openjdk.java.net/~henryjen/tl/8015522.0/webrev/
This webrev is based on previous suggestion from Martin Buchholz while
keep the lazy-binding nature without seize the length at construction time.
The benchmark shows ~50%
On 04/06/2013 10:14, Ali Ebrahimi wrote:
:
the cause of this error is this new changeset:
4802647: Throw required NPEs from removeAll()/retainAll()
current code assume that collection.removeAll(null) doesn't do anything.
but with this changeset produces NullPointerException that doesn't
Changeset: fad4ef2123ca
Author:psandoz
Date: 2013-06-04 11:53 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fad4ef2123ca
8015790: Remove duplicate spliterator tests
Reviewed-by: alanb, mduigou
-
Changeset: f8b071428ca5
Author:michaelm
Date: 2013-06-04 10:56 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f8b071428ca5
8014723: sun/misc/URLClassPath/ClassnameCharTest.java failing
Reviewed-by: alanb, chegar
! src/share/classes/java/net/HttpURLPermission.java
!
What we this:
previous result: before changeset
collection.removeAll(null) do nothing if collection is empty
collection.removeAll(null) NullPointerException if collection is not empty
current result: after changeset
collection.removeAll(null) NullPointerException if collection is empty
I need a reviewer to update jdk/test/ProblemList.txt again. Bugs are
submitted for each of the issues.
-Alan.
diff --git a/test/ProblemList.txt b/test/ProblemList.txt
--- a/test/ProblemList.txt
+++ b/test/ProblemList.txt
@@ -134,6 +134,9 @@
# 8008200
Hi
JavaDoc to the method says: If the sequence is mutated while the stream
is being read, the result is undefined.
What about exceptions? If the sequence is mutated and length becomes
smaller you'll get IndexOutOfBoundsException in forEachRemaining method.
On 06/04/2013 12:33 AM, Henry Jen
Changeset: 5cd3cb69c8b3
Author:mcimadamore
Date: 2013-06-04 11:30 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/5cd3cb69c8b3
7116676: RichDiagnosticFormatter throws NPE when formatMessage is called
directly
Summary: Fix NPE in RichDiagnosticFormatter.formatMessage
Looks fine to me Alan.
This should hopefully make test runs quieter, until the issues can be
addressed.
-Chris.
On 06/04/2013 11:33 AM, Alan Bateman wrote:
I need a reviewer to update jdk/test/ProblemList.txt again. Bugs are
submitted for each of the issues.
-Alan.
diff --git
Changeset: 780fbbd50ce4
Author:alanb
Date: 2013-06-04 11:52 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/780fbbd50ce4
8015872: ProblemList.txt updates (6/2013)
Reviewed-by: chegar
! test/ProblemList.txt
Changeset: 775a51e3276f
Author:vromero
Date: 2013-06-04 13:21 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/775a51e3276f
7165659: javac incorrectly sets strictfp access flag on inner-classes
Reviewed-by: jjg, mcimadamore
!
On 03/06/2013 15:08, Coleen Phillimore wrote:
Summary: The code for this test is fixed now and integrated to TL repo
and it passes now.
open webrev at http://cr.openjdk.java.net/~coleenp/7124706_jdk/
bug link at http://bugs.sun.com/view_bug.do?bug_id=7124706_jdk
Thanks,
Coleen
Looks fine to
Aleksej,
Looks good to me. I think Alan wanted you to use the ser files to create a
byte array + ByteArrayInputStream in the actual test class instead of including
actual serial data files along side the test.
Jason
The next version of webrev:
On 04/06/2013 14:44, Jason Mehrens wrote:
Aleksej,
Looks good to me. I think Alan wanted you to use the ser files to create a
byte array + ByteArrayInputStream in the actual test class instead of including
actual serial data files along side the test.
That would be my preference because we
Brian,
could you show your benchmark?
My quick experiments show that current Karatsuba threshold is quite
reasonable.
On 06/04/2013 12:36 PM, Aleksey Shipilev wrote:
On 06/04/2013 04:27 AM, Brian Burkhalter wrote:
A) Is there some particular approach that should be used in testing
these
On 24/05/2013 15:02, Alan Bateman wrote:
On 24/05/2013 09:30, Henry Jen wrote:
Hi,
Please review a fix for 8014855.
http://cr.openjdk.java.net/~henryjen/tl/8014855.0/webrev/
The fix ensure we only test symbolic link related scenario on systems
support it.
Thanks for taking one.
One idea
Changeset: 25a8e6fd0210
Author:alanb
Date: 2013-06-04 15:18 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/25a8e6fd0210
8014855: TEST_BUG: java/nio/file/Files/StreamTest.java fails when sym links not
supported
Reviewed-by: alanb
Contributed-by: henry@oracle.com
!
Thanks a lot Mike, Jon and Alan. Although building from source wasn't as
straight-forward as I mentioned but I got it running. Someone should add
these details to the document to make it easier for others.
Nabeel
On Tue, Jun 4, 2013 at 1:55 AM, Alan Bateman alan.bate...@oracle.comwrote:
On
Currently our workaround for the FX gradle build is to run the antlr
task using an earlier JDK (b90) and the rest with b91 or later. We
haven't looked for another workaround yet.
-- Kevin
Alan Bateman wrote:
On 04/06/2013 10:14, Ali Ebrahimi wrote:
:
the cause of this error is this new
Alan, Jason,
Thanks for clarification. I have moved the serial data from binary files
to test class:
http://cr.openjdk.java.net/~dmeetry/8009581/webrev.5/
http://cr.openjdk.java.net/%7Edmeetry/8009581/webrev.5/
-Aleksej
On 06/04/2013 05:57 PM, Alan Bateman wrote:
On 04/06/2013 14:44, Jason
Changeset: 5b958f0a5498
Author:joehw
Date: 2013-06-04 09:35 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/5b958f0a5498
8015630: Remove default restriction settings of jaxp 1.5 properties in JDK8
Reviewed-by: alanb
!
Done. Thanks!
Joe
On 6/3/2013 11:54 PM, Alan Bateman wrote:
On 04/06/2013 06:11, huizhe wang wrote:
Hi,
The default restriction in JDK8 is too strict. We've heard enough of
complaints and decided to remove it. Below is the quick fix to remove
the default restriction setting.
Also, there
Changeset: 379e1bcae693
Author:naoto
Date: 2013-06-04 10:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/379e1bcae693
8013903: Japanese calendar field names are not displayed with
-Djava.locale.providers=HOST on Windows
Reviewed-by: okutsu
!
Hi Aleksey,
On Jun 4, 2013, at 1:36 AM, Aleksey Shipilev wrote:
On 06/04/2013 04:27 AM, Brian Burkhalter wrote:
A) Is there some particular approach that should be used in testing
these algorithms for relative performance?
The number one approach is peer review. Is there the JMH project
Hi Sergey,
On Jun 4, 2013, at 6:49 AM, Sergey Kuksenko wrote:
could you show your benchmark?
Please see code below.
My quick experiments show that current Karatsuba threshold is quite
reasonable.
I hope that you are correct. I would like to know why I am seeing such
different numbers.
Changeset: 8fb68f73d4b1
Author:jjg
Date: 2013-06-04 14:17 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/8fb68f73d4b1
8004643: Reduce javac space overhead introduced with compiler support for
repeating annotations
Reviewed-by: mcimadamore, jfranck
!
Changeset: d6401129327e
Author:dl
Date: 2013-06-04 21:59 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d6401129327e
8005704: Update ConcurrentHashMap to v8
Reviewed-by: chegar, mduigou
! src/share/classes/java/util/concurrent/ConcurrentHashMap.java
Changeset: bd84bad9ee99
Author:jdn
Date: 2013-06-04 15:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bd84bad9ee99
8014097: add doPrivileged methods with limited privilege scope
Reviewed-by: mchung
! src/share/classes/java/security/AccessControlContext.java
!
The com.sun.corba.se.impl package is a private package. The API is
subject to change at any time and no 3rd party code should be using it.
As a result, I'd like to add it to the package restricted list. I've run
our internal CORBA SQE testsuite against the proposed change and didn't
see any
the changes make sense to me
On Jun 4, 2013, at 6:57 PM, Seán Coffey wrote:
The com.sun.corba.se.impl package is a private package. The API is subject to
change at any time and no 3rd party code should be using it. As a result, I'd
like to add it to the package restricted list. I've run our
Hi All,
I didn't see this mail in the mailing list for a long time, so I just
comment here to ensure everyone can receive this message.
Thanks a lot!
On 06/04/2013 09:37 PM, Deven You wrote:
Hi All,
I have written a test case[1] to show this problem. (If it is
confirmed a real bug, I will
42 matches
Mail list logo
