On 6/29/2013 12:05 AM, Shi Jun Zhang wrote:
On 6/28/2013 9:02 PM, Alan Bateman wrote:
On 27/06/2013 22:13, Remi Forax wrote:
On 06/27/2013 10:02 AM, Shi Jun Zhang wrote:
Hi,
There are some isEmpty() check added into get/remove methods since
8011200 to return directly if HashMap is empty. How
Well you can ignore what I wrote below - sorry. Somehow I got it in my
head that multiple enqueue's were intended/supported when of course they
are not. :(
So the proposed fix is okay - though I'd simplify the comment to just:
// Check that since getting the lock this reference hasn't already
On 28/06/2013 19:13, Lance Andersen - Oracle wrote:
Hi Joe,
Looks good.
fwiw, I was able to use H3 vs H1 tags to make doclint accessibility happy.
Not sure if it matters below but thought I would point it out if you want a
smaller heading
I think this is worth checking into because chang
Hi,
There have been two revisions in JAXP 1.5 specification: 1) the
relationship between the JAXP 1.5 properties and
FEATURE_SECURE_PROCESSING (FSP) is now a recommendation. It is up to the
implementation to decide if it wants to restrict when FSP is set. 2)
System properties will override
On 06/28/2013 10:24 PM, Brian Burkhalter wrote:
> http://cr.openjdk.java.net/~bpb/8017540/
Thumbs up.
-Aleksey.
N.B.: You can put me in with "Reviewed-by: shade".
Hi Henry,
On Jun 29, 2013, at 2:58 AM, Henry Jen wrote:
> Hi,
>
> Please review the webrev that add concat static method to Stream and
> primitive Streams.
>
> http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
>
Non test-code looks good.
Now that LongStream.range uses concat you ne
Changeset: 3aa541b50a64
Author:dfuchs
Date: 2013-07-01 11:13 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3aa541b50a64
8014045: test/java/lang/management/PlatformLoggingMXBean/LoggingMXBeanTest.java
failing intermittently
Summary: this test was failing because it didn't ta
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
Hi Henry,
I find the the cast to Spliterator in Streams.concat() dubious,
I can not se
Hi David,
On Mon, 2013-07-01 at 17:51 +1000, David Holmes wrote:
> Well you can ignore what I wrote below - sorry. Somehow I got it in my
> head that multiple enqueue's were intended/supported when of course they
> are not. :(
>
> So the proposed fix is okay - though I'd simplify the comment to
On 07/01/2013 02:05 PM, Thomas Schatzl wrote:
> Fyi, while waiting for your approval, I tried to clean up this a little
> taking into account the comments from Peter and Aleksey (sorry if I
> forgot somebody) into account.
Mandy Chung?
> A webrev for this is at
> http://cr.openjdk.java.net/~tscha
Hi,
The following patch syncs misc-related classes from 166 j.u.c to tl. Basically
stuff that has not already been committed or submitted for review except CHM
stuff (which i will submit next).
Again this contains docs (+ formatting changes) in addition to improvements
(mainly to Exchanger and
On 1/07/2013 8:05 PM, Thomas Schatzl wrote:
Hi David,
On Mon, 2013-07-01 at 17:51 +1000, David Holmes wrote:
Well you can ignore what I wrote below - sorry. Somehow I got it in my
head that multiple enqueue's were intended/supported when of course they
are not. :(
So the proposed fix is okay -
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
Hi Henry,
I find the the cast to Spliterat
On 1/07/2013 8:14 PM, Aleksey Shipilev wrote:
On 07/01/2013 02:05 PM, Thomas Schatzl wrote:
Fyi, while waiting for your approval, I tried to clean up this a little
taking into account the comments from Peter and Aleksey (sorry if I
forgot somebody) into account.
Mandy Chung?
A webrev for thi
On 07/01/2013 03:37 PM, David Holmes wrote:
> On 1/07/2013 8:14 PM, Aleksey Shipilev wrote:
>> The same "thou shalt not do multiple volatile reads" applies to
>> "(r.queue == NULL) || (r.queue == ENQUEUED)" now.
>
> Doesn't that just reduce to "r.queue != this" ? (The assert suggests
> so :) )
T
Hi all,
On Mon, 2013-07-01 at 15:44 +0400, Aleksey Shipilev wrote:
> On 07/01/2013 03:37 PM, David Holmes wrote:
> > On 1/07/2013 8:14 PM, Aleksey Shipilev wrote:
> >> The same "thou shalt not do multiple volatile reads" applies to
> >> "(r.queue == NULL) || (r.queue == ENQUEUED)" now.
> >
> > D
On 07/01/2013 03:51 PM, Thomas Schatzl wrote:
> Hi all,
>
> On Mon, 2013-07-01 at 15:44 +0400, Aleksey Shipilev wrote:
>> On 07/01/2013 03:37 PM, David Holmes wrote:
>>> On 1/07/2013 8:14 PM, Aleksey Shipilev wrote:
The same "thou shalt not do multiple volatile reads" applies to
"(r.que
Indeed. Thanks!
On Jul 1, 2013, at 1:11 AM, Alan Bateman wrote:
> On 30/06/2013 22:26, Nick Williams wrote:
>> In java.sql.DatabaseMetaData, the Javadoc for supportsResultSetHoldability
>> fails to properly close a tag, and so everything following that
>> method is monospace. To be precise:
>>
Hi,
The following is the final j.u.c patch that syncs CMH classes from 166 j.u.c to
tl.
http://cr.openjdk.java.net/~psandoz/tl/JDK-8019484-chm/webrev/
(i am sure there will be more patches to follow as tweaks are made to various
areas, but hopefully they will not need so bulky.)
ConcurrentM
On 28/06/2013 19:24, Brian Burkhalter wrote:
This Request for Review is a refresh of this thread
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018337.html
pertaining to this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8017540
The webrev has been updated in the sa
On 07/01/13 08:44, Paul Sandoz wrote:
The following is the final j.u.c patch that syncs CMH classes from 166 j.u.c to
tl.
http://cr.openjdk.java.net/~psandoz/tl/JDK-8019484-chm/webrev/
Thanks for doing this!
ConcurrentMap.replaceAll in tl was more up to date than that in 166.
Yes, we k
On 07/01/2013 01:36 PM, Peter Levart wrote:
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~henryjen/ccc/8015315.0/webrev/
Cheers,
Henry
On 6/28/13 9:37 PM, Mandy Chung wrote:
Hi Daniel,
On 6/19/2013 8:31 AM, Daniel Fuchs wrote:
The fix proposed is simple. In getGlobal() we check whether
the 'manager' variable is null - and if it is, we initialize it
by calling LogManager.getLogManager().
This is a pattern which is already prese
Changeset: dfb37cc30a67
Author:vinnie
Date: 2013-07-01 14:39 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/dfb37cc30a67
8019259: Failover to CRL checking does not happen if wrong OCSP responder URL
is set
Reviewed-by: xuelei
! src/share/classes/sun/security/provider/certpa
Changeset: f559ef7568ce
Author:mcimadamore
Date: 2013-07-01 14:57 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f559ef7568ce
7034798: Ambiguity error for abstract method call is too eager
Summary: Javac should wait and see if ambiguous methods can be reconciled at
the
Pinging this one again...
On 06/24/13 15:20, Eric McCorkle wrote:
> Pinging this RFR. It still needs a capital R reviewer.
> http://cr.openjdk.java.net/~emc/8016285/
>
> On 06/21/13 19:21, Eric McCorkle wrote:
>> On 06/21/13 16:15, Aleksey Shipilev wrote:
>>> On 06/21/2013 11:57 PM, Eric McCorkl
On 07/01/2013 09:43 AM, Shi Jun Zhang wrote:
On 6/29/2013 12:05 AM, Shi Jun Zhang wrote:
On 6/28/2013 9:02 PM, Alan Bateman wrote:
On 27/06/2013 22:13, Remi Forax wrote:
On 06/27/2013 10:02 AM, Shi Jun Zhang wrote:
Hi,
There are some isEmpty() check added into get/remove methods since
80112
Hi all,
this change excludes the following two MemoryMXBean tests:
- java/lang/management/MemoryMXBean/MemoryTestAllGC.sh
- java/lang/management/MemoryMXBean/MemoryTest.java
This is needed since a change in hotspot added a new memory pool for
metaspace:
> hg log hotspot-main/hotspot:
> changese
Hi all,
this change updates MemoryTest.java to take the newly added Metaspace
and Compressed Class Space MemoryMXBeans into account, as well as the
new Metaspace Memory Manager.
This change also removes the following two tests from ProblemList.txt
since they are now passing again:
-java/lang/mana
On 01/07/2013 09:09, huizhe wang wrote:
Hi,
There have been two revisions in JAXP 1.5 specification: 1) the
relationship between the JAXP 1.5 properties and
FEATURE_SECURE_PROCESSING (FSP) is now a recommendation. It is up to
the implementation to decide if it wants to restrict when FSP is s
On 1 Jul 2013, at 17:22, Remi Forax wrote:
> On 07/01/2013 09:43 AM, Shi Jun Zhang wrote:
>> On 6/29/2013 12:05 AM, Shi Jun Zhang wrote:
>>> On 6/28/2013 9:02 PM, Alan Bateman wrote:
On 27/06/2013 22:13, Remi Forax wrote:
> On 06/27/2013 10:02 AM, Shi Jun Zhang wrote:
>> Hi,
>>
On 07/01/2013 03:19 PM, Remi Forax wrote:
On 07/01/2013 01:36 PM, Peter Levart wrote:
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 06/29/2013 02:58 AM, Henry Jen wrote:
Hi,
Please review the webrev that add concat static method to Stream and
primitive Streams.
http://cr.openjdk.java.net/~h
Sorry, those links didn't include BigIntegerTest.java. Here are the
correct ones:
BigInteger.java
https://raw.github.com/tbuktu/bigint/4c24162e99227e177f17f5db9b8ca2757820d2cd/src/main/java/java/math/BigInteger.java
MutableBigInteger.java
https://raw.github.com/tbuktu/bigint/95f1158d2205614c87393
If you just want to test for platform version (7 vs 8), you might also
look at javax.lang.model.SourceVersion.latest().
-Joe
On 7/1/2013 8:44 AM, Alan Bateman wrote:
On 01/07/2013 09:09, huizhe wang wrote:
Hi,
There have been two revisions in JAXP 1.5 specification: 1) the
relationship bet
On Jul 1, 2013, at 3:19 PM, Doug Lea wrote:
> On 07/01/13 08:44, Paul Sandoz wrote:
>>
>> The following is the final j.u.c patch that syncs CMH classes from 166 j.u.c
>> to tl.
>>
>> http://cr.openjdk.java.net/~psandoz/tl/JDK-8019484-chm/webrev/
>
> Thanks for doing this!
>
Np.
>> Concu
+1
On 2013-07-01, at 1:43, Shi Jun Zhang wrote:
> On 6/29/2013 12:05 AM, Shi Jun Zhang wrote:
>> On 6/28/2013 9:02 PM, Alan Bateman wrote:
>>> On 27/06/2013 22:13, Remi Forax wrote:
On 06/27/2013 10:02 AM, Shi Jun Zhang wrote:
> Hi,
>
> There are some isEmpty() check added in
On 6/29/13 4:55 AM, Peter Levart wrote:
Hi,
I haven't studied this deeply yet, but maybe somebody knows the
answer: Why is it necessary to add root and global loggers to
LogManager in it's static initializer? Global Logger could be created
and initialized lazily, when 1st requested (in static
Hi,
Perhaps the Spliterator.trySplit() method should have been declared as:
Spliterator trySplit();
Regards, Peter
On 07/01/2013 05:50 PM, Peter Levart wrote:
On 07/01/2013 03:19 PM, Remi Forax wrote:
On 07/01/2013 01:36 PM, Peter Levart wrote:
On 07/01/2013 11:52 AM, Remi Forax wrote:
On 7/1/13 6:25 AM, Daniel Fuchs wrote:
Looks good in general. Some comments:
Logger.global is deprecated. In LogManager static initializer, we
should have @SuppressWarnings("deprecation") on Logger.global (probably
need to define a local variable) to suppress the warning and together
with yo
On 7/1/13 7:51 PM, Mandy Chung wrote:
On 6/29/13 4:55 AM, Peter Levart wrote:
Hi,
I haven't studied this deeply yet, but maybe somebody knows the
answer: Why is it necessary to add root and global loggers to
LogManager in it's static initializer? Global Logger could be created
and initialized l
On 6/29/13 7:02 PM, Kumar Srinivasan wrote:
Hi,
Please review changes to cleanup the test area after pack200 test
completion. Some tests generally use large jars and a local copy of
the JDK to
test with, created a generic utility to nuke most of the remains.
The webrev:
http://cr.openjdk.java
Hi Mandy,
Please find an updated webrev.
I have refactored the tests a bit:
renamed "TestGetGlobal2" into "TestGetGlobalByName"
put the auxiliary classes in a sub directory
removed the 'Test' prefix from the auxiliary classes,
added comments in the various LogManagerImpl* classes
updated the 3
Hello,
Yet another found of doclint fixes for review; this batch to
java.lang.instrument.
Thanks,
-Joe
diff -r 9eaeb1a0aa46
src/share/classes/java/lang/instrument/Instrumentation.java
--- a/src/share/classes/java/lang/instrument/Instrumentation.java Sun
Jun 30 17:15:47 2013 -0700
+++ b/src
On Jul 1, 2013, at 1:27 AM, Aleksey Shipilev wrote:
> On 06/28/2013 10:24 PM, Brian Burkhalter wrote:
>> http://cr.openjdk.java.net/~bpb/8017540/
>
> Thumbs up.
Thanks. Now all we need is the imprimatur of an OpenJDK Reviewer.
> -Aleksey.
>
> N.B.: You can put me in with "Reviewed-by: shade".
Thanks Joe! That's the API I was looking for!
On 7/1/2013 9:08 AM, Joe Darcy wrote:
If you just want to test for platform version (7 vs 8), you might also
look at javax.lang.model.SourceVersion.latest().
-Joe
On 7/1/2013 8:44 AM, Alan Bateman wrote:
On 01/07/2013 09:09, huizhe wang wrote:
On 7/1/13 11:23 AM, Daniel Fuchs wrote:
Hi Mandy,
Please find an updated webrev.
I have refactored the tests a bit:
renamed "TestGetGlobal2" into "TestGetGlobalByName"
put the auxiliary classes in a sub directory
removed the 'Test' prefix from the auxiliary classes,
added comments in the vario
Looks good
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Jul 1, 2013, at 2:24 PM, Joe Darcy wrote:
> Hello,
>
> Yet another found of doclint fixes for review; t
On 7/1/2013 8:44 AM, Alan Bateman wrote:
On 01/07/2013 09:09, huizhe wang wrote:
Hi,
There have been two revisions in JAXP 1.5 specification: 1) the
relationship between the JAXP 1.5 properties and
FEATURE_SECURE_PROCESSING (FSP) is now a recommendation. It is up to
the implementation to d
On 01/07/2013 19:24, Joe Darcy wrote:
Hello,
Yet another found of doclint fixes for review; this batch to
java.lang.instrument.
Thanks,
-Joe
This looks okay to me.
-Alan
On 07/01/2013 08:07 PM, Daniel Fuchs wrote:
On 7/1/13 7:51 PM, Mandy Chung wrote:
On 6/29/13 4:55 AM, Peter Levart wrote:
Hi,
I haven't studied this deeply yet, but maybe somebody knows the
answer: Why is it necessary to add root and global loggers to
LogManager in it's static initializer? Gl
Changeset: 1908e86ee49a
Author:darcy
Date: 2013-07-01 11:58 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1908e86ee49a
7162089: Add support for repeating annotations to javax.annotation.processing
Reviewed-by: abuckley, jjg, jfranck
!
src/share/classes/com/sun/tools/
Changeset: c8cf01de8fa8
Author:bpb
Date: 2013-07-01 11:30 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c8cf01de8fa8
8017540: Improve multi-threaded contention behavior of radix conversion cache
Summary: Replace array of ArrayList of BigIntegers with a volatile
two-dimensio
Tim,
On Jun 30, 2013, at 4:20 PM, Tim Buktu wrote:
> I made a few changes to the BigInteger code in my GitHub repo:
> * Moved Burnikel-Ziegler division to MutableBigInteger
> * Added more comments to the Burnikel-Ziegler code
> * Updated Barrett thresholds
> * Merged BigInteger.java and BigIntege
On 01/07/2013 19:33, huizhe wang wrote:
:
I've updated the jaxp 1.5 tests. I'll send a separate link since it's
internal. Indeed, I missed a couple of scenarios: 1) FSP can be set
after jaxp 1.5 properties are set through the API; 2) Validator does
not require, but does support FSP.
Given the
Changeset: 3736ad2636aa
Author:darcy
Date: 2013-07-01 13:29 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3736ad2636aa
8019527: Fix doclint issues in java.lang.instrument
Reviewed-by: lancea, alanb
! src/share/classes/java/lang/instrument/Instrumentation.java
Hello,
There are a few doclint issues to be fixed in java.util.spi; thanks,
-Joe
diff -r 3736ad2636aa
src/share/classes/java/util/spi/LocaleServiceProvider.java
--- a/src/share/classes/java/util/spi/LocaleServiceProvider.java Mon Jul
01 13:29:32 2013 -0700
+++ b/src/share/classes/java/util/sp
Looks fine
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPad
On Jul 1, 2013, at 4:35 PM, Joe Darcy wrote:
> Hello,
>
> There are a few doclint issues to be fixed in ja
Changeset: 8e5376324e4b
Author:darcy
Date: 2013-07-01 13:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8e5376324e4b
8019529: Fix doclint issues in java.util.spi
Reviewed-by: lancea
! src/share/classes/java/util/spi/LocaleServiceProvider.java
Hello,
The patch below resolves the two remaining doclint issues in
java.time.format.
Thanks,
-Joe
--- a/src/share/classes/java/time/format/DateTimeFormatter.java Mon Jul
01 13:42:03 2013 -0700
+++ b/src/share/classes/java/time/format/DateTimeFormatter.java Mon Jul
01 13:53:45 2013 -0700
We generally don't delve into low-level presentation details, but the
change looks fine -- approved to go back.
Cheers,
-Joe
On 7/1/2013 8:04 AM, Eric McCorkle wrote:
Pinging this one again...
On 06/24/13 15:20, Eric McCorkle wrote:
Pinging this RFR. It still needs a capital R reviewer.
ht
These look fine.
(But I'm not an official reviewer.)
On 7/1/2013 4:55 PM, Joe Darcy wrote:
Hello,
The patch below resolves the two remaining doclint issues in
java.time.format.
Thanks,
-Joe
--- a/src/share/classes/java/time/format/DateTimeFormatter.java Mon
Jul 01 13:42:03 2013 -0700
+++
On 7/1/2013 11:14 AM, Mandy Chung wrote:
On 6/29/13 7:02 PM, Kumar Srinivasan wrote:
Hi,
Please review changes to cleanup the test area after pack200 test
completion. Some tests generally use large jars and a local copy of
the JDK to
test with, created a generic utility to nuke most of the re
+1 joe
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
Sent from my iPhone
On Jul 1, 2013, at 4:55 PM, Joe Darcy wrote:
> Hello,
>
> The patch below resolves the two remaining doc
On 7/1/2013 2:11 PM, Kumar Srinivasan wrote:
In Utils.cleanup, it will delete the files with certain extensions in
the current directory. I skimmed on the tests and look to me that
those files can be altered with a different path and not necessary in
the current directory. Just wonder if you
Changeset: 5427f7316633
Author:darcy
Date: 2013-07-01 14:33 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5427f7316633
8019535: Fix doclint issues in java.time.format
Reviewed-by: lancea, rriggs
! src/share/classes/java/time/format/DateTimeFormatter.java
On 7/1/2013 2:45 PM, Mandy Chung wrote:
On 7/1/2013 2:11 PM, Kumar Srinivasan wrote:
In Utils.cleanup, it will delete the files with certain extensions
in the current directory. I skimmed on the tests and look to me
that those files can be altered with a different path and not
necessary in t
On 06/28/2013 12:10 PM, Brian Burkhalter wrote:
Continuing this thread
http://mail.openjdk.java.net/pipermail/core-libs-dev/2013-June/018326.html
with respect to this issue
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6178739
this Request for Review proposes the following change to the
Changeset: 17f44b2dde41
Author:juh
Date: 2013-07-01 17:46 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/17f44b2dde41
8019539: Fix doclint errors in java.security and its subpackages
Reviewed-by: darcy
! src/share/classes/java/security/KeyStore.java
! src/share/classes/java/
This recently added test was found to fail under some conditions -
namely client compiler with -Xcomp. It seems that the use of all local
variables enabled the compiler to optimize things in a way that stopped
the weakref from being enqueued as expected. Simple fix was to make the
weakref a fie
69 matches
Mail list logo
