Joe
Looks ok as well
Best
Lance
--
Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
lance.ander...@oracle.com
On Aug 4, 2013, at 9:04 PM, Joe Darcy wrote:
> Hello,
>
> Please review this fix for
>
>80
Alan, Tim,
I have addressed your comments and as a result - new webrev:
http://cr.openjdk.java.net/~aefimov/8021820/webrev.01
The list of changes:
1. The connection to Oracle site is removed (it's not internal, but
anyway it's better not to rely on availability of external resource in
test). I
Changeset: 80da091343af
Author:darcy
Date: 2013-08-05 07:50 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/80da091343af
8022190: Fix varargs lint warnings in the JDK
Reviewed-by: alanb, lancea, alexsch
! src/share/classes/java/util/stream/Stream.java
! src/share/classes/java
The fix looks good for me.
Thanks,
Alexandr.
On 8/5/2013 5:04 AM, Joe Darcy wrote:
Hello,
Please review this fix for
8022190: Fix varargs lint warnings in the JDK
http://cr.openjdk.java.net/~darcy/8022190.0/
Full patch below.
While the @SafeVarargs annotation generally suppre
Changeset: 87367a1c7f76
Author:sundar
Date: 2013-08-05 21:31 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/87367a1c7f76
8016531: jconsole-plugin script demo does not work with nashorn
Reviewed-by: lagergren, hannesw
Contributed-by: rieberandr...@gmail.com
!
src/share/demo/
Here is new version of the fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.02/
Changes (in accordance with Alan's recommendations):
-- Magic constant -1 was changed to JAVA_INVALID_HANDLE_VALUE with
explanation why the macro
INVALID_HANDLE_VALUE is not in use.
-- The com
Hi, Chris.
> I also noticed this. Running the test explicitly seems to locate just the
> first @test, while running in a batch (sometimes) finds the two! Not sure
> why.
If you execute jtreg with explicit file name(s), only those files will be
search for "@test" tags. If you use anything els
Hi Steven,
This looks like a promising patch. If all goes well I can sponsor this
patch into hotspot-rt.
I have problems building your test. Could you send a stand-alone test
that can be build with plain JDK (i.e., exclude things like
com.google.common. and org.openjdk.jmh)?
Also, I saw t
On 08/05/2013 10:15 PM, Ioi Lam wrote:
> I have problems building your test. Could you send a stand-alone test
> that can be build with plain JDK (i.e., exclude things like
> com.google.common. and org.openjdk.jmh)?
I would strongly advise against dropping JMH. Maintaining the benchmark
with JMH
Hi Steven,
On 08/05/2013 09:21 AM, Steven Schlansker wrote:
> Here is the patch I have at the moment:
> https://gist.github.com/stevenschlansker/6153643
Would you like to make char_cmp() and char_cpy() "inline"? In release,
they can then be compiled straight to memcmp/memcpy.
> This is almost a
Hi all,
Please review the following RMI javadoc change that clarifies the exporting
behavior and that provides an example of how to modify it.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020854
Webrev: http://cr.openjdk.java.net/~smarks/reviews/8020854/webrev.0/
Specdiff: http:/
Hi Joe,
On Jul 25, 2013, at 2:28 PM, Brian Burkhalter wrote:
>> I took a look through the code and I don't see how sdiff ==
>> Integer.MIN_VALUE is handled.
>
> This case, if compareMagnitude() does not return at lines 2668 or 2670,
> intentionally falls through to line 2690. Otherwise, if hyp
Hello,
Sorry for the repeated review delays.
This looks fine to go back.
Thanks,
-Joe
On 7/22/2013 6:27 AM, Joel Borggren-Franck wrote:
Hi Amy,
I'm happy with the current iteration. I'll help you find an official
reviewer.
cheers
/Joel
On 2013-07-22, Amy Lu wrote:
Thank you Joel for all
Hi Aleksej,
Thanks for the update. I took a look at the revised test, and there are still
some issues. (I didn't look at the build changes.)
1) System-specific resource limits.
I think the biggest issue is resource limits on the number of open files per
process that might vary from system to
On 05/08/2013 13:44, Stuart Marks wrote:
Hi all,
Please review the following RMI javadoc change that clarifies the
exporting behavior and that provides an example of how to modify it.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020854
Webrev: http://cr.openjdk.java.net/~smarks/r
Changeset: 31759750ff63
Author:smarks
Date: 2013-08-05 19:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/31759750ff63
8020854: change RMI javadocs to specify that remote objects are exported to the
wildcard address
Reviewed-by: rgallard, alanb
! src/share/classes/java/rm
On 8/5/13 6:16 PM, Alan Bateman wrote:
On 05/08/2013 13:44, Stuart Marks wrote:
Hi all,
Please review the following RMI javadoc change that clarifies the exporting
behavior and that provides an example of how to modify it.
Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8020854
Webrev
On 05/08/2013 09:05, Alexey Utkin wrote:
Here is new version of the fix:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-7147084/webrev.02/
Changes (in accordance with Alan's recommendations):
-- Magic constant -1 was changed to JAVA_INVALID_HANDLE_VALUE with
explanation why the macro
INVA
Ping on this, the 8012238 fix is already in, thus this webrev is ready
to go, only if we can have a reviewer review it.
Cheers,
Henry
On 07/09/2013 02:38 PM, Henry Jen wrote:
> Hi,
>
> An update from earlier request based on some feedbacks.
>
> The webrev is at
>
> http://cr.openjdk.java.net/
19 matches
Mail list logo
