RFR JDK-8022721 : AnnotationTypeDeadlockTest.java throws java.lang.IllegalStateException: unexpected condition

2013-08-17 Thread Peter Levart
Hi, Please review the fix for a test that tries to provoke a deadlock when parsing annotations: http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/fix1/webrev.01/ The test was failing on slow machines when run with -Xcomp due to a short time out (5s). The fix makes the test only fail w

Re: RFR JDK-8022721 : AnnotationTypeDeadlockTest.java throws java.lang.IllegalStateException: unexpected condition

2013-08-17 Thread Alan Bateman
On 17/08/2013 14:06, Peter Levart wrote: Hi, Please review the fix for a test that tries to provoke a deadlock when parsing annotations: http://cr.openjdk.java.net/~plevart/jdk8-tl/AnnotationType/fix1/webrev.01/ The test was failing on slow machines when run with -Xcomp due to a short time

Re: Enum.valueOf(String)

2013-08-17 Thread Paul Benedict
I think the generated method needs to be listed in the class javadoc at least. I presume it throws an exception too (like the other valueOf) if the String can't be resolved to a constant, but no user is going to discover this fact through the documentation. On Sat, Aug 17, 2013 at 12:32 AM, Nick