hg: jdk8/tl/jdk: 8023101: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails

2013-08-22 Thread staffan . larsen
Changeset: a0896634ab46 Author:sla Date: 2013-08-22 08:28 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/a0896634ab46 8023101: java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java fails Reviewed-by: ysr !

Re: RFR: JDK-8023430 - Replace File.mkdirs with Files.createDirectories to get MaxPathLength.java failure details

2013-08-22 Thread Alan Bateman
On 21/08/2013 22:06, Dan Xu wrote: : Thanks, Alan. I have updated my webrev at, http://cr.openjdk.java.net/~dxu/8023430/webrev.01/. Please take a look! This looks okay now. -Alan

Re: RFR: 8022445: fix RMISocketFactory example to avoid using localhost

2013-08-22 Thread Chris Hegarty
Stuart, I think I would have picked the more common IPv4 loopback address, 127.0.0.1, but what you have is fine. -Chris. On 08/22/2013 01:58 AM, Stuart Marks wrote: Hi all, Please review this small documentation change to the example I added to RMISocketFactory a couple weeks ago [1]. This

Re: RFR: 8022445: fix RMISocketFactory example to avoid using localhost

2013-08-22 Thread Alan Bateman
On 22/08/2013 01:58, Stuart Marks wrote: Hi all, Please review this small documentation change to the example I added to RMISocketFactory a couple weeks ago [1]. This change fixes a problem that Bernd Eckenfels pointed out [2] where the interface returned by getLoopbackAddress() might not

hg: jdk8/tl/langtools: 8022316: Generic throws, overriding and method reference

2013-08-22 Thread vicente . romero
Changeset: 7a4717f3ea7b Author:vromero Date: 2013-08-22 10:22 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/7a4717f3ea7b 8022316: Generic throws, overriding and method reference Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Types.java +

Re: RFR: Remove tests from ProblemList.txt

2013-08-22 Thread David Holmes
On 22/08/2013 12:20 AM, Staffan Larsen wrote: I've had a look at these two old bugs: http://bugs.sun.com/view_bug.do?bug_id=7020857 http://bugs.sun.com/view_bug.do?bug_id=6909804 They are both listed in ProblemList.txt and reported as intermittent failures in 2011 and 2009 respectively.

Re: RFR: Remove tests from ProblemList.txt

2013-08-22 Thread Staffan Larsen
On 22 aug 2013, at 13:32, David Holmes david.hol...@oracle.com wrote: On 22/08/2013 12:20 AM, Staffan Larsen wrote: I've had a look at these two old bugs: http://bugs.sun.com/view_bug.do?bug_id=7020857 http://bugs.sun.com/view_bug.do?bug_id=6909804 They are both listed in

Re: RFR 8023463 Update HashMap and LinkedHashMap to use bins/buckets or trees (red/black)

2013-08-22 Thread Paul Sandoz
On Aug 21, 2013, at 6:47 PM, Paul Sandoz paul.san...@oracle.com wrote: I updated the webrev and replaced TreeBinSplitBackToEntries.java with: http://cr.openjdk.java.net/~psandoz/tl/JDK-8023463-Linked-HashMap-bin-and-tree/webrev/test/java/util/Map/MapBinToFromTreeTest.java.html Another

hg: jdk8/tl/langtools: 8023112: javac should not use lazy constant evaluation approach for method references

2013-08-22 Thread vicente . romero
Changeset: 25aaff78d754 Author:vromero Date: 2013-08-22 13:12 +0100 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/25aaff78d754 8023112: javac should not use lazy constant evaluation approach for method references Reviewed-by: jjg, mcimadamore !

Re: RFR: Remove tests from ProblemList.txt

2013-08-22 Thread Daniel D. Daugherty
On 8/22/13 5:32 AM, David Holmes wrote: On 22/08/2013 12:20 AM, Staffan Larsen wrote: I've had a look at these two old bugs: http://bugs.sun.com/view_bug.do?bug_id=7020857 http://bugs.sun.com/view_bug.do?bug_id=6909804 They are both listed in ProblemList.txt and reported as intermittent

Re: RFR 8023463 Update HashMap and LinkedHashMap to use bins/buckets or trees (red/black)

2013-08-22 Thread Alan Bateman
On 22/08/2013 13:01, Paul Sandoz wrote: On Aug 21, 2013, at 6:47 PM, Paul Sandozpaul.san...@oracle.com wrote: I updated the webrev and replaced TreeBinSplitBackToEntries.java with:

Re: RFR: 8022445: fix RMISocketFactory example to avoid using localhost

2013-08-22 Thread Alan Bateman
On 22/08/2013 13:48, Bernd Eckenfels wrote: getLoopbackAddress is either ::1 or 127.0.0.1 (depending on the stack preferemces) and InetAddress.getByName(localhost) is also one of both (but not necesarily the same, unfortunately). This happened to me in the past, so I wanted to make sure that

Re: RFR [7129312] BufferedInputStream calculates negative array size with large streams and mark

2013-08-22 Thread Ivan Gerasimov
Thank you Alan! Would you please review the updated webrev? http://cr.openjdk.java.net/~igerasim/7129312/3/webrev/ http://cr.openjdk.java.net/%7Eigerasim/7129312/2/webrev/ On 21.08.2013 13:28, Alan Bateman wrote: On 20/08/2013 17:01, Ivan Gerasimov wrote: Yes, you're right! I've updated

Re: Update jdk8/tl/jaxws to v2.2.9-b14140 ready for review

2013-08-22 Thread Chris Hegarty
On 08/20/2013 11:04 AM, Alan Bateman wrote: On 20/08/2013 07:23, Miroslav Kos wrote: Hi everybody, I prepared a new changeset containing no copyright changes so we can get further: http://cr.openjdk.java.net/~mkos/8022885/webrev.01/ We will discuss rngom changes separately and if necessary,

Please review fix for 8011944 : Sort fails with ArrayIndexOutOfBoundsException

2013-08-22 Thread roger riggs
Please review the fix for: JDK-8011944[1] : Sort fails with ArrayIndexOutOfBoundsException The pending run stack size is estimated based on the input size. The worst case sequence of inputs exceeds the current allocation and an exception occurs. Increasing the allocation of the pending run

hg: jdk8/tl/jdk: 8023587: Fix lone remaining doclint issue in java.util.regex

2013-08-22 Thread joe . darcy
Changeset: b7c4094be729 Author:darcy Date: 2013-08-22 09:40 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b7c4094be729 8023587: Fix lone remaining doclint issue in java.util.regex Reviewed-by: jjg ! src/share/classes/java/util/regex/Pattern.java

hg: jdk8/tl/langtools: 8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables

2013-08-22 Thread eric . mccorkle
Changeset: 1ab22e60a738 Author:emc Date: 2013-08-22 12:47 -0400 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/1ab22e60a738 8020745: Suspicious MethodParameters attribute generated for local classes capturing local variables Summary: Corrected an error in a previous patch

hg: jdk8/tl/jdk: 8023430: Replace File.mkdirs with Files.createDirectories to get MaxPathLength.java failure details

2013-08-22 Thread dan . xu
Changeset: 8a7d9cc2f41c Author:dxu Date: 2013-08-22 11:43 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a7d9cc2f41c 8023430: Replace File.mkdirs with Files.createDirectories to get MaxPathLength.java failure details Reviewed-by: alanb ! test/ProblemList.txt !

JDK 8 RFR 6470700: Math.random() / Math.initRNG() uses double checked locking

2013-08-22 Thread Brian Burkhalter
JDK 8 Reviewers: The proposed patch is here: http://cr.openjdk.java.net/~bpb/6470700/ JTREG tests pass and JMH benchmarking shows a very slight performance improvement versus the extant code. Thanks, Brian On Aug 21, 2013, at 7:23 PM, Mike Duigou wrote: On Aug 21 2013, at 17:01 , David M.

Re: JDK 8 RFR 6470700: Math.random() / Math.initRNG() uses double checked locking

2013-08-22 Thread Alan Bateman
On 22/08/2013 20:41, Brian Burkhalter wrote: JDK 8 Reviewers: The proposed patch is here: http://cr.openjdk.java.net/~bpb/6470700/ JTREG tests pass and JMH benchmarking shows a very slight performance improvement versus the extant code. It looks okay to me although the downside of this

Re: JDK 8 RFR 6470700: Math.random() / Math.initRNG() uses double checked locking

2013-08-22 Thread Brian Burkhalter
You are correct: it should be private - I'll fix that. Thanks, Brian On Aug 22, 2013, at 12:46 PM, Alan Bateman wrote: It looks okay to me although the downside of this idiom is yet another class (which I assume can private btw).

hg: jdk8/tl/langtools: 8022173: Relax some warnings in doclint

2013-08-22 Thread jonathan . gibbons
Changeset: b77381d99056 Author:jjg Date: 2013-08-22 12:41 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/b77381d99056 8022173: Relax some warnings in doclint Reviewed-by: darcy ! src/share/classes/com/sun/tools/doclint/HtmlTag.java !

Re: JDK 8 RFR 6470700: Math.random() / Math.initRNG() uses double checked locking

2013-08-22 Thread Chris Hegarty
On 08/22/2013 08:46 PM, Alan Bateman wrote: On 22/08/2013 20:41, Brian Burkhalter wrote: JDK 8 Reviewers: The proposed patch is here: http://cr.openjdk.java.net/~bpb/6470700/ JTREG tests pass and JMH benchmarking shows a very slight performance improvement versus the extant code. It looks

hg: jdk8/tl/jdk: 8022721: AnnotationTypeDeadlockTest.java throws java.lang.IllegalStateException: unexpected condition

2013-08-22 Thread peter . levart
Changeset: 2281a7f79738 Author:plevart Date: 2013-08-20 14:13 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2281a7f79738 8022721: AnnotationTypeDeadlockTest.java throws java.lang.IllegalStateException: unexpected condition Reviewed-by: alanb, jfranck !

Re: RFR: 8022445: fix RMISocketFactory example to avoid using localhost

2013-08-22 Thread Stuart Marks
On 8/22/13 6:48 AM, Alan Bateman wrote: On 22/08/2013 13:48, Bernd Eckenfels wrote: getLoopbackAddress is either ::1 or 127.0.0.1 (depending on the stack preferemces) and InetAddress.getByName(localhost) is also one of both (but not necesarily the same, unfortunately). This happened to me in

hg: jdk8/tl/jdk: 8022445: fix RMISocketFactory example to avoid using localhost

2013-08-22 Thread stuart . marks
Changeset: 7496ec8bab76 Author:smarks Date: 2013-08-22 15:54 -0700 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7496ec8bab76 8022445: fix RMISocketFactory example to avoid using localhost Reviewed-by: chegar, alanb ! src/share/classes/java/rmi/server/RMISocketFactory.java

Re: RFR: 8022343: j.l.Class.getAnnotatedSuperclass() doesn't return null in some cases

2013-08-22 Thread Joseph Darcy
Hi Joel, The new version is better, but for the testing in question I would prefer to see something even simpler like: public static void main(String[] args) throws Exception { int failed = 0; Class?[] testData = {/* list of class literals*/} for (Class? toTest:

RFR [8023130] (process) ProcessBuilder#inheritIO does not work on Windows

2013-08-22 Thread Ivan Gerasimov
Hello everybody! The method ProcessBuilder#inheritIO() is reported to not have any effect on Windows platform. The same story is with redirectOutput/Input/Error(Redirect.INHERIT) methods. As the result, standard in/out/err aren't inherited. It turn out that the culprit is the CREATE_NO_WINDOW

RFR: 8023528: Rename Comparator combinators to disambiguate overloading methods

2013-08-22 Thread Henry Jen
Hi, Please review a relative simple webrev[1] that basically simply renaming Comparator methods. The reason behind the renaming can be found at this email thread[2]. The specdiff is also available here[3]. Cheers, Henry [1] http://cr.openjdk.java.net/~henryjen/ccc/8023528/0/webrev/ [2]

Re: RFR: 8023528: Rename Comparator combinators to disambiguate overloading methods

2013-08-22 Thread Stuart Marks
Hi Henry, Changes look good. It's also good to see some now-extra casts and type witnesses removed. It somewhat makes up for the longer, non-overloaded method names. Note, corrected email thread[2] link: http://mail.openjdk.java.net/pipermail/lambda-libs-spec-experts/2013-August/002206.html

hg: jdk8/tl/jdk: 2 new changesets

2013-08-22 Thread staffan . larsen
Changeset: 7b6211cd8d76 Author:egahlin Date: 2013-08-21 17:15 +0200 URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7b6211cd8d76 6417649: -interval=0 is accepted and jconsole doesn't update window content at all Reviewed-by: alanb, jbachorik !