On 08/11/2013 00:39, David Holmes wrote:
And linux? It has changed to vfork right?
So OSX has changed, linux has changed, but Solaris remains as-is. All
platforms allow selecting the mechanism via the property
jdk.lang.Process.launchMechanism
The only change is OSX where the default switche
Changeset: 8a4405fb40ba
Author:ykantser
Date: 2013-11-07 16:55 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/8a4405fb40ba
8027752: sun/tools/jstatd/TestJstatdExternalRegistry.java:
java.lang.SecurityException: attempt to add a Permission to a readonly
Permissions object
Re
On 08/11/2013 03:41, Patrick Zhang wrote:
Sorry, I have some problems to connect to cr.openjdk.java.net yesterday.
Now the webrev and result are attached. Please help to review.
After checking the scripts in java.util, most of scripts have been
finished in 8003890. So the webrev only change 2 r
Hi Stuart,
Unfortunately, several Java SE interfaces have public SVUIDs, so the fix can
cause confusion:
$ serialver java.security.PublicKey
java.security.PublicKey:private static final long serialVersionUID =
7187392471159151072L;
$ javap java.security.PublicKey
Compiled from "PublicKey.j
Hi Alan,
I have created https://bugs.openjdk.java.net/browse/JDK-8028044 to hold it.
Regards
Patrick
On 11/8/13 5:24 PM, Alan Bateman wrote:
On 08/11/2013 03:41, Patrick Zhang wrote:
Sorry, I have some problems to connect to cr.openjdk.java.net yesterday.
Now the webrev and result are attach
/Thank you, Stuart
There is one review point I want to ask you opinion. Which is the reason
that I moved from test/java/rmi/reliability/benchmark/bench/rmi to
test/java/rmi/reliability/benchmark is Main.java need access class
TestLibrary for supporting random port. TestLibrary is a unpackage
c
Hi,
Can I ask reviewers to look at this fix? As was mentioned, the testing
issues described in request were resolved.
Thanks in advance,
Aleksej
On 11/06/2013 11:11 PM, Aleksej Efimov wrote:
Hi,
We have a fix for JDK-8027848 and it was approved in parallel thread.
With '-XX:-UseMathExactInt
Looks good to me. It should have been this way from day one.
-Chris.
On 08/11/2013 03:02, Stuart Marks wrote:
Hi all,
Please review this quick one-liner to change the serialver tool so that
it emits a serialVersionUID declaration with the 'private' modifier,
which comports with the recommendat
On 08/11/2013 09:45, Yuri Gaevsky wrote:
Hi Stuart,
Unfortunately, several Java SE interfaces have public SVUIDs, so the fix can
cause confusion:
I think Stuart's suggestion is good for the case where the class doesn't
have the serialVersionUID already, you just paste it into the source
code
>> Unfortunately, several Java SE interfaces have public SVUIDs, so the fix can
>> cause confusion:
> I think Stuart's suggestion is good for the case where the class doesn't have
> the serialVersionUID already, you just paste it into the source code to keep
> the value as it was generated previ
On 8/11/2013 8:13 PM, Patrick Zhang wrote:
Hi Alan,
I have created https://bugs.openjdk.java.net/browse/JDK-8028044 to hold it.
My understanding is that 8019502 was originally covering this issue for
a broad range of tests across different areas. They were then split out
into different CRs f
vfork was the default in Linux before 5049299. You can see the variable
START_CHILD_USE_VFORK being set in:
http://cr.openjdk.java.net/~robm/5049299/webrev.06/src/solaris/native/java/lang/UNIXProcess_md.c.cdiff.html
-Rob
On 08/11/13 00:39, David Holmes wrote:
On 7/11/2013 11:53 PM, Rob Mc
Hi
Please review fix for: https://bugs.openjdk.java.net/browse/JDK-8028055
(reflect) invoking Method/Constructor in anonymous classes breaks with
-Dsun.reflect.noInflation=true
As Peter observed here [1] the current fix is incomplete as it does not
work when -Dsun.reflect.noInflation=true is set.
On 06/11/2013 18:44, Xueming Shen wrote:
Hi,
The latest spec and implementation of java.util.Base64.getXXXEncoder()
is to add appropriate padding character(s) at the end of the output
encoded data stream, to follow the note explicitly specified in the
RFC
Implementations MUST include appropr
> Well, it would be more consistent to check for existence of protected or
> public serialVersionUID with Reflection API and change the serialver output
> accordingly.
Please see suggested fix and its output below.
Thanks,
-Yuri
$ serialver java.security.PublicKey
java.security.PublicKey:p
Alan,
> An alternative might be to just throw the IOException with
> InterruptedException as the cause.
Perfect. Updated in the new webrev.
Dan,
You are completely correct. I was only catering for the case where
"java.nio.file.FileSystemException: : The process cannot
access the file beca
http://cr.openjdk.java.net/~vlivanov/8027823/webrev.00/
MethodHandleImpl.makeGuardWithCatch has special invokers
(GuardWithCatch.invoke_L*) for methods with arity up to 8.
When method arity is larger, generic invoker (GuardWithCatch.invoke_V)
is used.
Generic invoker expects GuardWithCatch.ta
Changeset: 41d7ce111bd8
Author:mchung
Date: 2013-11-08 07:53 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/41d7ce111bd8
8027351: (ref) Private finalize method invoked in preference to protected
superclass method
Reviewed-by: alanb, dholmes, mr, plevart, psandoz
! makefiles
Changeset: 3112729d6b74
Author:tyan
Date: 2013-11-08 15:12 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/3112729d6b74
8022963: java/net/NetworkInterface/Equals.java fails equality for Windows
Teredo Interface
Reviewed-by: chegar
! test/java/net/MulticastSocket/TestInterfac
Changeset: 771c77b49bb6
Author:chegar
Date: 2013-11-08 15:15 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/771c77b49bb6
8019834: InetAddress.getByName hangs for bad IPv6 literals
Reviewed-by: alanb
! src/share/classes/java/net/InetAddress.java
! test/java/net/ipv6tests/BadI
looks fine. I would assume you've also run the corresponding tests at
test/closed repo.
-Sherman
On 11/5/2013 8:38 AM, Aleksej Efimov wrote:
Hi,
Can I have a review for tzdata2013h integration [1]. The webrev link can be
located here [2].
The following test sets were executed on build with
Changeset: 1c9ba18198d5
Author:mchung
Date: 2013-11-08 09:43 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1c9ba18198d5
8028069: (ref) Finalizer.c not deleted in the changeset for JDK-8027351
Reviewed-by: alanb
- src/share/native/java/lang/ref/Finalizer.c
Hi Tristan,
Yes, it's kind of a problem that the RMI TestLibrary is in the unnamed package.
Classes in a named package cannot import classes from the unnamed package. We've
run into problems with this before. Eventually, we should move TestLibrary a
named package.
I think it's possible to wo
On 11/8/13 7:20 AM, Yuri Gaevsky wrote:
Well, it would be more consistent to check for existence of protected or public
serialVersionUID with Reflection API and change the serialver output
accordingly.
Please see suggested fix and its output below.
This change isn't consistent with the inte
Hello,
Please review the simple patch below which addresses a handful of raw
types lint warning in the core reflection implementation code.
(If memory serves, this code dates back from a time during the
development of JDK 5 when wildcards could not be used with arrays;
before the release shi
looks fine Joe
On Nov 8, 2013, at 2:40 PM, Joe Darcy wrote:
> Hello,
>
> Please review the simple patch below which addresses a handful of raw types
> lint warning in the core reflection implementation code.
>
> (If memory serves, this code dates back from a time during the development of
> JD
Changeset: 46982ca895b4
Author:tyan
Date: 2013-11-08 18:54 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/46982ca895b4
8023462: TEST_BUG: test/com/sun/net/httpserver/bugs/B6433018.java fails on
slow/single core machine
Reviewed-by: chegar
! test/com/sun/net/httpserver/bugs/
On 08/11/2013 19:40, Joe Darcy wrote:
Hello,
Please review the simple patch below which addresses a handful of raw
types lint warning in the core reflection implementation code.
(If memory serves, this code dates back from a time during the
development of JDK 5 when wildcards could not be us
Changeset: 40ca9e4866de
Author:mchung
Date: 2013-11-08 12:13 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/40ca9e4866de
8025985: com.sun.management.OSMBeanFactory should not be public
Reviewed-by: alanb, erikj, ihse, jbachorik
! makefiles/lib/ServiceabilityLibraries.gmk
! m
Changeset: 11376ad23e21
Author:darcy
Date: 2013-11-08 12:19 -0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/11376ad23e21
8028076: Correct raw type lint warnings in core reflection implementation
classes
Reviewed-by: lancea, alanb
!
src/share/classes/sun/reflect/generics/ref
On 11/08/2013 12:06 PM, Alan Bateman wrote:
On 08/11/2013 19:40, Joe Darcy wrote:
Hello,
Please review the simple patch below which addresses a handful of raw
types lint warning in the core reflection implementation code.
(If memory serves, this code dates back from a time during the
develo
Looks good Joe.
cheers
/Joel
On 8 nov 2013, at 20:40, Joe Darcy wrote:
> Hello,
>
> Please review the simple patch below which addresses a handful of raw types
> lint warning in the core reflection implementation code.
>
> (If memory serves, this code dates back from a time during the develo
Stuart,
Sorry, but such inconsistency between serialver/javap is a bug (IMHO, of
course).
> If there happens to be a declaration in the class that, probably mistakenly,
> goes against this advice, serialver shouldn't emit a line that perpetuates
> this mistake.
I would argue that for any real
Hi,
Please review this correction to the documentation of the serialized
form of String.
There is no change to the specification or behavior of the serialization
of strings.
It seemed safer to refer to the serialization specification and remove the
incorrect details instead of trying to corre
Changeset: 50df04934e86
Author:alanb
Date: 2013-11-08 21:07 +
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/50df04934e86
8028074: InetAddress.getByName fails with UHE "invalid IPv6 address" if host
name starts with a-f
Reviewed-by: chegar
! src/share/classes/java/net/InetAdd
On 08/11/2013 20:56, roger riggs wrote:
Hi,
Please review this correction to the documentation of the serialized
form of String.
There is no change to the specification or behavior of the
serialization of strings.
It seemed safer to refer to the serialization specification and remove
the
in
On 11/8/13 1:34 PM, Alan Bateman wrote:
On 08/11/2013 20:56, roger riggs wrote:
Please review this correction to the documentation of the serialized form of
String.
There is no change to the specification or behavior of the serialization of
strings.
It seemed safer to refer to the serialization
On 11/08/2013 06:00 AM, Alan Bateman wrote:
On 06/11/2013 18:44, Xueming Shen wrote:
Hi,
The latest spec and implementation of java.util.Base64.getXXXEncoder()
is to add appropriate padding character(s) at the end of the output
encoded data stream, to follow the note explicitly specified in the
Have you had a chance to think about this? Can the MIME decoder be made
more lenient, or can I get an option to control this?
Bill Shannon wrote on 10/25/13 15:24:
> Xueming Shen wrote on 10/25/13 15:19:
>> On 10/25/13 2:19 PM, Bill Shannon wrote:
>>> If I understand this correctly, this proposes
Hi Stuart,
I agree that {@docroot} is preferred.
The serialization spec is in a parallel directory to the API spec.
The platform/ docs are above the api docs, so at least 1 "../" is needed.
I tried it with {@docroot}/../... but the normal docs build defaulted
docroot to "/"
and the link did not
Reviewed. Thanks for the fix. The test case will also be a useful quick test
for unboxed catchEx paths. — John
On Nov 8, 2013, at 7:25 AM, Vladimir Ivanov
wrote:
> http://cr.openjdk.java.net/~vlivanov/8027823/webrev.00/
>
> MethodHandleImpl.makeGuardWithCatch has special invokers
> (Guard
Changeset: df2f7f288353
Author:rriggs
Date: 2013-11-08 17:50 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/df2f7f288353
8028041: Serialized Form description of j.l.String is not consistent with the
implementation
Summary: Replaced incorrect description with reference to the
Thank you, John.
Since I'm not a Committer in JDK8, I need a sponsor to push this fix.
Any volunteers? :-) Will provide the changeset at first demand.
Best regards,
Vladimir Ivanov
On 11/9/13 3:26 AM, John Rose wrote:
Reviewed. Thanks for the fix. The test case will also be a useful quick
I'll push it for you. — John
On Nov 8, 2013, at 4:08 PM, Vladimir Ivanov
wrote:
> Thank you, John.
>
> Since I'm not a Committer in JDK8, I need a sponsor to push this fix. Any
> volunteers? :-) Will provide the changeset at first demand.
>
> Best regards,
> Vladimir Ivanov
>
> On 11/9/13
Changeset: fea486d30d41
Author:cl
Date: 2013-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/fea486d30d41
Added tag jdk8-b114 for changeset 850d2602ae98
! .hgtags
Changeset: 6b4d6205366c
Author:lana
Date: 2013-10-31 16:46 -0700
URL: http://hg
Changeset: d425685e0b74
Author:cl
Date: 2013-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/d425685e0b74
Added tag jdk8-b114 for changeset 0bbccf77c23e
! .hgtags
Changeset: 8d07115924b7
Author:lana
Date: 2013-10-31 16:30 -0700
URL: http://hg.ope
Changeset: d3b6da1b3e25
Author:cl
Date: 2013-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxp/rev/d3b6da1b3e25
Added tag jdk8-b114 for changeset 1b1e12117fe2
! .hgtags
Changeset: f610fd46463e
Author:lana
Date: 2013-10-31 16:31 -0700
URL: http://hg.open
Changeset: e126d8eca69b
Author:cl
Date: 2013-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jaxws/rev/e126d8eca69b
Added tag jdk8-b114 for changeset 9ad289610fc6
! .hgtags
Changeset: 587560c222a2
Author:cl
Date: 2013-11-07 08:16 -0800
URL: http://hg.openj
Changeset: b65d48f6938a
Author:cl
Date: 2013-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/rev/b65d48f6938a
Added tag jdk8-b114 for changeset 4f2011496393
! .hgtags
Changeset: 763ada2a1d8c
Author:lana
Date: 2013-10-31 16:24 -0700
URL: http://hg.openjdk.j
Changeset: f109bb255b80
Author:cl
Date: 2013-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/f109bb255b80
Added tag jdk8-b114 for changeset 79f7b79bf97b
! .hgtags
Changeset: f0d3ac2474ee
Author:lana
Date: 2013-10-31 16:47 -0700
URL: http://hg.o
Changeset: ddc3758f68db
Author:cl
Date: 2013-10-31 12:36 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/hotspot/rev/ddc3758f68db
Added tag jdk8-b114 for changeset 7fd913010dbb
! .hgtags
Changeset: 205834867346
Author:lana
Date: 2013-10-31 16:31 -0700
URL: http://hg.o
51 matches
Mail list logo
