Thank you, David
I fixed copyright and change back sleep.
println was intended to be left in. This test was failed with timeout,
printf could help us to detect the value of total_turns_taken and
expected_turns_taken.
Please review it again
On 01/07/2014 03:15 AM, srikalyan chandrashekar wrote:
Sure David will give that a try, we have so far attempted to
1. Print state data(as per the test creator peter.levart's inputs),
Hi Kalyan,
Have you been able to reproduce the OOME in that set-up? What was the
result?
Regards, Peter
On 15 Dec 2013, at 10:29, Robert Stupp sn...@gmx.de wrote:
Hi,
I digged through the object serialization code and found some lines that
could be optimized to reduce the number of calls to System.arraycopy() and
temporary object allocations especially during string (de)serialization.
In
On 7/01/2014 6:16 PM, Tristan Yan wrote:
Thank you, David
I fixed copyright and change back sleep.
println was intended to be left in. This test was failed with timeout,
printf could help us to detect the value of total_turns_taken and
expected_turns_taken.
Please review it again
On 6 Jan 2014, at 22:29, Dan Xu dan...@oracle.com wrote:
Hi All,
Please review the simple fix for JNI pending exceptions in
FileSystemPreferences.c. Thanks!
Bug: https://bugs.openjdk.java.net/browse/JDK-8028726
Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev/
Looks good to me
On 06/01/2014 22:29, Dan Xu wrote:
Hi All,
Please review the simple fix for JNI pending exceptions in
FileSystemPreferences.c. Thanks!
Bug: https://bugs.openjdk.java.net/browse/JDK-8028726
Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev/
The update to FIleSystemPreferences.c looks
Hi Mandy, Daniel,
Thanks for reviews. I just pushed this change to jdk9-dev/jdk ...
Regards, Peter
On 12/23/2013 05:50 AM, Mandy Chung wrote:
On 12/22/2013 5:23 AM, Peter Levart wrote:
Hi Mandy,
On 12/19/2013 10:38 PM, Mandy Chung wrote:
On 12/19/13 7:49 AM, Peter Levart wrote:
Hi Mandy,
On 06/01/2014 19:09, roger riggs wrote:
Please review this minor specification correction to the
java.time.Duration.toDays() and
toHours() methods. Only the javadoc is corrected, no code or tests
are affected.
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-duration-javadoc-8031103/
This
Hi David
You're totally right. Sorry I ask you review it again.
http://cr.openjdk.java.net/~tyan/JDK-7027502/webrev.02/
Thank you very much.
Tristan
On 01/07/2014 05:18 PM, David Holmes wrote:
On 7/01/2014 6:16 PM, Tristan Yan wrote:
Thank you, David
I fixed copyright and change back sleep.
On 7/01/2014 8:36 PM, Tristan Yan wrote:
Hi David
You're totally right. Sorry I ask you review it again.
http://cr.openjdk.java.net/~tyan/JDK-7027502/webrev.02/
Looks good now.
Thanks,
David
Thank you very much.
Tristan
On 01/07/2014 05:18 PM, David Holmes wrote:
On 7/01/2014 6:16 PM,
On 6 Jan 2014, at 21:19, Martin Buchholz marti...@google.com wrote:
Your change looks good, except there's one more trailing p to remove.
Thanks for the review. I found the trailing p and removed it.
-Chris.
Hi David/Martin,
If you agree with Kalyan's fix for this issue, could one of you please sponsor
the push.
Thanks,
Sandeep
On Dec 23, 2013, at 11:17 AM, srikalyan chandrashekar
srikalyan.chandrashe...@oracle.com wrote:
Hi David/Martin, could any one of you sponsor this change for me?
---
Robert, If you can create a micro benchmark that fools all of the core-libs-dev
or real world benchmark that actually shows performance improvements you might
be able to get this patch in to the source code.
Previous attempts are covered under
Changeset: 1b503dd54b95
Author:rriggs
Date: 2014-01-07 11:50 -0500
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/1b503dd54b95
8031103: java.time.Duration has wrong Javadoc Comments in toDays() and toHours()
Summary: Correct specification for Duration.toDays, toHours
Reviewed-by:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
diff -r 2647b91dbc2a
src/share/classes/java/lang/management/ManagementFactory.java
--- a/src/share/classes/java/lang/management/ManagementFactory.java Tue
Jan 07 09:58:16 2014 -0800
+++
+1
Paul.
On Jan 7, 2014, at 9:30 PM, Joe Darcy joe.da...@oracle.com wrote:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
diff -r 2647b91dbc2a
src/share/classes/java/lang/management/ManagementFactory.java
---
Peter, getting state info out(to console or otherwise) from within
Reference Handler's exceptions handlers have been unsuccessful. However
David's suggestion produced some useful trace with fast debug build and
could get some information , see the log here
On 07/01/2014 20:30, Joe Darcy wrote:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
Looks good.
-Alan.
+1
On Jan 7, 2014, at 3:30 PM, Joe Darcy wrote:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
diff -r 2647b91dbc2a
src/share/classes/java/lang/management/ManagementFactory.java
---
Hi David, TraceExceptions with fastdebug build produced some nice trace
http://cr.openjdk.java.net/%7Esrikchan/OOME_exception_trace.log . The
native method wait(long) is where the OOME if being thrown, the deepest
call is in
src/share/vm/gc_interface/collectedHeap.inline.hpp, line 157
Hello,
As part of the lint clean up of core libraries, I noticed a number of
warnings in the class sun.misc.Ref. Notable excerpts from the file:
/*
* Copyright (c) 1995, 2004, Oracle and/or its affiliates. All rights
reserved.
...
* @deprecated This class has been replaced by
*
On 1/7/2014 12:30 PM, Joe Darcy wrote:
Hello,
Please review another minor lint fix of a raw type issues in the core
libraries:
Looks good. cc'ing serviceability-dev as java.lang.management is owned
by the serviceability team.
Mandy
Hello,
Please review the fix below to address
JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}
by a quick-and-dirty generification and deprecation of some very old classes
http://cr.openjdk.java.net/~darcy/8031369.0/
Corresponding patch below.
In the fullness of
Hi All,
Thanks for your good review. I have dropped the change in
FileSystemPreferences.java , and created the new webrev which only
changes FileSystemPreferences.c. Please help review it. Thanks!
Webrev: http://cr.openjdk.java.net/~dxu/8028726/webrev.01/
When changing
Hi Mike,
On 01/07/2014 05:23 PM, Mike Duigou wrote:
Can you add the javadoc @deprecated alternative deprecation notice as well?
Sure; for Cache I'll point to LinkedHashMap and I'll look into finding a
alternative to SoftCache.
Thanks for the review,
-Joe
Otherwise looks good.
Mike
On
On 1/7/14 2:26 PM, Joe Darcy wrote:
public abstract class Ref {
So the type has been deprecated for at least 10 years. Rather than fixing the
warning in the class, I think the best course of action is to remove the file in
JDK 9. A build of OpenJDK without this file builds fine; if a build of
looks good Joe
On Jan 7, 2014, at 6:58 PM, Joe Darcy wrote:
Hello,
Please review the fix below to address
JDK-8031369: Fix raw types warnings in sun.misc.{Cache, SoftCache}
by a quick-and-dirty generification and deprecation of some very old classes
On 8/01/2014 7:33 AM, srikalyan chandrashekar wrote:
Hi David, TraceExceptions with fastdebug build produced some nice trace
http://cr.openjdk.java.net/%7Esrikchan/OOME_exception_trace.log . The
native method wait(long) is where the OOME if being thrown, the deepest
call is in
On 8/01/2014 4:19 PM, David Holmes wrote:
On 8/01/2014 7:33 AM, srikalyan chandrashekar wrote:
Hi David, TraceExceptions with fastdebug build produced some nice trace
http://cr.openjdk.java.net/%7Esrikchan/OOME_exception_trace.log . The
native method wait(long) is where the OOME if being
29 matches
Mail list logo
