Re: RFR (JAXP): 8035469 : Xerces Update: EncodingMap does not recognise Java-style encodings Cp1141-Cp1149

2014-03-01 Thread Alan Bateman
On 28/02/2014 22:11, David Li wrote: Hi, This is an update from Xerces for a fixed encoding map entry in file EncodingMap.java. For details, please refer to: https://bugs.openjdk.java.net/browse/JDK-8035469 Webrevs: http://cr.openjdk.java.net/~joehw/jdk9/8035469/webrev/ (I don't have a open

Re: Signature of MethodHandleInfo.reflectAs is not specific enough

2014-03-01 Thread Ali Ebrahimi
Hi, On Sat, Mar 1, 2014 at 12:16 AM, John Rose wrote: > On Feb 25, 2014, at 3:13 AM, Ali Ebrahimi > wrote: > > I know, this is too late, but I want to share my suggestion: > > public T reflectAs(Class super T> expected, MethodHandles.Lookup lookup) > > > Isn't this the same as > > public T r

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-01 Thread Yasumasa Suenaga
Hi David, > 1. Generating debug symbols in the binaries (via gcc -g or whatever) > 2. Generating debuginfo files (zipped or not) (FDS) > 3. Stripping debug symbols from the binaries (strip-policy) > > It may be that we don't have clean separation between them, and if so > that should be fixed, bu

Re: RFR (JAXP): 8035469 : Xerces Update: EncodingMap does not recognise Java-style encodings Cp1141-Cp1149

2014-03-01 Thread David Li
Joe probably knows more about this, but we did some preliminary investigation summarized below. One test that was considered was creating an XML file encoded in one of the formats and then seeing if the parser would process the file after our updates were added. This looked like it requires g

Re: JDK-8036003: Add variable not to separate debug information.

2014-03-01 Thread Mike Duigou
On Mar 1 2014, at 06:07 , Yasumasa Suenaga wrote: > Hi David, > >> 1. Generating debug symbols in the binaries (via gcc -g or whatever) >> 2. Generating debuginfo files (zipped or not) (FDS) >> 3. Stripping debug symbols from the binaries (strip-policy) >> >> It may be that we don't have clean

Re: Unsafe: efficiently comparing two byte arrays

2014-03-01 Thread Ulf Zibis
Am 28.02.2014 23:29, schrieb Martin Buchholz: Are word-size reads in ByteBuffer actually intrinsified? I could find no evidence for that. Perhaps this is an important missing optimization for hotspot to make? I see DirectByteBuffer, but not garden-variety ByteBuffer, using Unsafe. share/classe

RFR [7011804] SequenceInputStream with lots of empty substreams can cause StackOverflowError

2014-03-01 Thread Ivan Gerasimov
Hello! SequenceInputStream#read functions are implemented recursively. This may cause stack overflow in some extreme cases with lots of empty substreams. Would you please help review the fix? BUGURL: https://bugs.openjdk.java.net/browse/7011804 WEBREV: http://cr.openjdk.java.net/~igerasim/701