RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

Hi there, please review folowing simple fix - Bug: https://bugs.openjdk.java.net/browse/JDK-8038307 Fix: http://cr.openjdk.java.net/~mkos/8038307/jaxws.01/ Test: http://cr.openjdk.java.net/~mkos/8038307/jdk.01/ Issue related to EBCDIC encoding/WsImport tool. Thanks Miran

Re: RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

Looks ok to me Miran. You can use String.getBytes(StandardCharsets.UTF_8) if you don't want to handle UnsupportedEncodingException. I can sponsor this for you, if you need a sponsor. -Chris. [1] http://docs.oracle.com/javase/8/docs/api/java/nio/charset/StandardCharsets.html#UTF_8 On 31/03

Re: RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

Thanks Chris, the code adjusted: http://cr.openjdk.java.net/~mkos/8038307/jaxws.02/ Glad, if you can sponsor it for me. Regards Miran On 31/03/14 15:34, Chris Hegarty wrote: Looks ok to me Miran. You can use String.getBytes(StandardCharsets.UTF_8) if you don't want to handle UnsupportedEncod

Re: RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

On 31/03/14 15:05, Miroslav Kos wrote: Thanks Chris, the code adjusted: http://cr.openjdk.java.net/~mkos/8038307/jaxws.02/ Approved. Glad, if you can sponsor it for me. I'll push this later today. -Chris. Regards Miran On 31/03/14 15:34, Chris Hegarty wrote: Looks ok to me Miran. You

Re: RFR (JAXP): 8035437: Xerces Update: xml/serialize/DOMSerializerImpl

Lance, thank you for the review. Aleksej On 03/28/2014 03:33 PM, Lance @ Oracle wrote: With the change to stringbuilder I am ok with it Best Lance Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java En

Re: RFR: 8038307: JAX-WS conformance tests fail when running JCK-devtools-8 suite against RI in EBCDIC emulation mode

Miran, If you agree, I would like to move the test ( before pushing ) to jdk/test/javax/xml/ws (/ebcdic). This is where other jaxws tests live, and will be picked up in the usual developer cycle by the jdk_other test group. -Chris. On 31 Mar 2014, at 15:33, Chris Hegarty wrote: > On 31/03/14

Re: Implicit 'this' return for void methods

Sorry for late answer, After some thought I came into conclusion, that both solutions are similar. For me void functionality it to great to be in 100% replaced, other reasons are not as important. So if we consider that void would be replaced with 'this' or keep as void, in additional some type wo

Re: Implicit 'this' return for void methods

What about opting in? By that, I mean that these void methods must have a specific TYPE_USE annotation on them at compile time to allow chaining. This idea would require a JLS update to allow type annotations on void return values -- perhaps exclusive to this annotation. On Mon, Mar 31, 2014 at

Re: Implicit 'this' return for void methods

2014-03-31 22:44 GMT+02:00 Paul Benedict : > What about opting in? By that, I mean that these void methods must have a > specific TYPE_USE annotation on them at compile time to allow chaining. > > This idea would require a JLS update to allow type annotations on void > return values -- perhaps excl