RFR: 8042266: [launcher] create test groups for launcher regression tests

2014-05-02 Thread Kumar Srinivasan
Hi, Simple changes to add jdk_launcher to the jdk's Test.groups, this allows anyone working on the launcher to run a set of regression tests which historically have helped shake out launcher regressions. http://cr.openjdk.java.net/~ksrini/8042266/webrev.00/ Usage: jtreg .. /blah/de/blah/j

Re: RFR: 8042266: [launcher] create test groups for launcher regression tests

2014-05-02 Thread Alan Bateman
On 02/05/2014 14:17, Kumar Srinivasan wrote: Hi, Simple changes to add jdk_launcher to the jdk's Test.groups, this allows anyone working on the launcher to run a set of regression tests which historically have helped shake out launcher regressions. http://cr.openjdk.java.net/~ksrini/8042266/we

Re: RFR: 8042266: [launcher] create test groups for launcher regression tests

2014-05-02 Thread Kumar Srinivasan
Point taken, I just added jdk_launcher for now. http://cr.openjdk.java.net/~ksrini/8042266/webrev.01/ Thanks On 5/2/2014 6:30 AM, Alan Bateman wrote: On 02/05/2014 14:17, Kumar Srinivasan wrote: Hi, Simple changes to add jdk_launcher to the jdk's Test.groups, this allows anyone working on t

Re: RFR: 8042266: [launcher] create test groups for launcher regression tests

2014-05-02 Thread Alan Bateman
On 02/05/2014 16:40, Kumar Srinivasan wrote: Point taken, I just added jdk_launcher for now. http://cr.openjdk.java.net/~ksrini/8042266/webrev.01/ That seems okay now although it means that :jdk_launcher will run the tests for a bunch of tools that someone working on the launcher might not be i

Re: Covariant overrides on the Buffer Hierachy

2014-05-02 Thread Ulf Zibis
Am 01.05.2014 02:20, schrieb Joe Darcy: Hello, I'm reminded of Professor Knuth's observation that "Premature optimization is the root of all evil." If from an API perspective the new code is preferable, I would say that should take precedence over an at most marginal performance degradation.

Re: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-05-02 Thread David DeHaven
That's the first time the pentium bug ever worked in my favor... ;) The changes look good to me. approved (with a lower case 'a', since I'm not a Reviewer with an upper case 'R'). -DrD- > 1) Redundant return removed. > > 2) Kumar and I talked: Ever since the pentium bug, 1 in 80 trillion seem

Re: Covariant overrides on the Buffer Hierachy

2014-05-02 Thread Joe Darcy
On 5/2/2014 9:10 AM, Ulf Zibis wrote: Am 01.05.2014 02:20, schrieb Joe Darcy: Hello, I'm reminded of Professor Knuth's observation that "Premature optimization is the root of all evil." If from an API perspective the new code is preferable, I would say that should take precedence over an a

Re: JDK 9 RFC on 8032016: Optimizations of Math.next{After, Up}({float, double})

2014-05-02 Thread Joe Darcy
Hi Brian, Looks fine; cheers, -Joe On 04/29/2014 12:06 PM, Brian Burkhalter wrote: Hello, Issue: https://bugs.openjdk.java.net/browse/JDK-8032016 Patch: http://cr.openjdk.java.net/~bpb/8032016/webrev.00/ The performance improvements of this change are marginal but the logic seems reasonab

Re: 8035782 : sun/launcher/LauncherHelper$FXHelper loaded unnecessarily

2014-05-02 Thread Neil Toda
"T"hanks DrD. -neil On 5/2/2014 9:10 AM, David DeHaven wrote: That's the first time the pentium bug ever worked in my favor... ;) The changes look good to me. approved (with a lower case 'a', since I'm not a Reviewer with an upper case 'R'). -DrD- 1) Redundant return removed. 2) Kumar an

Re: 8020860: cluster Hashtable/Vector field updates for better transactional memory behaviour

2014-05-02 Thread Mike Duigou
Thanks Martin and Martin; I have corrected this along with some additional documentation updates: http://cr.openjdk.java.net/~mduigou/JDK-8020860/3/webrev/ Mike On Apr 16 2014, at 10:47 , Martin Buchholz wrote: > Here you access elementCount outside the synchronized block, which is a data >

Re: JDK 9 RFR of 8026236: Add PrimeTest for BigInteger [TEST-ONLY]

2014-05-02 Thread Brian Burkhalter
Prod! On Apr 28, 2014, at 4:02 PM, Brian Burkhalter wrote: > Here is an updated patch > > http://cr.openjdk.java.net/~bpb/8026236/webrev.02/ > > which has been revised to obviate the need for a file source of prime numbers. > > Thanks, > > Brian > > On Apr 24, 2014, at 5:12 PM, Brian Burkh

FilterOutputStream.close() throws exception from flush()

2014-05-02 Thread Bernd Eckenfels
Hello, back in 2011 there was a discussion about the new changed behavior of FilterOutputStream (and BufferedOutputStream) in regards to not anymore swalloging IOExceptions from flush() on this list (thats where I got the subject from). This was generally a very good improvement (and I am glad th