On 2014-05-15, Paul Sandoz wrote:
>
> The non test code looks good to me:
>
> Not totally sure about the test approach:
>
> 48 @Test(dataProvider = "data")
> 49 public void testClass(Class c, String method) throws Exception {
> 50 if (c.getTypeParameters().length == 0)
>
On May 16, 2014, at 10:53 AM, Joel Borggren-Franck
wrote:
> On 2014-05-15, Paul Sandoz wrote:
>>
>> The non test code looks good to me:
>>
>> Not totally sure about the test approach:
>>
>> 48 @Test(dataProvider = "data")
>> 49 public void testClass(Class c, String method) throws E
On May 14, 2014, at 11:05 AM, Alan Bateman wrote:
>
>> :
>>
>> This code is under src/share/classes, so it's not clear to me what classes i
>> can modify and push in the jdk9-dev/jdk repo or not. It's confusing! Is
>> there a list online somewhere?
>>
>> Out of all the classes here:
>>
>>
Thanks for the review Paul. Fix pushed
cheers
/Joel
On 2014-05-16, Paul Sandoz wrote:
>
> On May 16, 2014, at 10:53 AM, Joel Borggren-Franck
> wrote:
>
> > On 2014-05-15, Paul Sandoz wrote:
> >>
> >> The non test code looks good to me:
> >>
> >> Not totally sure about the test approach:
> >
On 05/16/2014 01:56 PM, Tobias Hartmann wrote:
Hi,
thanks to everyone for the feedback.
Is it sufficient then to use synchronized (lambdaForms) { ... } in
setCachedLambdaForm(..) and a normal read in cachedLambdaForm(..)?
Thanks,
Tobias
no, it's not,
The memory model doesn't guarantee tha
On May 16, 2014, at 5:05 PM, Remi Forax wrote:
>
> On 05/16/2014 01:56 PM, Tobias Hartmann wrote:
>> Hi,
>>
>> thanks to everyone for the feedback.
>>
>> Is it sufficient then to use synchronized (lambdaForms) { ... } in
>> setCachedLambdaForm(..) and a normal read in cachedLambdaForm(..)?
>
On 05/16/2014 05:22 PM, Paul Sandoz wrote:
On May 16, 2014, at 5:05 PM, Remi Forax wrote:
On 05/16/2014 01:56 PM, Tobias Hartmann wrote:
Hi,
thanks to everyone for the feedback.
Is it sufficient then to use synchronized (lambdaForms) { ... } in
setCachedLambdaForm(..) and a normal read in
Hi folks,
A simple fix to eliminate a possible infinite loop when an Ldap
Connection cannot contact the server.
http://cr.openjdk.java.net/~robm/8042857/webrev.01/
-Rob
I changed the test directory structure slightly so the revised webrev is at
http://cr.openjdk.java.net/~lancea/8043278/webrev.01/
Best
Lance
On May 15, 2014, at 6:20 PM, Lance Andersen wrote:
> Hi all,
>
> Looking for a reviewer for initial pass at adding some tests for
> javax.sql.rowset.ser
Hi Lance,
Looks fine.
typo:
SerialArrayTests.java: 62 * Validate a SQLException is thrown*if* the
map is null
Roger
On 5/16/2014 12:10 PM, Lance Andersen wrote:
I changed the test directory structure slightly so the revised webrev is at
http://cr.openjdk.java.net/~lancea/8043278/web
Hi Roger,
Thank you. I corrected the typo before the push.
Best
Lance
On May 16, 2014, at 1:10 PM, roger riggs wrote:
> Hi Lance,
>
> Looks fine.
>
> typo:
>
> SerialArrayTests.java: 62 * Validate a SQLException is thrown*if* the
> map is null
>
> Roger
>
> On 5/16/2014 12:10 PM,
On 5/16/2014 5:13 AM, Paul Sandoz wrote:
On May 14, 2014, at 11:05 AM, Alan Bateman wrote:
:
This code is under src/share/classes, so it's not clear to me what classes i
can modify and push in the jdk9-dev/jdk repo or not. It's confusing! Is there a
list online somewhere?
Out of all the cla
12 matches
Mail list logo
