Hi Alan,
Thank you for the comments, here's the updated webrev,
http://cr.openjdk.java.net/~luchsh/JDK-8043495-2/
On Mon, May 26, 2014 at 6:09 PM, Alan Bateman alan.bate...@oracle.comwrote:
On 26/05/2014 10:04, Jonathan Lu wrote:
Hello,
May I have following patch reviewed ?
On 27/05/2014 07:31, Jonathan Lu wrote:
Hi Alan,
Thank you for the comments, here's the updated webrev,
http://cr.openjdk.java.net/~luchsh/JDK-8043495-2/
http://cr.openjdk.java.net/%7Eluchsh/JDK-8043495-2/
Thanks for the updates and for including the the ifdef __APPLE__ change.
With the
On Tue, May 27, 2014 at 8:49 AM, Alan Bateman alan.bate...@oracle.com wrote:
On 27/05/2014 07:31, Jonathan Lu wrote:
Hi Alan,
Thank you for the comments, here's the updated webrev,
http://cr.openjdk.java.net/~luchsh/JDK-8043495-2/
http://cr.openjdk.java.net/%7Eluchsh/JDK-8043495-2/
Thanks
On 27/05/2014 09:49, Volker Simonis wrote:
:
'send_file()' is declared in 'sys/socket.h' on AIX, so we need it.
Thanks, just checking.
:
Is there any test which exercises this code?
The tests in java/nio/channels/FileChannel are the tests to run, they
will give the transfer methods a good
Thanks, Alan and Volker! I will push this change.
Regards,
Jonathan
On Tue, May 27, 2014 at 5:00 PM, Alan Bateman alan.bate...@oracle.comwrote:
On 27/05/2014 09:49, Volker Simonis wrote:
:
'send_file()' is declared in 'sys/socket.h' on AIX, so we need it.
Thanks, just checking.
:
https://bugs.openjdk.java.net/browse/JDK-8035186
http://cr.openjdk.java.net/~vlivanov/8035186/webrev.00/
LogGeneratedClassesTest.testDumpDirNotWritable is not applicable when it
is run by super user on Linux/Solaris. The test checks that it's
forbidden to create files in read-only directory,
On 22/05/2014 20:47, roger riggs wrote:
Thanks for the feedback and recommendations; the webrev has been updated.
Webrev: http://cr.openjdk.java.net/~rriggs/webrev-getpid-8003488/
Alan, on the use of tasklist, I think a cleaner test can be written
when the
Java API to inspect other processes
Hi,
I am wondering if it may be more reliable to attempt creation of a new file in
the read only directory rather than checking for the root user name?
Paul.
On May 27, 2014, at 3:19 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
https://bugs.openjdk.java.net/browse/JDK-8035186
Paul,
What you suggest is much cleaner. Thanks!
Updated version:
http://cr.openjdk.java.net/~vlivanov/8035186/webrev.01/
Best regards,
Vladimir Ivanov
On 5/27/14 5:35 PM, Paul Sandoz wrote:
Hi,
I am wondering if it may be more reliable to attempt creation of a new file in the read
only
On May 27, 2014, at 3:53 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul,
What you suggest is much cleaner. Thanks!
Updated version:
http://cr.openjdk.java.net/~vlivanov/8035186/webrev.01/
Don't you need to trap the exception? e.g.:
try {
Path test =
Good catch!
One more iteration:
http://cr.openjdk.java.net/~vlivanov/8035186/webrev.02/
Best regards,
Vladimir Ivanov
On 5/27/14 7:07 PM, Paul Sandoz wrote:
On May 27, 2014, at 3:53 PM, Vladimir Ivanov vladimir.x.iva...@oracle.com
wrote:
Paul,
What you suggest is much cleaner. Thanks!
Can anyone help me as sponsor?
On May 25, 2014 2:08 AM, Otávio Gonçalves de Santana otavioj...@java.net
wrote:
Really Happy to hear that.
Done.
On Sat, May 24, 2014 at 5:10 PM, Andrej Golovnin
andrej.golov...@gmail.com wrote:
Hi Otávio,
it would be nice, if you would not modify the
Can anyone help me as sponsor?
On May 12, 2014 1:57 PM, Paul Sandoz paul.san...@oracle.com wrote:
On Apr 26, 2014, at 12:56 PM, Otávio Gonçalves de Santana
otavioj...@java.net wrote:
When a String has length just one, could be replaced by equivalent
character literals, gaining some
Hi Otávio,
I can sponsor these two (Boolean and single char strings) for you.
Because they cross over different repositories and require different reviews
it would be more convenient to process each of them in two batches
(client vs core)
Please can you break out the 'client' changes into a
Thanks Jeremy. I believe you have JDK 9 Author status so can sponsor your fix
if you wish.
On 27 May 2014, at 21:09, Jeremy Manson jeremyman...@google.com wrote:
Just like the title says - every time you generate a new private key, you
leak a little memory. Webrev here:
Thanks Sherman!
On 5/27/2014 1:46 PM, Xueming Shen wrote:
One more nit,
ln#2876-2879
Do we really need to create a new ReaderUTF8, if the encoding is
indeed is utf8?
which I would assume should be true for most use scenarios. Maybe the
following
would be better?
//
Hello,
Please review the following webrev which updates internal ASM to v5.0.3,
the individual bug fixes are
listed in the JBS issue for reference,
https://bugs.openjdk.java.net/browse/JDK-8044046#comment-13501358
All core regression tests have been run, additionally nashorn
regressions,
looks good.
-Sherman
On 5/27/14 3:36 PM, huizhe wang wrote:
Thanks Sherman!
On 5/27/2014 1:46 PM, Xueming Shen wrote:
One more nit,
ln#2876-2879
Do we really need to create a new ReaderUTF8, if the encoding is
indeed is utf8?
which I would assume should be true for most use scenarios.
Hi, Jeremy.
As an Author, you can create a changeset but you can't push to the repo until
you're a Committer. Additional details about the differences between Author
and Committer may be found here [1,2].
The diffs to create a changeset are (of course) in your webrev. Your Sponsor
can use
19 matches
Mail list logo
