Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread Joel Borggrén-Franck
Hi, We need you send in the patches via the mailing list. Please reply to your mail with the diffs attached directly (not zipped for example). I’ll might have time to look at this next week, but it surprises me you need to patch hotspot. Allocations before we have inflated shouldn’t be a proble

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread Andrej Golovnin
Hi Joel, > We need you send in the patches via the mailing list. Please reply to your > mail with the diffs attached directly (not zipped for example). OK, will do that. But I always thought a webrev is the preferred and the best way to submit a patch. > I’ll might have time to look at this nex

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread Andrej Golovnin
Hi all, as requested here are the patches as diffs. Best regards, Andrej Golovnin On 28.05.2014, at 23:44, Andrej Golovnin wrote: > Hi Joe, > > I have prepared a patch for the issue JDK-5043030. > The patch consists of two parts: one for jdk and one for hotspot. > You can find the webrevs h

Re: RFR: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail

2014-05-29 Thread Miroslav Kos
Hi Hajo, I agree with you, this issue means major loss of functionality. I already started processing backport to jdk8 and after that will continue with jdk7. Thanks Miran On 26/05/14 18:50, i...@kliemeck.de wrote: Hey Miroslav, is this correct that the issue will be fixed on jdk9 only (as

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread Joel Borggrén-Franck
Hello, On 29 maj 2014, at 10:23, Andrej Golovnin wrote: > Hi Joel, > >> We need you send in the patches via the mailing list. Please reply to your >> mail with the diffs attached directly (not zipped for example). > > OK, will do that. But I always thought a webrev is > the preferred and the

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread Andrej Golovnin
Hi Joel, >> When you have for example following method: >> >> public int method() { >> return 0; >> } >> >> And you invoke this method over the reflection API, >> then the first N invocations are done via the native code. > > Yes, this is before inflation. Inflation happens after 15 calls IIRC

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread David Holmes
Hi Andrej, The hotspot changes need to be reviewed by hotspot developers so I've cc'd the runtime team. On 29/05/2014 8:45 PM, Andrej Golovnin wrote: Hi Joel, When you have for example following method: public int method() { return 0; } And you invoke this method over the reflection API,

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread David Holmes
Correction ... On 29/05/2014 9:06 PM, David Holmes wrote: Hi Andrej, The hotspot changes need to be reviewed by hotspot developers so I've cc'd the runtime team. On 29/05/2014 8:45 PM, Andrej Golovnin wrote: Hi Joel, When you have for example following method: public int method() { return

Re: RFR: 8043129: JAF initialisation in SAAJ clashing with the one in javax.mail

2014-05-29 Thread Hans-Joachim Kliemeck
Hey Miroslav, thanks! Regards Hans-Joachim Quoting Miroslav Kos : Hi Hajo, I agree with you, this issue means major loss of functionality. I already started processing backport to jdk8 and after that will continue with jdk7. Thanks Miran On 26/05/14 18:50, Hans-Joachim Kliemeck wrote

Re: Thread hangs reading from process output streams, even though process has terminated. (possible JDK bug?)

2014-05-29 Thread Bruno Medeiros
Any update on this? Has it been placed in the JVM bug database and/or have people tried to replicated it? (again note, it only appears to happen on JVM 7) On Tue, May 6, 2014 at 9:20 PM, Bruno Medeiros wrote: > After much chopping, I have finally narrowed it down to a single source > file, and n

Re: RFR: 5043030 (reflect) unnecessary object creation in reflection

2014-05-29 Thread Andrej Golovnin
Hi David, >> >> The valueOf calls may also allocate a new object so you can't just >> delete the JvmtiExport::post_vm_object_alloc call. Unfortunately you >> can't tell whether a new object was allocated or not. It is only for the >> smaller primitive types that any kind of Object caching is mand

Re: Thread hangs reading from process output streams, even though process has terminated. (possible JDK bug?)

2014-05-29 Thread roger riggs
Hi Bruno, Create an issue: JDK-8044321 EOF does not occur reading input from spawned cmd.exe process I was able to reproduce it on java 7 but not java 8. The implementation of Process does not mix handling of one Process instance with anothe

Re: Thread hangs reading from process output streams, even though process has terminated. (possible JDK bug?)

2014-05-29 Thread Bruno Medeiros
On Thu, May 29, 2014 at 2:32 PM, roger riggs wrote: > Hi Bruno, > > Create an issue: > JDK-8044321 EOF does > not occur reading input from spawned cmd.exe process > > I was able to reproduce it on java 7 but not java 8. > > Cool, thanks. > The

Re: Thread hangs reading from process output streams, even though process has terminated. (possible JDK bug?)

2014-05-29 Thread roger riggs
Thanks, feel free to add any additional information to the issue. Roger On 5/29/2014 9:41 AM, Bruno Medeiros wrote: On Thu, May 29, 2014 at 2:32 PM, roger riggs > wrote: Hi Bruno, Create an issue: JDK-8044321

Re: Thread hangs reading from process output streams, even though process has terminated. (possible JDK bug?)

2014-05-29 Thread Alan Bateman
On 29/05/2014 14:32, roger riggs wrote: Hi Bruno, Create an issue: JDK-8044321 EOF does not occur reading input from spawned cmd.exe process I was able to reproduce it on java 7 but not java 8. Bruno - I just had a brief chat with Roger about