Hi,
I took the liberty to shuffle around the patch to the new structure
and add a few tests, particularly testing subtly different invalid
formats and better exercising the logic around Timestamp nanos (tested
using both old and new code):
http://cr.openjdk.java.net/~redestad/8055055/webre
On Sep 2, 2014, at 3:59 PM, Vladimir Ivanov
wrote:
> Webrev: http://cr.openjdk.java.net/~vlivanov/8057042/webrev.00
>
Generally looks good (re: Peter's observation of continue/break).
- LambdaFormEditor
61 private static final class Transform {
62 final long packedBytes;
6
Yasumasa,
The CR number is JDK-8057556
I'll care about it's integration.
-Dmitry
On 2014-09-02 18:52, Yasumasa Suenaga wrote:
> Hi all,
>
> I'm trying to use JDP on my Fedora20 machine.
> My machine has two NICs and only one NIC is up.
>
> I passed system properties as below, however JDP broa
Hi all,
Thank you so much, Dmitry!
I've created webrev for it.
http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.0/
Please review.
Thanks,
Yasumasa
(2014/09/04 21:26), Dmitry Samersoff wrote:
> Yasumasa,
>
> The CR number is JDK-8057556
>
> I'll care about it's integration.
>
> -Dm
Looks good for me!
On 2014-09-04 19:59, Yasumasa Suenaga wrote:
> Hi all,
>
> Thank you so much, Dmitry!
>
> I've created webrev for it.
> http://cr.openjdk.java.net/~ysuenaga/JDK-8057556/webrev.0/
>
> Please review.
>
>
> Thanks,
>
> Yasumasa
>
>
> (2014/09/04 21:26), Dmitry Samersoff wro
Hi Claes,
I am assuming the changes to the Time and Timestamp have not changed, you just
moved them to the new structure.
WRT the tests, I actually want to add more value testing. I am in the process
of updating Time and Timestamp tests to use a DataProvider. Once I finish
this, I will send
On 2014-09-04 21:20, Lance Andersen wrote:
Hi Claes,
I am assuming the changes to the Time and Timestamp have not changed,
you just moved them to the new structure.
Yes, unchanged otherwise.
WRT the tests, I actually want to add more value testing. I am in the
process of updating Time a
David Chase and I just noticed files like this in the JDK:
http://hg.openjdk.java.net/jdk9/jdk9/jdk/file/tip/test/java/util/stream/test/org/openjdk/tests/java/util/stream/
The package for the test code is "org.openjdk.tests.java.util.stream".
Although that's long, it is completely unambiguous
2014/9/4 12:55 -0700, john.r.r...@oracle.com:
> ...
>
> Generally, grammar of such paths appears to be:
> $REPO / test / $TEST_PACKAGE_PREFIX / $API_PACKAGE
> where TEST_PACKAGE_PREFIX is fixed as "org/openjdk/tests", and
> API_PACKAGE is "java/util/stream" or some such.
>
> Has this organizati
