Re: RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

On 12/09/2014 17:54, Daniel Fuchs wrote: : For this patch - I think that our options are limited to the alternative: 1. propagate the exception 2. catch and silentlty drop the exception What is the 'better' behavior (and I agree neither of the two are ideal) probably depends on what is the

Re: RFR 8057793 BigDecimal is no longer effectively immutable

Hi Brian, How are the performance characteristics after the patch? I see that a lot of effort went in to tuning last December under 8029501. By the way, as part of my investigations into this bug I noticed that BigIntegerTest::divideLarge no longer tests the Burnikel-Ziegler part of the divisio

Re: RFR 8057793 BigDecimal is no longer effectively immutable

Here is a patch to fix the test bug mentioned previously. The Burnikel-Ziegler division code is now exercised, and you'll be glad to know that the tests still pass! Robert --- BigIntegerTest.java 2014-09-15 15:55:47.632012000 +0200 +++ BigIntegerTestPatched.java 2014-09-15 16:07:53.363563000 +

[9] RFR (S): 8058291: Missing some checks during parameter validation

http://cr.openjdk.java.net/~vlivanov/8058291/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8058291 8057656 & 8050166 changes accidentally removed some checks during argument validation in MHs.dropArguments() and MHs.explicitCastArguments(). The fix is to restore them. Testing: jck (api/

Re: RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

Hi Jason, Logging on System.err is usually frowned upon - especially if there are alternatives. May I suggest the following? 1. do option #1, and only fail after all listeners have been notified as Alan indicated 'it might not be too bad'. As Paul suggested to me privately we could use

[9] RFR (S): 8058293: Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is broken

https://bugs.openjdk.java.net/browse/JDK-8058293 http://cr.openjdk.java.net/~vlivanov/8058293/webrev.00 Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is incorrect due to widening primitive conversions (int -> long) taking place. The fix is to explicitly use long where needed. Al

Missing clarity in TimerTask doc

Hi all, I'm missing clarity, if a j.u.TimerTask object can be scheduled more than once. Especially, can it be scheduled again with Timer.schedule(...) after it has been cancelled, or has a new TimerTask object to be instantiated? What happens if a TimerTask is scheduled again before the first sc

Re: RFR 8057793 BigDecimal is no longer effectively immutable

That was my screw-up. Thanks for fixing it. Tim On 09.09.2014 10:30, Robert Gibson wrote: > > > Hi there, > > I came across a case in BigDecimal division where the dividend ends up > getting mutated, which is rather strange for a seemingly immutable class! > (It's a subset of the cases where t

Re: RFR 8057793 BigDecimal is no longer effectively immutable

And none of us who reviewed it nor any of the tests caught it either. Thanks to both (Tim & Robert) for the original and current patches. Brian On Sep 15, 2014, at 11:53 AM, Tim Buktu wrote: > That was my screw-up. Thanks for fixing it.

Re: [9] RFR (S): 8058293: Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is broken

On Sep 15, 2014, at 9:48 AM, Vladimir Ivanov wrote: > https://bugs.openjdk.java.net/browse/JDK-8058293 > http://cr.openjdk.java.net/~vlivanov/8058293/webrev.00 > > Bit set computation in MHs.findFirstDupOrDrop/findFirstDrop is incorrect due > to widening primitive conversions (int -> long) tak

RFR: 8058429: JCK test api/java_sql/Timestamp/descriptions.html start failing after 8058230

Hi, please review this simple fix which addresses a JCK test failure webrev: http://cr.openjdk.java.net/~redestad/8058429/webrev.03 bug: https://bugs.openjdk.java.net/browse/JDK-8058429 /Claes

Re: RFR: 8058429: JCK test api/java_sql/Timestamp/descriptions.html start failing after 8058230

Hi Claes, The fix is fine for now. As we discussed and I discussed with the JCK team, the test that is failing is suspect and goes beyond the JDBC spec requirements. However until it is fixed, we will include this change. I will push this later for you. Best, lance On Sep 15, 2014, at 3:51 P

Re: [9] RFR (S): 8058291: Missing some checks during parameter validation

Reviewed. Nice tuning of the asserts. — John On Sep 15, 2014, at 9:03 AM, Vladimir Ivanov wrote: > http://cr.openjdk.java.net/~vlivanov/8058291/webrev.00/ > https://bugs.openjdk.java.net/browse/JDK-8058291 > > 8057656 & 8050166 changes accidentally removed some checks during argument > vali

Re: RFR 8057793 BigDecimal is no longer effectively immutable

Hi Joe, This has been pushed http://hg.openjdk.java.net/jdk9/dev/jdk/rev/3b20d87c5905 with the indicated comment excised. Thanks, Brian On Sep 13, 2014, at 10:10 AM, Joe Darcy wrote: > Other than removing the > >// bug 8057793 > > comment on the new test method, this looks good to be p

Re: RFR 8057793 BigDecimal is no longer effectively immutable

Hi Robert, On Sep 15, 2014, at 2:09 AM, Robert Gibson wrote: > How are the performance characteristics after the patch? I have not tested that aspect as yet but clearly it should be evaluated. Given that JDK-8057793 causes a violation of the specification of BigDecimal I thought it was import

JDK 9 RFR of 8058505: BigIntegerTest does not exercise Burnikel-Ziegler division

Hello, This is a test-only change. Issue: https://bugs.openjdk.java.net/browse/JDK-8058505 Webrev: http://cr.openjdk.java.net/~bpb/8058505/webrev.00/ I verified that the updated version passes (as mentioned below) and in fact exercises the B-Z division branch of the library code. Thanks, Bri

Re: Missing clarity in TimerTask doc

http://docs.oracle.com/javase/8/docs/api/java/util/Timer.html#schedule-java.util.TimerTask-long- IllegalStateException - if task was already scheduled or cancelled, timer was cancelled, or timer thread terminated. On Mon, Sep 15, 2014 at 10:47 AM, Ulf Zibis wrote: > Hi all, > > I'm missing cla

RE: RFR: 8043306 - Provide a replacement for the API that allowed to listen for LogManager configuration changes

Hi Daniel, You covered my main concern regarding the notification so I'm on board with this patch. For any other package I agree with you on the frowning of System.err. However, the LogManager/Handler.reportError(ex2) seem to use it like it is the debug/failsafe option for the logging fram

Re: Missing clarity in TimerTask doc

Am 15.09.2014 um 22:39 schrieb Martin Buchholz: http://docs.oracle.com/javase/8/docs/api/java/util/Timer.html#schedule-java.util.TimerTask-long- IllegalStateException - if task was already scheduled or cancelled, timer was cancelled, or timer thread terminated. Oops, overseen, thanks! Maybe

RFR: 8058514: TEST_BUG: New tests introduced in 8058429 are TimeZone dependent

Hi, please review this simple fix which ensures java.sql.test.sql.TimestampsTests can be run successfully across the globe. Also use a custom timezone ("GMT+01") to make sure the test does not observe DST, which will keep the test running happily all year round. webrev: http://cr.openjdk.jav

Re: Missing clarity in TimerTask doc

On Mon, Sep 15, 2014 at 3:11 PM, Ulf Zibis wrote: > > Am 15.09.2014 um 22:39 schrieb Martin Buchholz: > >> http://docs.oracle.com/javase/8/docs/api/java/util/Timer. >> html#schedule-java.util.TimerTask-long- >> >> IllegalStateException - if task was already scheduled or cancelled, timer >> was ca

Re: RFR: 8058514: TEST_BUG: New tests introduced in 8058429 are TimeZone dependent

Hi Claes, I ran the revised test which passes on my box with Eastern TZ. I know you also ran the jck tests for java.sql and they passed as well. Thank you for doing this extra clean up. I will push the change Best, lance On Sep 15, 2014, at 6:41 PM, Claes Redestad wrote: > Hi, > > please re

Re: RFR [9]: 8050142: Optimize java.util.Formatter

Hi, Claes I've looked over the latest changes, and they look good to me. I can sponsor this. Note that we need approval from a Reviewer. One small nitpick from me: 2914: If the text is left-justified, then aren't we padding on the right? I would call this "padRight". Thanks, -Brent On 7

Re: JDK 9 RFR of 8058505: BigIntegerTest does not exercise Burnikel-Ziegler division

Hi Brian, The test change looks fine; thanks, -Joe On 9/15/2014 1:30 PM, Brian Burkhalter wrote: Hello, This is a test-only change. Issue:https://bugs.openjdk.java.net/browse/JDK-8058505 Webrev:http://cr.openjdk.java.net/~bpb/8058505/webrev.00/

RFR: 8058520: jar xf does not work on zip files with leading garbage.

Hi Alan, Xueming, I'd like you to do a code review. https://bugs.openjdk.java.net/browse/JDK-8058520 http://cr.openjdk.java.net/~martin/webrevs/openjdk9/jar-leadingGarbage/