Re: RFR: 8062771: Core reflection should use final fields whenever possible

On Nov 4, 2014, at 6:53 PM, Martin Buchholz wrote: >> Is it possible to make EmptyClass be a static inner class of the test? IIUC >> if its enclosed within ThreadSafety it should still work with URLClassLoader. > > Done. Webrev regenerated. +1 Perhaps one reason why the test is not failing (o

Re: RFR: 8062773: Clarifications for Class specification

On Nov 5, 2014, at 6:26 AM, joe darcy wrote: > Hi Martin, > > This description in getGenericInterfaces > > 876 * If this object represents a class, the return value is an > 877 * array containing objects representing all interfaces > 878 * implemented by the class. The order of

Review request for XML JAXP unit test colocation

Hi, Joe and All Thanks for your previous reviews and comments. Per your comments: I added description for every test, got them running with and without security manager and fixed the known test issues. Could you help review the changes for JAXP unittest co-location again? After your review, I wil

Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

Hi Aleksey, On 2014-11-04 22:25, Aleksey Shipilev wrote: Hi Claes, On 04.11.2014 23:57, Claes Redestad wrote: please review this minor improvement to the initialization of MethodHandleImpl$Lazy. Running any code which initializes MethodHandlesImpl$Lazy will trigger throwing of java.lang.NoSuch

Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

On 11/05/2014 12:23 PM, Claes Redestad wrote: > On 2014-11-04 22:25, Aleksey Shipilev wrote: >> On 04.11.2014 23:57, Claes Redestad wrote: >> - Would we be better off asserting (mh == null) instead of breaking and >> asserting afterwards? > > assert(mh != null) does makes it more readable... >

Re: RFR: 8060132: Handlers configured on abstract nodes in logging.properties are not always properly closed

On 04/11/14 23:40, Mandy Chung wrote: On 11/4/14 8:48 AM, Daniel Fuchs wrote: Hi, Here is a revised patch that introduces a new .handlers.ensureCloseOnReset=true|false property. You have explored several different options and as you have found, none of them is ideal. I think having a propert

Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case when a collector is erroneously removed, but not when a new one is introduced. Can you extract verification logic into separate method and check there

Re: [9] Review Request: 8059753 Fix for java/security/Security/ClassLoaderDeadlock/Deadlock2.sh fails with exit code 1

Hi All, A gentle reminder . Please review below fix. Regards, Pooja On 10/7/2014 4:25 PM, pooja chopra wrote: Hello, Please review a fix for the issue: 8059753 [TEST_BUG] Test java/security/Security/ClassLoaderDeadlock/Deadlock2.sh fails with exit code 1 Test bug fix. https://bugs.openjdk.ja

Re: Review request for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type

Hi Eric, I think caching the real parameter type array on Executable is the wrong thing to do considering we can have a lot of instances of Executable but fairly few will be examined for parameters and the vast majority of those will never have this issue. Also, the tests are a bit minimal, I

Re: RFR: 8060132: Handlers configured on abstract nodes in logging.properties are not always properly closed

Hi Mandy, Stanimir, Here is the new webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8060132/webrev.03/index.html best regards, -- daniel On 05/11/14 12:47, Daniel Fuchs wrote: On 04/11/14 23:40, Mandy Chung wrote: On 11/4/14 8:48 AM, Daniel Fuchs wrote: Hi, Here is a revised patch that i

Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

Hi Vladimir, On 11/05/2014 01:47 PM, Vladimir Ivanov wrote: Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case when a collector is erroneously removed, but not when a new one is introduced. Can you ex

Re: RFR 8062180: MethodHandleImpl.makeArrays throws and swallows java.lang.NoSuchFieldError in normal flow

Looks good. Best regards, Vladimir Ivanov On 11/5/14, 8:22 PM, Claes Redestad wrote: Hi Vladimir, On 11/05/2014 01:47 PM, Vladimir Ivanov wrote: Claes, Thanks for spotting this inefficiency. New webrev: http://cr.openjdk.java.net/~redestad/8062180/webrev.01 The new code catches the case w

Re: RFR: 8061950: Class.getMethods() exhibits quadratic time complexity

On 11/01/2014 06:49 PM, Peter Levart wrote: On 10/30/2014 07:13 PM, Martin Buchholz wrote: Which is why I was expecting to have to write an adaptive data structure that switches from linear search to hash-based when some threshold is exceeded. ...or two data structures. Since I have already ar

Re: RFR: 8061950: Class.getMethods() exhibits quadratic time complexity

A very small issue: MethodTable.java: 697 while (i < hwm && next == null) next = methods[i++]; In my opinion the condition should be while (next == null && i < hwm) as next will be non-null on each invocation of next() and generally it's more likely to exit the loop. I supp

Re: RFR: 8060132: Handlers configured on abstract nodes in logging.properties are not always properly closed

945 } catch (Exception ex) { 946 System.err.println("Can't load log handler \"" + type + "\""); 947 System.err.println("" + ex); 948 ex.printStackTrace(); 949 } I'm not quite sure i

Re: Review request for XML JAXP unit test colocation

Hi Frank, It's great to see that you re-categorized the tests and consolidated them into their proper categories. The webrev still shows Unexpected Error when creating diff for binary files, e.g. Hello.wsdl, an issue with how Mercurial handles them (never had problem with subversion before).

Re: Review request for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type

Thanks, Joel. I've applied your fixes and re-upped the webrev. On 11/05/14 10:10, Joel Borggrén-Franck wrote: > Hi Eric, > > I think caching the real parameter type array on Executable is the wrong > thing to do considering we can have a lot of instances of Executable but > fairly few will be

Re: Review request for 8055063: Parameter#toString() fails w/ AIOOBE for ctr of inner class w/ generic type

A word on the tests: I don't think there's a stable way to check the types on getParameterizedType() and getAnnotatedType(). So I checked the type on getType() only. The problem is, you have to detect and cast from ParameterizedType and AnnotatedType respectively, but depending on the situation w

Re: RFR 8047962: XML test colocation: AuctionPortal test for bid.com

Thank you. Joe. Git plugin for mercurial works well for hg command but webrev script still doesn’t support the binary file. I did one small change to replace movies.xml with a Java string to suppress this error. Also I took your advice to move xml files into auction portal directory. Changed tes

Re: RFR 8047962: XML test colocation: AuctionPortal test for bid.com

Hi Tristan, It's good to see movie.xml is replaced with a literal string. Sorry if I wasn't clear on the directory structure. It would be nice if all files for AuctionPortal to be placed under AuctionPortal, that is: test/javax/xml/jaxp/functional/test/auctionportal/

Re: RFR 8047962: XML test colocation: AuctionPortal test for bid.com

Thanks again This makes more sense to me. Now they look clearer. http://cr.openjdk.java.net/~tyan/JDK-8047962/webrev.03/ Thank you for sponsoring this. Tristan > On Nov 5, 2014, at 3:23 PM, huizhe wang wrote: > > Hi Tristan, > > It's

Re: Review request for XML JAXP unit test colocation

Hi Frank What I meant is uploading webrev for you. An open JDK review means you send your code to open JDK alias. Anyone is open JDK alias is eligible to review your code. There are some people they are not working on Oracle. They have no access to Oracle network. According the open JDK process

RE: Review request for XML JAXP unit test colocation

Hi Joe Thanks for your comments! I have corrected the typo error in ProblemList.txt. The Unexpected Error happened on the file beginning with BOM, the corresponding tests are to test BOM utf file. Because there is no mistake in the code, so I would not modify them for webrev tool, after all the r

Re: RFR: 8061950: Class.getMethods() exhibits quadratic time complexity

Hi Stanimir, On 11/05/2014 07:27 PM, Stanimir Simeonoff wrote: A very small issue: MethodTable.java: 697 while (i < hwm && next == null) next = methods[i++]; In my opinion the condition should be while (next == null && i < hwm) as next will be non-null on each invocatio