Re: [concurrency-interest] RFR: 8065804: JEP 171: Clarifications/corrections for fence intrinsics

On 11/12/14 00:53, David Holmes wrote: > On 11/12/2014 7:02 AM, Andrew Haley wrote: >> On 12/05/2014 09:49 PM, Martin Buchholz wrote: >>> The actual implementations of storestore (see below) seem to >>> universally give you the stronger ::release barrier, and it seems >>> likely that hotspot engine

Re: [9] Review request : JDK-8066798: [TEST] Make java/lang/invoke/LFCaching tests use lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java to define their number of iterations

Vladimir, Paul, Please, look at this fix http://cr.openjdk.java.net/~kshefov/8066798/webrev.04 Thanks -Konstantin On 10.12.2014 18:05, Igor Ignatyev wrote: cool. reviewed. -- Igor On 12/10/2014 06:01 PM, Konstantin Shefov wrote: Igor, I changed to printf and indent: http://cr.openjdk.java

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

CC'ed core-libs-dev@openjdk.java.net On 10.12.2014 18:21, Konstantin Shefov wrote: Hello, Please, review the bug fix: https://bugs.openjdk.java.net/browse/JDK-6933879 Webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev.00 It is suggested to add some more symbols allowed for scope id i

Re: [9] Review request : JDK-8066798: [TEST] Make java/lang/invoke/LFCaching tests use lib/testlibrary/jdk/testlibrary/TimeLimitedRunner.java to define their number of iterations

Looks good. Best regards, Vladimir Ivanov On 12/11/14, 2:07 PM, Konstantin Shefov wrote: Vladimir, Paul, Please, look at this fix http://cr.openjdk.java.net/~kshefov/8066798/webrev.04 Thanks -Konstantin On 10.12.2014 18:05, Igor Ignatyev wrote: cool. reviewed. -- Igor On 12/10/2014 06:01 P

RFR: JDK-8065673: Makefile enable JAXP tests running

Hi everyone Could you please to review this small makefile change for JAXP tests http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.00/ http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.00/

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

On 11/12/2014 14:38, Tristan Yan wrote: Hi everyone Could you please to review this small makefile change for JAXP tests http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.00/ http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.00

Re: [9] Review request : JDK-6933879: URISyntaxException when non-alphanumeric characters are present in scope_id

On 11 Dec 2014, at 11:09, Konstantin Shefov wrote: > CC'ed core-libs-dev@openjdk.java.net > > On 10.12.2014 18:21, Konstantin Shefov wrote: >> Hello, >> >> Please, review the bug fix: https://bugs.openjdk.java.net/browse/JDK-6933879 >> Webrev: http://cr.openjdk.java.net/~kshefov/6933879/webrev

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

On 12/11/2014 7:07 AM, Alan Bateman wrote: On 11/12/2014 14:38, Tristan Yan wrote: Hi everyone Could you please to review this small makefile change for JAXP tests http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.00/ http://cr.open

JDK 9 RFR of JDK-8067289 (XS): Fix deprecation warnings in java.base module - CRC32C

Hi, Here is a small fix that avoids calling deprecated sun.misc.Unsafe methods, which allows the @SuppressWarnings to be removed. Bug: https://bugs.openjdk.java.net/browse/JDK-8067289 Webrev: http://cr.openjdk.java.net/~sfriberg/JDK-8067289/webrev.00 Regards, Staffan

Re: JDK 9 RFR of JDK-8067289 (XS): Fix deprecation warnings in java.base module - CRC32C

Hi Staffan, I haven't examined the code for possible integer overflow cases, but it would be fundamentally safer if the values were promoted to long *before* the arithmetic rather than after. In other words, instead of (long)(Unsafe.ARRAY_BYTE_BASE_OFFSET + off) // Overflow theoretically

Re: JDK 9 RFR of JDK-8067289 (XS): Fix deprecation warnings in java.base module - CRC32C

At the same time, if you have an overflow here, it means that you are able to create an int array (a int[]) with a size which is greater than 2G (minus the offset). Rémi On 12/11/2014 08:23 PM, joe darcy wrote: Hi Staffan, I haven't examined the code for possible integer overflow cases, but

Re: RFR: JDK-8065673: Makefile enable JAXP tests running

Thanks Alan and Joe I added jaxp testset, now jaxp_tests is under jaxp testset only. Also I have added jaxp testset to pit. http://cr.openjdk.java.net/~tyan/JDK-8065673/webrev.01/ http://cr.openjdk.java.net/~tyan/JDK-8065673/jaxp/webrev.0

Re: JDK 9 RFR of JDK-8067289 (XS): Fix deprecation warnings in java.base module - CRC32C

Hi Joe, Good point. Updated webrev, http://cr.openjdk.java.net/~sfriberg/JDK-8067289/webrev.01 Regards, Staffan On 12/11/2014 11:23 AM, joe darcy wrote: Hi Staffan, I haven't examined the code for possible integer overflow cases, but it would be fundamentally safer if the values were promo

RFR(xs): 8066633: Fix deprecation warnings in java.rmi module

Hi all, Please review this tiny fix to remove the source of a deprecation warning and to remove the now-unnecessary suppression of deprecation warnings from its context. There are other deprecated usages mentioned in this bug report but for a variety of reasons they either cannot be removed o

Re: RFR(xs): 8066633: Fix deprecation warnings in java.rmi module

Hi Stuart, Looks good! Thanks for fixing this, -Joe On 12/11/2014 5:56 PM, Stuart Marks wrote: Hi all, Please review this tiny fix to remove the source of a deprecation warning and to remove the now-unnecessary suppression of deprecation warnings from its context. There are other depreca

Re: RFR(xs): 8066633: Fix deprecation warnings in java.rmi module

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Dec 11, 2014, at 8:56 PM, Stuart Marks wrote: > > Hi all, > > Please review this tiny fix to remove the sourc

Re: JDK 9 RFR of JDK-8067289 (XS): Fix deprecation warnings in java.base module - CRC32C

Hi Staffan, The new version looks good to me; thanks, -Joe On 12/11/2014 5:25 PM, Staffan Friberg wrote: Hi Joe, Good point. Updated webrev, http://cr.openjdk.java.net/~sfriberg/JDK-8067289/webrev.01 Regards, Staffan On 12/11/2014 11:23 AM, joe darcy wrote: Hi Staffan, I haven't examine

RFR 8066085: Need a sanity test for rmic -iiop

Hi all, please review the fix to add a sanity checking for rmic -iiop compiling. Bug: https://bugs.openjdk.java.net/browse/JDK-8066085 Webrev: http://cr.openjdk.java.net/~xiaofeya/8066085/webrev.00/ Thanks, Felix

RFR 8061442: Update jdk/tools tests to remove check for the "jre" directory

Hi all, please review the fix for jdk/test/tools. It cleans up checking for 'jre' directory, which has been removed during Jigsaw M2. Bug: https://bugs.openjdk.java.net/browse/JDK-8061442 Webrev: http://cr.openjdk.java.net/~xiaofeya/8061442/webrev.00/ Thanks, Felix