Re: FilePermission Canonical path optimization

On 12/17/2014 07:36 PM, Sean Mullan wrote: On 12/05/2014 08:00 AM, Peter Levart wrote: The question is what to do with the remaining data race that was present before. The 'mask' field. The best would be to make it final, but deserialization needs to set it. I don't see the pre-existing race c

RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

Hi, I propose a patch for the following issue: https://bugs.openjdk.java.net/browse/JDK-8047769 Here's the webrev: http://cr.openjdk.java.net/~plevart/jdk9-dev/FileInputStreamPool.8047769/webrev.01/ The patch uses a package-private FileInputStreamPool class that caches open FileInputStre

RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

Hi everyone, Could you please review my change for JDK-8067870? http://cr.openjdk.java.net/~prappo/8067870/webrev.00/ --- I suppose it's the first time this method gets executed. Ever :) There's no need for a test to be

Re: RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

Hi Pavel, The change looks ok. But since you're written the test and used it to demonstrate it works, it is useful and with the application of the normal test coding conventions should be added as the regression test for the issue. Thanks, Roger On 12/18/2014 8:32 AM, Pavel Rappo wrote: Hi

Re: RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

On 18/12/2014 13:32, Pavel Rappo wrote: Hi everyone, Could you please review my change for JDK-8067870? http://cr.openjdk.java.net/~prappo/8067870/webrev.00/ --- I suppose it's the first time this method gets executed.

Re: RFR JDK-8067870: Fix java.io.ObjectInputStream.PeekInputStream#skip

Updated webrev: http://cr.openjdk.java.net/~prappo/8067870/webrev.01/ Will push as soon as I see test results. P.S. The thing was lurking there since 28-NOV-2000, ver. 1.106 -Pavel > On 18 Dec 2014, at 14:25, Alan Bateman wrote: > > On 18/12/2014 13:32, Pavel Rappo wrote: >> Hi everyone, >> >

RFR (JAXP): 8054196: XPath: support any type

Hi, This is to add support for any type and improvement with new features reflected in the new evaluateExpression methods, XPathEvaluationResult and XPathNodes. https://bugs.openjdk.java.net/browse/JDK-8054196 http://cr.openjdk.java.net/~joehw/jdk9/8054196/webrev/ Thanks, Joe

Re: RFR: JDK-8047769 SecureRandom should be more frugal with file descriptors

Peter, Thanks for looking into this. I'll in the middle of reviewing your change (and TLR/SplittableRandom reply), but have several appointments over the next few days. But did want to respond to: sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java: Make sure that when no sy

Re: RFR(S): 8067471: Use private static final char[0] for empty Strings

Claes, Thanks for cool suggestion: http://cr.openjdk.java.net/~lpriima/8067471/webrev.01/: public java.lang.String(); Signature: ()V flags: ACC_PUBLIC LineNumberTable: line 137: 0 line 138: 4 line 139: 13 Code: stack=2, locals=1, args_size=1 0:

Re: RFR(S): 8067471: Use private static final char[0] for empty Strings

Hi Rémi, Sure this examples will not be affected, but we have to concern about other applications which are probably using this constructor. Could you suggest such applications? On 17.12.2014 21:49, Remi Forax wrote: On 12/17/2014 11:22 AM, Lev Priima wrote: Hi, Please review space optimi