Re: JDK 9 RFR of 8067669: Documentation for methods in Number incomplete regarding too large values.

On Fri, Jan 16, 2015 at 02:55:28PM -0800, Brian Burkhalter wrote: > > On Jan 8, 2015, at 7:13 AM, Andreas Lundblad > wrote: > > > Although I was the one who brought it up, I think the whole > > Comparator discussion is slightly off topic. I still think that > > explicitly mentioning rounding

JDK 9 RFR of JDK-8069262: Doclint regression in java.nio.channels.Channels

Please review the fix for Doclint regression in java.nio.channels.Channels, removed the empty tag. bug: https://bugs.openjdk.java.net/browse/JDK-8069262 webrev: http://cr.openjdk.java.net/~amlu/8069262/webrev.00/ I also need a sponsor for this. Thanks, Amy

Re: JDK 9 RFR of JDK-8068948: Update java.base module to use new try-with-resources statement

On 01/16/2015 06:46 PM, Ivan Gerasimov wrote: Might it also make sense to allow anonymous variables in the try-with-resource statement? So that something like `try (() -> System.out.println("closed")) {}` would work... I don't think that is necessary. In JDK 7, we started out allowing a gen

RFR 8061448, Update sun/misc/JarIndex tests to cleanup the check for the "jre" directory

Hi all, please review the fix for 8061448. It cleans up dependency with "jre" directory and tools.jar, which have been removed by Jigsaw feature. Bug: https://bugs.openjdk.java.net/browse/JDK-8061448 Webrev: http://cr.openjdk.java.net/~xiaofeya/8061448/webrev.00/ I needs a sponsor f

RFR: 8062923: XSL: Run-time internal error in 'substring()'

Hi, Please, review the fix for the XSL substring function failures. Two issues were reported during usage of this function: 1. Runtime internal error with negative length: https://bugs.openjdk.java.net/browse/JDK-8062923 2. Wrong answer when -Inf length is used: https://bugs.openjdk.java.net/b

RFR: 8062518: AIOBE occurs when accessing to document function in extended function in JAXP

Please, review the fix for the failure observed while accessing external document during xsl transformation: https://bugs.openjdk.java.net/browse/JDK-8062518 The jaxp code limits the access to external documents, but there is a possibility to access such documents from the xsl code - new regress

Re: RFR: 8046817: JDK 8 schemagen tool does not generate xsd files for enum types

Hi, Returning back to this issue: The fix will be integrated soon to standalone JAXB project. Local build of standalone JAXB succeeded. No issues with jaxb tests were observed with applied fix. Can I ask reviewers to look at this issue now? Thank you and Best Regards, Aleksej On 10/15/2014 03

Re: [9] RFR (M): 8063137: Never-taken branches should be pruned when GWT LambdaForms are shared

Thanks, Vladimir! I would suggest to add more detailed comment (instead of simple "Stop profiling") to inline_profileBranch() intrinsic explaining what it is doing because it is not strictly "intrinsic" - it does not implement profileBranch() java code when counts is constant. Sure, will do.

RFR 8068432: Inconsistent exception handling in CompletableFuture.thenCompose

Hi, http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8068432-CompletableFuture-thenCompose-Exception/webrev/ This is a cherry-picked fix from the 166 repo with a JDK test added. Once approved i will request a back-port to 8u60. Paul.

Re: String.indexOf optimization

Martin, yes, we're talking about that method. Other than tightening that code some... if we find some algorithm that outperforms the naive implementation under certain conditions (let's say when the searched pattern is longer than 10 characters), would it be worth including it as a special case? (