John,
Generally speaking, we should select warnings carefully - not just turn
all of it on.
For instance, I don't see any value of "format is not a string literal"
warning for JDK code.
Please, see also below.
On 2015-02-22 06:20, John Rose wrote:
> On Feb 21, 2015, at 5:38 PM, Kumar Srinivasa
Hi Claes,
On 02/22/2015 03:11 AM, Claes Redestad wrote:
Hi Sherman,
On 2015-02-21 19:49, Xueming Shen wrote:
Hi Claes,
This change basically undo the "fix" for 4759491 [1], for better
performance ...
my intent was never to break current behavior, but that mistake can be
rectified
witho
Hi,
I noticed internal JDK class java.util.zip.ZipUtils uses deprecated
java.util.Date API for implementing two methods for converting DOS to
Java time and back. I thought I'd try translating them to use new
java.time API. Translation was straightforward, but I noticed that new
implementation
On 2/21/15 6:11 PM, Claes Redestad wrote:
Hi Sherman,
On 2015-02-21 19:49, Xueming Shen wrote:
Hi Claes,
This change basically undo the "fix" for 4759491 [1], for better
performance ...
my intent was never to break current behavior, but that mistake can be
rectified
without missing out
Hi Peter,
On 2015-02-22 21:21, Peter Levart wrote:
Hi,
I noticed internal JDK class java.util.zip.ZipUtils uses deprecated
java.util.Date API for implementing two methods for converting DOS to
Java time and back. I thought I'd try translating them to use new
java.time API. Translation was st
On 20/02/2015 7:57 PM, Lev Priima wrote:
Functional is pretty same, but:
- make it run with a single argument '67108864' by moving @summary tag
strait down to line after the @run tag
- '-Xmx385' ->'-Xms385' in run command. MaxHeapSize will adjust a
accordingly.
- spaces and code style.
Of
On 21/02/2015 4:27 AM, Dmitry Samersoff wrote:
Hi Everyone,
It's my $0.02 to the warning cleanup work. Please review:
http://cr.openjdk.java.net/~dsamersoff/JDK-8073584/webrev.01/
Notes:
I use an ugly trick: (void) (read() + 1) to get rid of ignored value
warning because since gcc 4.6 just (v
