RFR 8080486: JNI exception pending in jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c

2015-09-02 Thread Vyom Tewari
Hi everyone, Can you please review my changes for below bug. Bug: JDK-8080486 : JNI exception pending in jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c Webrev: http://cr.openjdk.java.net/~dfuchs/vyom/8080486/webrev.01 This change ensure that we immediately return if

Re: RFR 8080486: JNI exception pending in jdk/src/java.base/windows/native/libnet/DualStackPlainSocketImpl.c

2015-09-02 Thread Ivan Gerasimov
This looks good. In general, it might be more appropriate to review this on net-...@openjdk.java.net alias. Sincerely yours, Ivan On 02.09.2015 16:22, Vyom Tewari wrote: Hi everyone, Can you please review my changes for below bug. Bug: JDK-8080486 : JNI exception pending in jdk/src/

JDK 9 RFR of JDK-8134982: Problem list TCKJapaneseChronology.java

2015-09-02 Thread Joseph D. Darcy
Hello, Until the HotSpot issue in JDK-8134979 is addressed, the test java/time/tck/java/time/chrono/TCKJapaneseChronology.java should be placed on the problem list to avoid repeated uninformative test failures. Please review the patch below. Thanks, -Joe diff -r d9bd64884486 test/Prob

Re: JDK 9 RFR of JDK-8134982: Problem list TCKJapaneseChronology.java

2015-09-02 Thread Lance Andersen
ok by me On Sep 2, 2015, at 3:27 PM, "Joseph D. Darcy" wrote: > Hello, > > Until the HotSpot issue in JDK-8134979 is addressed, the test > >java/time/tck/java/time/chrono/TCKJapaneseChronology.java > > should be placed on the problem list to avoid repeated uninformative test > failures.

RFR: 8134984: Text files should end in exactly one newline

2015-09-02 Thread Martin Buchholz
http://cr.openjdk.java.net/~martin/webrevs/openjdk9/one-newline/one-newline.patch https://bugs.openjdk.java.net/browse/JDK-8134984 Sherman, what's up with repeated A1A4 in IBM1381.c2b?

Re: RFR: 8134984: Text files should end in exactly one newline

2015-09-02 Thread Chris Hegarty
There was a thread a while back, over on the tools mailing list about the enforcement of this [1]. -Chris. [1] http://mail.openjdk.java.net/pipermail/hg-tools-dev/2015-May/thread.html > On 2 Sep 2015, at 21:05, Martin

Re: RFR: 8134984: Text files should end in exactly one newline

2015-09-02 Thread Martin Buchholz
On Wed, Sep 2, 2015 at 1:14 PM, Chris Hegarty wrote: > There was a thread a while back, over on the tools mailing list about the > enforcement of this [1]. > I support enforcement of one-newline via jcheck or other mechanism, and this change would be a pre-requisite for that, but we can fix thin

Re: RFR: 8134984: Text files should end in exactly one newline

2015-09-02 Thread Chris Hegarty
> On 2 Sep 2015, at 21:22, Martin Buchholz wrote: > > > On Wed, Sep 2, 2015 at 1:14 PM, Chris Hegarty > wrote: > There was a thread a while back, over on the tools mailing list about the > enforcement of this [1]. > > I support enforcement of one-newline via

Re: RFR: 8134984: Text files should end in exactly one newline

2015-09-02 Thread Xueming Shen
On 09/02/2015 01:05 PM, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/openjdk9/one-newline/one-newline.patch https://bugs.openjdk.java.net/browse/JDK-8134984 Sherman, what's up with repeate