Re: Suggested fix for JDK-4724038 (Add unmap method to MappedByteBuffer)

2015-09-11 Thread Peter Levart
On 09/11/2015 12:42 AM, Vitaly Davidovich wrote: There's still a race condition since someone may have passed the guard, entered a safepoint, and then proceeded to access the memory. Yeah, and I realized yesterday after posting that this wouldn't work for views of the buffer (dulicate(),

Re: RFR 9: 8133552 : java/lang/ProcessHandle/InfoTest.java fails intermittently - incorrect user

2015-09-11 Thread Volker Simonis
Hi Roger, looks good now. Thanks, Volker On Thu, Sep 10, 2015 at 7:03 PM, Roger Riggs wrote: > Hi Volker, > > Thanks for the review, I added the code you provided to use the correct > length. > > Updated the webrev: > http://cr.openjdk.java.net/~rriggs/webrev-info-8133552/ > > Roger > > >

Re: Suggested fix for JDK-4724038 (Add unmap method to MappedByteBuffer)

2015-09-11 Thread Andrew Haley
On 09/11/2015 07:15 AM, David Holmes wrote: > On 11/09/2015 12:56 AM, Vitaly Davidovich wrote: >>> >>> Sure, if you like, but that's a detail. We are arguing about what >>> colour to paint the bike shed. :) >> >> >> The reason it may be more than just a bikeshed is because if this requires >> mor

Re: Suggested fix for JDK-4724038 (Add unmap method to MappedByteBuffer)

2015-09-11 Thread David Holmes
On 11/09/2015 6:37 PM, Andrew Haley wrote: On 09/11/2015 07:15 AM, David Holmes wrote: On 11/09/2015 12:56 AM, Vitaly Davidovich wrote: Sure, if you like, but that's a detail. We are arguing about what colour to paint the bike shed. :) The reason it may be more than just a bikeshed is bec

Re: Suggested fix for JDK-4724038 (Add unmap method to MappedByteBuffer)

2015-09-11 Thread Vitaly Davidovich
Those are precisely the ones I was referring to that we'd want to avoid when requesting a safepoint for this scenario. That ought to be a matter of simply passing a flag to safepoint synchronization telling it to skip cleanup tasks. sent from my phone On Sep 11, 2015 6:01 AM, "David Holmes" wrot

RFR: 8132541 : (process) ProcessBuilder support for redirection to discard output

2015-09-11 Thread Roger Riggs
Please review a proposed [1] ProcessBuilder addition to define a Redirect that will discard output. The implementation is to redirect output to /dev/null or NUL on Windows. Please review and comment if there are any unexpected side effects. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-81

Re: [9] Review request JDK-8131667: JAX-WS Plugability Layer: using java.util.ServiceLoader

2015-09-11 Thread Miroslav Kos
On 27/08/15 20:26, Miroslav Kos wrote: On 20/08/15 19:18, Alan Bateman wrote: On 19/08/2015 16:37, Miroslav Kos wrote: Hi everybody, I am sending changes for review. CCC: http://ccc.us.oracle.com/8131667 JBS: https://bugs.openjdk.java.net/browse/JDK-8131667 webrev: http://cr.openjdk.java.net/

Re: RFR: 8132541 : (process) ProcessBuilder support for redirection to discard output

2015-09-11 Thread David M. Lloyd
Nifty, thanks! On 09/11/2015 10:30 AM, Roger Riggs wrote: Please review a proposed [1] ProcessBuilder addition to define a Redirect that will discard output. The implementation is to redirect output to /dev/null or NUL on Windows. Please review and comment if there are any unexpected side effec

Re: RFR: 8132541 : (process) ProcessBuilder support for redirection to discard output

2015-09-11 Thread Remi Forax
Great !, minor comments, nullFile should be NULL_FILE and @since 9 -> @since 1.9 regards, Rémi - Mail original - > De: "Roger Riggs" > À: "Core-Libs-Dev" > Envoyé: Vendredi 11 Septembre 2015 17:30:06 > Objet: RFR: 8132541 : (process) ProcessBuilder support for redirection to > disc

Re: RFR: 8132541 : (process) ProcessBuilder support for redirection to discard output

2015-09-11 Thread Roger Riggs
Hi Remi, I corrected the NULL_FILE naming. The versioning for 9 (see Project Verona) will be dropping the leading "1." so I thought to start now. When Verona is committed, it will include a bulk change of "1.9" to "9". Thanks, Roger On 9/11/2015 1:11 PM, Remi Forax wrote: Great !, minor