RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

2016-01-10 Thread Chris Hegarty
In preparation for JEP 260, and as per the suggestion over on the core libs[1], sun.misc.PerformanceLogger should be moved to sun.util.logging. http://cr.openjdk.java.net/~chegar/8146735/ -Chris [1] http://mail.openjdk.java.net/pipermail/core-libs-dev/2016-January/037959.html

Re: JDK 9 RFR to remove jdk/internal/jimage/JImageReadTest.java from the problem list

2016-01-10 Thread Alan Bateman
On 09/01/2016 19:35, James Laskey wrote: Alan questioned why this is showing up after the sjavac changes. There was concern there was some lurking issue. No issue removing the test from the exclude list, that should have been done as part of JDK-8146712. I think we need to establish whethe

Re: RFR [9] 8146735: Move sun.misc.PerformanceLogger to sun.util.logging

2016-01-10 Thread Alan Bateman
On 10/01/2016 09:19, Chris Hegarty wrote: In preparation for JEP 260, and as per the suggestion over on the core libs[1], sun.misc.PerformanceLogger should be moved to sun.util.logging. http://cr.openjdk.java.net/~chegar/8146735/ This looks okay to me. -Alan

RFR [9] 8146736: Move sun.misc performance counters to jdk.internal.perf

2016-01-10 Thread Chris Hegarty
In preparation for JEP 260, the performance counters can be moved out of sun.misc and located somewhere more appropriate, like jdk.internal.perf. http://cr.openjdk.java.net/~chegar/8146736/ Mandy asked whether this change should go through jdk9/hs-rt or jdk9/dev, I see no strong reason why is sho

Re: RFR [9] 8146736: Move sun.misc performance counters to jdk.internal.perf

2016-01-10 Thread Alan Bateman
On 10/01/2016 09:31, Chris Hegarty wrote: In preparation for JEP 260, the performance counters can be moved out of sun.misc and located somewhere more appropriate, like jdk.internal.perf. http://cr.openjdk.java.net/~chegar/8146736/ Mandy asked whether this change should go through jdk9/hs-rt or

Re: RFR [9] 8146736: Move sun.misc performance counters to jdk.internal.perf

2016-01-10 Thread David Holmes
Hi Chris, On 10/01/2016 7:31 PM, Chris Hegarty wrote: In preparation for JEP 260, the performance counters can be moved out of sun.misc and located somewhere more appropriate, like jdk.internal.perf. http://cr.openjdk.java.net/~chegar/8146736/ Mandy asked whether this change should go through

RFR 8068938: javax.script package description should specify use of ServiceLoader

2016-01-10 Thread Sundararajan Athijegannathan
Please review http://cr.openjdk.java.net/~sundar/8068938/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8068938 This is a doc-only change to mention that ScriptEngineFactory instances are loaded using java.util.ServiceLoader API and avoid wording on META-INF/services [ which is just o

Re: RFR [9] 8146736: Move sun.misc performance counters to jdk.internal.perf

2016-01-10 Thread Chris Hegarty
On 11 Jan 2016, at 01:46, David Holmes wrote: > Hi Chris, > > On 10/01/2016 7:31 PM, Chris Hegarty wrote: >> In preparation for JEP 260, the performance counters can be moved out of >> sun.misc and located somewhere more appropriate, like jdk.internal.perf. >> >> http://cr.openjdk.java.net/~che

Re: RFR: JDK-8144144 - ORB destroy() leaks filedescriptors after unsuccessful connection

2016-01-10 Thread Chris Hegarty
On 8 Jan 2016, at 17:49, Mark Sheppard wrote: > Hi > please oblige and review the following changes > http://cr.openjdk.java.net/~msheppar/8144144/webrev/ In SelectorImpl.clearDeferredRegistrations() there is no need to call close() on the Socket returned from channel.socket(), since you have