Re: Proposal: java.lang.reflect.Proxy and default methods

2016-06-05 Thread Peter Levart
Hi Jake, On 06/05/2016 08:28 AM, Jake Wharton wrote: On Fri, Jun 3, 2016 at 10:58 AM Peter Levart > wrote: InvocationHandler gets invoked for default methods, but it has not provision to forward such calls to the default implementations in the interfa

Math.round optimization, and round to int

2016-06-05 Thread Jeff Hain
Hi. While playing around with Math.round(double) code, I found out that if (longBits < 0) {     r = -r; } can be replaced with: long bitsSignum = (((longBits >> 63) << 1) + 1); // 2*0+1 = 1, or 2*-1+1 = -1 r *= bitsSignum; which seems a bit faster, as one could expect due to less branching.

Re: Math.round optimization, and round to int

2016-06-05 Thread Remi Forax
or use r = r * (longBits < 0)? -1: 1; which should be compiled to a conditional move. cheers, Rémi - Mail original - > De: "Jeff Hain" > À: core-libs-dev@openjdk.java.net > Envoyé: Dimanche 5 Juin 2016 20:17:49 > Objet: Math.round optimization, and round to int > > Hi. > > > > Whi

Re: RFR: JDK-8061777, , (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

2016-06-05 Thread Ulf Zibis
Sherman, thanks for your consideration. Am 31.05.2016 um 19:08 schrieb Xueming Shen: Ulf, thanks for the suggestions! On 5/31/16 6:27 AM, Ulf Zibis wrote: Hi Sherman, 1.) wouldn't it be better to have a public getBytes() in AbstractStringBuilder? Then you could save the array copy with sb.toS

Re: RFR: JDK-8061777, , (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

2016-06-05 Thread Ulf Zibis
Am 05.06.2016 um 21:30 schrieb Ulf Zibis: Is this the answer to my # 3.) ? I really often see Windows-1252 coded zip files for download in the web. Maybe you see them rarely as american, but if there are german Umlaute in the file names, it' really painful to convert all the paths here on UTF-8

Re: RFR: JDK-8061777, , (zipfs) IllegalArgumentException in ZipCoder.toString when using Shitft_JIS

2016-06-05 Thread Ulf Zibis
Am 05.06.2016 um 21:30 schrieb Ulf Zibis: And I still think, moving the string concatenation to ZipPath constructor would be a good idea. I believe, this would make things more simple and less redundant: ZipPath(ZipFileSystem zfs, String first, String... more) E.g. you could reuse the String

Re: RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

2016-06-05 Thread Michael Haupt
Hi Shilpi, CCC approval is in. My review is lower-case, so another one is needed ere I can sponsor the push. Best, Michael > Am 02.06.2016 um 14:53 schrieb Michael Haupt : > > Hi Shilpi, > > lower-case thumbs up. Please obtain CCC approval for this change. > > Best, > > Michael > >> Am 02

Re: RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

2016-06-05 Thread Sundararajan Athijegannathan
Looks good -Sundar On 6/6/2016 12:16 PM, Michael Haupt wrote: > Hi Shilpi, > > CCC approval is in. My review is lower-case, so another one is needed ere I > can sponsor the push. > > Best, > > Michael > >> Am 02.06.2016 um 14:53 schrieb Michael Haupt : >> >> Hi Shilpi, >> >> lower-case thumbs u