JDK 9 (JAXP) RFR of JDK-8156598: jaxp: Use more informative format for problem list

2016-07-04 Thread Amy Lu
Please review this patch to update jaxp/test/ProblemList.txt to the more informative format, which has been used in "langtools" "jdk", but has not yet in "jaxp". bug: https://bugs.openjdk.java.net/browse/JDK-8156598 webrev: http://cr.openjdk.java.net/~amlu/8156598/webrev.00/ Thanks, Amy

Re: JDK 9 (JAXP) RFR of JDK-8156598: jaxp: Use more informative format for problem list

2016-07-04 Thread Lance Andersen
looks fine Amy > On Jul 4, 2016, at 6:14 AM, Amy Lu wrote: > > Please review this patch to update jaxp/test/ProblemList.txt to the more > informative format, > which has been used in "langtools" "jdk", but has not yet in "jaxp". > > bug: https://bugs.openjdk.java.net/browse/JDK-8156598 > webre

[9] RFR: 8154553: Incorrect GPL header in package-info.java reported

2016-07-04 Thread Aleks Efimov
Hello, jdk/src/jdk.accessibility/share/classes/com/sun/java/accessibility/util/package-info.java file contains incorrect GPL header which fails make/scripts/lic_check.sh script check. Failure is caused by missing comma after modification years. Please, help to review its addition: http:

Re: [9] RFR: 8154553: Incorrect GPL header in package-info.java reported

2016-07-04 Thread Ivan Gerasimov
Hi Aleks! Is it the only mistake detected by that script? Again, grep finds a few more similar typos in the copyright headers: java.desktop/share/classes/sun/awt/RequestFocusController.java: * Copyright (c) 2006, 2016 Oracle and/or its affiliates. All rights reserved. java.desktop/unix/native/l

Re: [9] RFR: 8154553: Incorrect GPL header in package-info.java reported

2016-07-04 Thread Aleks Efimov
Hi Ivan, Thank you for looking into this one. Is it the only mistake detected by that script? Of course not, we have a lot of similar errors across JDK9 (and 8). To track modifications of all incorrect headers across all JDK sub-repositories we already have JDK-8159475 bug logged. The approach

Re: [9] RFR: 8154553: Incorrect GPL header in package-info.java reported

2016-07-04 Thread Ivan Gerasimov
On 05.07.2016 3:06, Aleks Efimov wrote: Hi Ivan, Thank you for looking into this one. Is it the only mistake detected by that script? Of course not, we have a lot of similar errors across JDK9 (and 8). To track modifications of all incorrect headers across all JDK sub-repositories we alread

Re: RFR[9]: 8158510: Add test cases to validate Annotation

2016-07-04 Thread shilpi.rast...@oracle.com
Hi All, Please review updated webrev http://cr.openjdk.java.net/~srastogi/8158510/webrev.03/ Regards, Shilpi On 7/1/2016 5:11 PM, shilpi.rast...@oracle.com wrote: Thanks Paul !! Please see http://cr.openjdk.java.net/~srastogi/8158510/webrev.01/ Regards, Shilpi On 7/1/2016 3:12 PM, Paul Sa