Re: RFR(XS): 8162670: make of jtreg_tests fails if no tests are run, causing jprt test runs to also fail

On 4/08/2016 2:35 PM, Chris Plummer wrote: Unfortunately I need another review of these changes. I ran into a minor problem. Although all the jprt testing I tried passed, when I looked into the log files I noticed an issue. I saw the following: Test results: passed: 1 Report written to /opt/jprt

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

Hi David, On 03.08.2016 23:56, David Holmes wrote: Hi Dmitrij, I know this reflects the changes made in hotspot/test but I have a query. Does this: + requires.extraPropDefns.vmOpts = -XX:+UnlockDiagnosticVMOptions -XX:+WhiteBoxAPI -Xbootclasspath/a:bootClasses mean that the VM under test

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

Dima, I’d prefer to have tests moved into hotspot repo instead. none of jdk tests should depend on vm kind or any other details of vm. your change just makes things worse, we will not just have tests which depend on vm implementation details in jdk, we will also have an mechanism for other test

RE: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit tests

> -Original Message- > From: Joe Wang [mailto:huizhe.w...@oracle.com] > Subject: Re: RFR (JAXP) JDK-8067170: Enable security manager on JAXP unit > tests > > > > On 8/3/16, 3:45 AM, Daniel Fuchs wrote: > > Hi Frank, > > > > I looked at the diffs of the diffs between webrev.02 and webr

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

Hi, I'm aware of one test only so far. Shoud I move this single test or a whole testgroup which this test belongs to? Thanks, Dmitrij Dima, I’d prefer to have tests moved into hotspot repo instead. none of jdk tests should depend on vm kind or any other details of vm. your change just mak

[jdk9] RFR (XXS): 8163180: Typos around @code javadoc tag usage

Hello! In a few places the @code javadoc tag misses the curly bracket. Would you please review a trivial fix? http://cr.openjdk.java.net/~igerasim/8163180/00/webrev/ With kind regards, Ivan

Re: [jdk9] RFR (XXS): 8163180: Typos around @code javadoc tag usage

Hi Ivan, Looks good! best regards, -- daniel On 04/08/16 13:52, Ivan Gerasimov wrote: Hello! In a few places the @code javadoc tag misses the curly bracket. Would you please review a trivial fix? http://cr.openjdk.java.net/~igerasim/8163180/00/webrev/ With kind regards, Ivan

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

Igor, Regardless this change I agree with you: VM specific tests should be moved from jdk to hotspot. But we can't get rid of VM specific tests in the jdk repository at all. Tests for java.lang.management belong to JDK, but may use VM specific... I count 11 open and 100 closed jdk tests whic

Re: Why is there no Math.ceilDiv?

On 31 July 2016 at 20:45, Philipp Nowak wrote: > I was wondering why there is no Math.ceilDiv() method, when a floorDiv() > method got added in Java 8 through JDK-8023217 [1]. > > Is there any reason why such method did not get added with floorDiv() floorDiv() was added as part of creating java.t

Re: RFR(S): 8162727 - Testbug: additional requires properties can't be used for filtering server vm in jdk jtreg tests

> On Aug 4, 2016, at 3:56 PM, Dmitry Fazunenko > wrote: > > Igor, > > Regardless this change I agree with you: VM specific tests should be moved > from jdk to hotspot. > > But we can't get rid of VM specific tests in the jdk repository at all. Tests > for java.lang.management belong to JDK,

RFR: JDK-8161230 - Create java.util.stream.Stream from Iterator / Enumeration

Hi Paul, I was quit busy lately and this comes a bit late, I guess you do not have less work ;-) On 15.07.2016 17:10, Paul Sandoz wrote: >> When I understand you correctly here we should concentrate on the public >> methods naming firstly? I initially was not sure, what a proper naming >> for th

RFR (XS): 8162815: unnecessary object creation in reflection

Hi, I'd like to sponsor this bug fix provided by Tomáš Hůrka to remove a new and dup left behind in generated accessor methods after moving these to use appropriate valueOf methods for boxing primitive returns. Bug: https://bugs.openjdk.java.net/browse/JDK-8162815 Webrev: http://cr.openjdk.ja

RFR (JAXP) 8160069: RuntimeException thrown by XPathFactory::newInstance missing the cause

Hi, Please review the patch that sets the cause to the Exception: http://cr.openjdk.java.net/~joehw/jdk9/8160069/webrev/ Thanks, Joe

Re: RFR(XS): 8162670: make of jtreg_tests fails if no tests are run, causing jprt test runs to also fail

I am ok with the recent changes On 04.08.2016 00:31, David Holmes wrote: On 4/08/2016 2:35 PM, Chris Plummer wrote: Unfortunately I need another review of these changes. I ran into a minor problem. Although all the jprt testing I tried passed, when I looked into the log files I noticed an issu

Re: RFR (JAXP) 8160069: RuntimeException thrown by XPathFactory::newInstance missing the cause

+1 Joe > On Aug 4, 2016, at 6:06 PM, Joe Wang wrote: > > Hi, > > Please review the patch that sets the cause to the Exception: > http://cr.openjdk.java.net/~joehw/jdk9/8160069/webrev/ > > Thanks, > Joe >

Re: RFR (JAXP) 8160069: RuntimeException thrown by XPathFactory::newInstance missing the cause

Thanks Lance! Joe On 8/4/16, 4:27 PM, Lance Andersen wrote: +1 Joe On Aug 4, 2016, at 6:06 PM, Joe Wang > wrote: Hi, Please review the patch that sets the cause to the Exception: http://cr.openjdk.java.net/~joehw/jdk9/8160069/webrev/

Re: RFR: JDK-8161230 - Create java.util.stream.Stream from Iterator / Enumeration

On 04/08/2016 10:33, Patrick Reinhart wrote: Hi Paul, I was quit busy lately and this comes a bit late, I guess you do not have less work ;-) On 15.07.2016 17:10, Paul Sandoz wrote: When I understand you correctly here we should concentrate on the public methods naming firstly? I initially w