RE: [concurrency-interest] We need to add blocking methods to CompletionStage!

2016-09-25 Thread David Holmes
I think that was meant to read “After this method returns _true_, subsequent calls …” David From: Concurrency-interest [mailto:concurrency-interest-boun...@cs.oswego.edu] On Behalf Of Viktor Klang Sent: Sunday, September 25, 2016 9:03 PM To: Martin Buchholz Cc: concurrency-interest ; cor

Re: RFR(s): 8166624: java/util/jar/JarFile/mrjar regression tests has undeclared dependencies

2016-09-25 Thread Sergei Kovalev
Hi Alan, The modules list in mrar/TEST.properties guarantee that jtreg add "--add-module @modules" command line option during test execution. If you create custom JRE that does not contains the modules, the tests fails. The proposed fix guarantee that jtreg skips the tests if no listed module

Re: [concurrency-interest] We need to add blocking methods to CompletionStage!

2016-09-25 Thread Viktor Klang
If that truely is the case then the only way of implementing a readonly Future is by throwing an exception from cancel... -- Cheers, √ On Sep 25, 2016 4:20 PM, "Joe Bowbeer" wrote: > This statement regarding what happens after cancel is called is correct: > > "*After this method returns, subse

Re: RFR(s): 8166624: java/util/jar/JarFile/mrjar regression tests has undeclared dependencies

2016-09-25 Thread Alan Bateman
On 25/09/2016 13:53, Sergei Kovalev wrote: Hi Alan, The modules list in mrar/TEST.properties guarantee that jtreg add "--add-module @modules" command line option during test execution. If you create custom JRE that does not contains the modules, the tests fails. The proposed fix guarantee th

Re: RFR: 8164479: Update JAX-WS RI integration to latest version

2016-09-25 Thread Alan Bateman
On 24/09/2016 18:57, Mandy Chung wrote: You can run jdeps --check java.xml.ws on your local build with this change. This will analyze the dependences and any unused qualified exports. Good idea. I think java.activation's module-info.java will need updating too as it no longer requires java.de

Re: RFR(s): 8166624: java/util/jar/JarFile/mrjar regression tests has undeclared dependencies

2016-09-25 Thread Sergei Kovalev
Hi Alan, Here is the result of one of the tests run in initial state (no fix applied) 1) no module limitation jtreg -jdk:/home/skovalev/TRASH/jdk-9 -verbose:all /home/skovalev/repos/jake/jdk/test/java/util/jar/JarFile/mrjar/MultiReleaseJarAPI.java TEST RESULT: Passed. Execution successful 2

Re: RFR(s): 8166624: java/util/jar/JarFile/mrjar regression tests has undeclared dependencies

2016-09-25 Thread Alan Bateman
On 25/09/2016 16:05, Sergei Kovalev wrote: Hi Alan, Here is the result of one of the tests run in initial state (no fix applied) For #2 and #3 then jtreg should ignore the test because they require jdk.compiler and jdk.jartool (declared in TEST.properties). This is why I'm wondering if we ha

Re: RFR(s): 8166624: java/util/jar/JarFile/mrjar regression tests has undeclared dependencies

2016-09-25 Thread Sergei Kovalev
If I've drop jdk.jartool, I faced with ClassNotFound error as I showed in #3 java.lang.ClassNotFoundException: jdk.security.jarsigner.JarSigner$Builder As you can see TEST.properties contains both: jdk.compiler and jdk.jartool 25.09.16 18:13, Alan Bateman wrote: On 25/09/2016 16:05, Sergei K

Re: [concurrency-interest] We need to add blocking methods to CompletionStage!

2016-09-25 Thread Martin Buchholz
On Sun, Sep 25, 2016 at 7:34 AM, Viktor Klang wrote: > If that truely is the case then the only way of implementing a readonly > Future is by throwing an exception from cancel... > We the maintainers of j.u.c.Future have always thought that canceling a Future will surely leave it completed. Of c

RE: [concurrency-interest] We need to add blocking methods to CompletionStage!

2016-09-25 Thread David Holmes
Joe, That is ignoring the error case. If the cancel fails then it is not complete and it is not cancelled. We added the extra wording back in August 2005. It is interesting to note that Martin’s initial query then only related to the state of the thread, but that it was clear about things on

Re: We need to add blocking methods to CompletionStage!

2016-09-25 Thread Martin Buchholz
On Fri, Sep 23, 2016 at 2:24 PM, Viktor Klang wrote: > > PS. As a sidenote, Martin, and in all friendliness, "actor purist API"? > C'mon, I know you're better than that! CompletionStage's design has nothing > to do with Actors and if Single Responsibility Principle is considered > purism then I'm

Re: RFR: 8164479: Update JAX-WS RI integration to latest version

2016-09-25 Thread Aleks Efimov
Hi Alan, Joe, Mandy, Roman, Suggested changes to the comment section (will bring this change to standalone JAXB) and to the exported internal API were made: com.sun.xml.internal.stream.writers, com.sun.org.apache.xml.internal.resolver, com.sun.org.apache.xml.internal.resolver.tools dependencie

Re: RFR: 8164479: Update JAX-WS RI integration to latest version

2016-09-25 Thread Lance Andersen
Hi Aleks, I still would suggest not pointing at jaxb.java.net for the specification given these projects are going to have to migrate elsewhere. Best Lance > On Sep 25, 2016, at 7:41 PM, Aleks Efimov wrote: > > Hi Alan, Joe, Mandy, Roman, > > Suggested changes to the comment section (will bri

Re: [concurrency-interest] We need to add blocking methods to CompletionStage!

2016-09-25 Thread Martin Buchholz
On Sun, Sep 25, 2016 at 2:22 PM, David Holmes wrote: > > Yet we somehow added the clarification with no regard as to whether cancel > returned true or not. That seems wrong. > Yikes! I had always assumed that cancel was not permitted to leave the Future incomplete, perhaps influenced by the wor