Re: RFR: 8173056: Add test that captures current behavior of annotations with invalid annotation types

2017-01-22 Thread Peter Levart
Hi, On 01/19/2017 04:58 PM, Peter Levart wrote: I extended the AnnotationVerifier test with additional cases that cover various "wrongs" in annotation types: http://cr.openjdk.java.net/~plevart/jdk9-dev/8173056_AnnotationVerifier/webrev.01/ My plan is to 1st get this test in as a separate

Re: RFR: 8173056: Add test that captures current behavior of annotations with invalid annotation types

2017-01-22 Thread Claes Redestad
Hi Peter, this looks good to me (and enhancements to existing tests are allowed even though we're in rampdown). As you've also clarified that only behavior for annotations that javac wouldn't have allowed in the first place have changed I retract my reservations against the fix for 8029019 - but

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-22 Thread Alan Bateman
On 21/01/2017 20:41, Xueming Shen wrote: Erik, Alan Here is the webrev that dropped the version number from the name. http://cr.openjdk.java.net/~sherman/8173140/webrev Switching to zlib looks good although it's impossible to see the changes in this webrev because all the files show up as ne

Re: RFR JDK-8173140: To upgrade bundled zlib version from 1.2.8 to 1.2.11

2017-01-22 Thread Xueming Shen
On 1/22/17, 9:46 AM, Alan Bateman wrote: On 21/01/2017 20:41, Xueming Shen wrote: Erik, Alan Here is the webrev that dropped the version number from the name. http://cr.openjdk.java.net/~sherman/8173140/webrev Switching to zlib looks good although it's impossible to see the changes in this

RFR of JDK-8171142: jdk_rmi registry test fail to clean up on failure

2017-01-22 Thread Hamlin Li
Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8171142 webrev: http://cr.openjdk.java.net/~mli/8171142/webrev.00/ Thank you -Hamlin