Thanks everybody! This was a real tough one :)
Maybe I'll ask Mark to put it on the Java 9 achievements slide at next
JavaOne :)
On Wed, Feb 15, 2017 at 3:03 AM, David Holmes wrote:
> Looks good to me!
>
> Thanks,
> David
>
>
> On 15/02/2017 4:52 AM, Volker Simonis wrote:
>>
>> Hi,
>>
>> can I p
? Fixing jexec is a separate issue and not really build related.
Yes that's true, I created a separate bug for this :
https://bugs.openjdk.java.net/browse/JDK-8175000
Regards, Matthias
From: Erik Joelsson [mailto:erik.joels...@oracle.com]
Sent: Dienstag, 14. Februar 2017 17:57
To: Baesken, Ma
Hi Lance,
On 02/14/2017 09:28 PM, Lance Andersen wrote:
Hi Roman,
I made a pass through the changes. And here are some general comments
which are mostly minor in nature….
HTH
Best
Lance
--
JAXBRIContext.java:
- The comment “If true, despite of the specification….”; Thi
Hi Mandy,
On 02/14/2017 11:53 PM, Mandy Chung wrote:
On Feb 14, 2017, at 4:00 AM, Roman Grigoriadi
wrote:
Hi,
Please review standalone JAXB/JAXWS changes, synced to jdk/jaxws repo.
JBS: https://bugs.openjdk.java.net/browse/JDK-8174735
Webrev: http://cr.openjdk.java.net/~aefimov/jaxws-integr
Adding Lukas
On 02/15/2017 01:40 PM, Roman Grigoriadi wrote:
Hi Lance,
On 02/14/2017 09:28 PM, Lance Andersen wrote:
Hi Roman,
I made a pass through the changes. And here are some general
comments which are mostly minor in nature….
HTH
Best
Lance
--
JAXBRIContext.ja
Hi,
comments wrt JSR-250 inline, also adding Linda who maintains it these
days to the loop
On 2/15/17 2:36 PM, Roman Grigoriadi wrote:
Adding Lukas
On 02/15/2017 01:40 PM, Roman Grigoriadi wrote:
Hi Lance,
On 02/14/2017 09:28 PM, Lance Andersen wrote:
Hi Roman,
I made a pass through t
Hi
please oblige and review the following change:
http://cr.openjdk.java.net/~msheppar/8146299-II/webrev.03/
to address the issue:
https://bugs.openjdk.java.net/browse/JDK-8146299
which is to disables a currently undocumented, and unsupported feature
in rmic
* the parsing of the commandline
> On 15 Feb 2017, at 14:21, Mark Sheppard wrote:
>
> Hi
> please oblige and review the following change:
> http://cr.openjdk.java.net/~msheppar/8146299-II/webrev.03/
This looks good to me Mark.
-Chris.
> to address the issue:
> https://bugs.openjdk.java.net/browse/JDK-8146299
>
> which is t
thanks Chris
On 15/02/2017 15:05, Chris Hegarty wrote:
On 15 Feb 2017, at 14:21, Mark Sheppard wrote:
Hi
please oblige and review the following change:
http://cr.openjdk.java.net/~msheppar/8146299-II/webrev.03/
This looks good to me Mark.
-Chris.
to address the issue:
https://bugs.openj
Looks good Mark,
Thanks, Roger
p.s. There is a more recent version of webrev.ksh that includes
convenient next and previous links.
http://hg.openjdk.java.net/code-tools/webrev/raw-file/d26c194772db/webrev.ksh
On 2/15/2017 9:21 AM, Mark Sheppard wrote:
Hi
please oblige and review the foll
thanks Roger
On 15/02/2017 15:35, Roger Riggs wrote:
Looks good Mark,
Thanks, Roger
p.s. There is a more recent version of webrev.ksh that includes
convenient next and previous links.
http://hg.openjdk.java.net/code-tools/webrev/raw-file/d26c194772db/webrev.ksh
On 2/15/2017 9:21 AM, Ma
Hi,
Please, help to review the change required by JAXWS-RI code [1]:
SAXParser needs to reset internal SymbolTable to enable pooling of
parsers in SAAJ-RI code. Latest version of JAXWS-RI code (that is
currently under review [2]) doesn't provide a workaround to reset the
symbol table (it was
Hi,
Please review the fix for bug [1]. The fix is improving an already
existing error message. The public patch can be reached at [2]
Thanks,
Vicente
[1] https://bugs.openjdk.java.net/browse/JDK-8174694
[2] http://cr.openjdk.java.net/~vromero/8174694/webrev.00/jdk.patch
On 15/02/2017 17:03, Vicente Romero wrote:
Hi,
Please review the fix for bug [1]. The fix is improving an already
existing error message. The public patch can be reached at [2]
Thanks,
Vicente
[1] https://bugs.openjdk.java.net/browse/JDK-8174694
[2] http://cr.openjdk.java.net/~vromero/81746
Hi Aleksej,
I just realized there were other dependencies on the SymbolTable
instance initialized in the constructor (line 575 in your new code),
which was probably why you kept the code from 574 through 579 after
adding new SymbolTable for each parsing process (850 - 854). As a
result, the S
> On Feb 15, 2017, at 6:21 AM, Mark Sheppard wrote:
>
> Hi
> please oblige and review the following change:
> http://cr.openjdk.java.net/~msheppar/8146299-II/webrev.03/
Looks okay.
For the test, can you move @ignore to the top after @test which makes it easier
to tell this test is ignored.
The simplest reproductor for this issue is:
public class A extends B {
public static void main(String... args) {}
}
-
Hi Aleksej,
In the test:
75 Assert.assertNotEquals(symTable1, symTable2, "Symbol table
refence is the same");
I guess you meant Assert.assertNotSame - if what you want to do
is compare references.
(+ there is a typo in the message: refence => reference)
best regards,
-- daniel
On
On 15/02/2017 17:21, Vicente Romero wrote:
The simplest reproductor for this issue is:
public class A extends B {
public static void main(String... args) {}
}
On 2/15/17 9:18 AM, Mandy Chung wrote:
On Feb 15, 2017, at 6:21 AM, Mark Sheppard wrote:
please oblige and review the following change:
http://cr.openjdk.java.net/~msheppar/8146299-II/webrev.03/
For the test, can you move @ignore to the top after @test which makes it easier
to tell this te
On 2/15/2017 10:39 AM, Alan Bateman wrote:
On 15/02/2017 17:21, Vicente Romero wrote:
The simplest reproductor for this issue is:
public class A extends B {
public static void main(String..
Hi,
Thanks guys for your comments. I have uploaded another iteration of the
review at [1],
Vicente
[1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch
On 02/15/2017 02:06 PM, Kumar Srinivasan wrote:
On 2/15/2017 10:39 AM, Alan Bateman wrote:
On 15/02/2017 17:21, Vicente Ro
Please review this trivial fix [1] for [2]. The intent is to add to the test
log evidence that the test in fact completed. Also cf. [3].
Thanks,
Brian
[1] diff
--- a/test/java/io/FileInputStream/LargeFileAvailable.java
+++ b/test/java/io/FileInputStream/LargeFileAvailable.java
@@ -71,6 +71,9 @
Hi Vicente,
Looks good.
Mucho gracias for fixing this!.
Kumar
Hi,
Thanks guys for your comments. I have uploaded another iteration of
the review at [1],
Vicente
[1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch
On 02/15/2017 02:06 PM, Kumar Srinivasan wrote:
On 2/15/
On 02/15/2017 04:12 PM, Kumar Srinivasan wrote:
Hi Vicente,
Looks good.
Mucho gracias for fixing this!.
thanks!
Kumar
Vicente
Hi,
Thanks guys for your comments. I have uploaded another iteration of
the review at [1],
Vicente
[1] http://cr.openjdk.java.net/~vromero/8174694/webr
On 15/02/2017 20:41, Vicente Romero wrote:
Hi,
Thanks guys for your comments. I have uploaded another iteration of
the review at [1],
Vicente
[1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch
I assume you use getClass + getMessage to avoid calling the exception's
toStrin
I don't like these "success" messages. I think they're appropriate for
debugging, but not the final form of a test.
The call to flush() is likely a no-op; see Java Puzzlers item "Charred
beyond recognition."
If the main method fails to terminate, then jtreg will catch that, and
more usefully, r
+1
> On Feb 15, 2017, at 4:04 PM, Brian Burkhalter
> wrote:
>
> Please review this trivial fix [1] for [2]. The intent is to add to the test
> log evidence that the test in fact completed. Also cf. [3].
>
> Thanks,
>
> Brian
>
> [1] diff
>
> --- a/test/java/io/FileInputStream/LargeFileAvai
As background there are four tests failing with an Agent timeout where the
tests appear to succeed. Two of the four have similar messages to this so this
was intended to round out the set perhaps better to point to a harness problem
as opposed to test problems.
On Feb 15, 2017, at 1:48 PM, Mart
On 02/15/2017 04:25 PM, Alan Bateman wrote:
On 15/02/2017 20:41, Vicente Romero wrote:
Hi,
Thanks guys for your comments. I have uploaded another iteration of
the review at [1],
Vicente
[1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch
I assume you use getClass + getMe
oki doki ... np ... amendments have been made ... verification testing
in progress
regards
Mark
On 15/02/2017 18:57, Stuart Marks wrote:
On 2/15/17 9:18 AM, Mandy Chung wrote:
On Feb 15, 2017, at 6:21 AM, Mark Sheppard
wrote:
please oblige and review the following change:
http://cr.op
On 16/02/2017 7:25 AM, Alan Bateman wrote:
On 15/02/2017 20:41, Vicente Romero wrote:
Hi,
Thanks guys for your comments. I have uploaded another iteration of
the review at [1],
Vicente
[1] http://cr.openjdk.java.net/~vromero/8174694/webrev.01/jdk.patch
I assume you use getClass + getMessag
Hi,
The new webrev with addressed comments was uploaded here:
http://cr.openjdk.java.net/~aefimov/jaxws-integrations/8174735/01
Best,
Aleksej
On 15/02/17 15:42, Roman Grigoriadi wrote:
Hi Mandy,
On 02/14/2017 11:53 PM, Mandy Chung wrote:
On Feb 14, 2017, at 4:00 AM, Roman Grigoriadi
wrote:
Hi Joe,
Thank you for your suggestions. New webrev can be found here:
http://cr.openjdk.java.net/~aefimov/8173390/9/01
Hi Daniel,
You're right that assertNotSame suites better here, i.e. it has nice
output in case of failure. Because of that I removed the sout.println's
from the test too.
Wi
Looks good to me.
Thanks,
Joe
On 2/15/2017 3:56 PM, Aleks Efimov wrote:
Hi Joe,
Thank you for your suggestions. New webrev can be found here:
http://cr.openjdk.java.net/~aefimov/8173390/9/01
Hi Daniel,
You're right that assertNotSame suites better here, i.e. it has nice
output in case of fai
Thank you Joe!
On 16/02/17 03:07, huizhe wang wrote:
Looks good to me.
Thanks,
Joe
On 2/15/2017 3:56 PM, Aleks Efimov wrote:
Hi Joe,
Thank you for your suggestions. New webrev can be found here:
http://cr.openjdk.java.net/~aefimov/8173390/9/01
Hi Daniel,
You're right that assertNotSame sui
I checked module-info.java, default.policy and also the tools `—-release`
option. This version looks fine to me.
Mandy
> On Feb 15, 2017, at 3:49 PM, Aleks Efimov wrote:
>
> Hi,
>
> The new webrev with addressed comments was uploaded here:
> http://cr.openjdk.java.net/~aefimov/jaxws-integrat
Hi Roman, Aleks,
This looks better.
There are several files in Datatype/helper such as
arameterlessDatatypeBuilder.java. who had the copyright date changed but there
are not other updates. Not sure that you want that
Best
Lance
> On Feb 15, 2017, at 7:14 PM, Mandy Chung wrote:
>
> I check
java/nio/channels/AsyncCloseAndInterrupt.java
This test is known to fail intermittently (JDK-8172045), this patch is
to mark the test accordingly with keyword 'intermittent'.
Please review.
bug: https://bugs.openjdk.java.net/browse/JDK-8175062
webrev: http://cr.openjdk.java.net/~amlu/8175062/
39 matches
Mail list logo
