Re: [8u-dev] (XS) RFR 8169056: StringIndexOutOfBoundsException in Pattern.compile with CANON_EQ flag

2017-03-23 Thread Seán Coffey
Looks good. regards, Sean. On 23/03/2017 00:26, Ivan Gerasimov wrote: Hello! This is an 8u-dev only fix. (In 9 the bug was fixed with a massive update [1]). The fix is essentially one-liner: just check that the index remains within the bounds after update. Regression test was updated to co

Re: [8u-dev] (XS) RFR 8169056: StringIndexOutOfBoundsException in Pattern.compile with CANON_EQ flag

2017-03-23 Thread David Buck
approved for push to 8u-dev Cheers, -Buck On 2017/03/23 17:55, Seán Coffey wrote: Looks good. regards, Sean. On 23/03/2017 00:26, Ivan Gerasimov wrote: Hello! This is an 8u-dev only fix. (In 9 the bug was fixed with a massive update [1]). The fix is essentially one-liner: just check that

Re: [9] RFR: 8177136: Caller sensitive method System.getLogger should specify what happens if there is no caller on the stack.

2017-03-23 Thread Daniel Fuchs
Hi Jason, I'm not sure JDK-8145302 is the same problem: I double checked that I could call Logger.getLogger("foo") and Logger.info("foo") from JNI with no issue (works both with jdk8 122 and jdk9/dev). So I'm quite puzzled about what could have caused JDK-8145302. If Logger.getLogger() is called

Re: [9] RFR(L) 8158168: SIGSEGV: CollectedHeap::fill_with_objects(HeapWord*, unsigned long, bool)+0xa8

2017-03-23 Thread dean . long
On 3/22/17 1:49 PM, Vladimir Ivanov wrote: Also, it looks like the changes I made to ASB.appendChars(char[] s, int off, int end) are not needed. Agree. Vladimir, don't you need to replace checkIndex with checkOffset in indexOf and lastIndexOf, so that we allow count == length? Yes, my bad.

Re: [8u-dev] (XS) RFR 8169056: StringIndexOutOfBoundsException in Pattern.compile with CANON_EQ flag

2017-03-23 Thread Ivan Gerasimov
Thank you Seán and David! On 3/23/17 1:59 AM, David Buck wrote: approved for push to 8u-dev Cheers, -Buck On 2017/03/23 17:55, Seán Coffey wrote: Looks good. regards, Sean. On 23/03/2017 00:26, Ivan Gerasimov wrote: Hello! This is an 8u-dev only fix. (In 9 the bug was fixed with a massi

Re: [9] RFR(L) 8158168: SIGSEGV: CollectedHeap::fill_with_objects(HeapWord*, unsigned long, bool)+0xa8

2017-03-23 Thread dean . long
On 3/23/17 11:25 AM, dean.l...@oracle.com wrote: On 3/22/17 1:49 PM, Vladimir Ivanov wrote: Also, it looks like the changes I made to ASB.appendChars(char[] s, int off, int end) are not needed. Agree. Vladimir, don't you need to replace checkIndex with checkOffset in indexOf and lastIndexO

Re: RFR (JAXP) 8176405 : Catalog circular reference check did not work in certain scenarios

2017-03-23 Thread huizhe wang
On 3/23/2017 11:08 AM, Roger Riggs wrote: Hi Joe, - javax.xml.catalog.GroupEntry.set(catalog):183 - rename the method to setCatalog(catalog) to be a bit more expressive. Done. - GroupEntry: 460:461; correct the @param for "catalogId" -> "catalogURI" Check all the @param catalogId

Re: RFR (JAXP) 8176405 : Catalog circular reference check did not work in certain scenarios

2017-03-23 Thread Roger Riggs
Looks good. Thanks, Roger On 3/23/2017 4:37 PM, huizhe wang wrote: On 3/23/2017 11:08 AM, Roger Riggs wrote: Hi Joe, - javax.xml.catalog.GroupEntry.set(catalog):183 - rename the method to setCatalog(catalog) to be a bit more expressive. Done. - GroupEntry: 460:461; correct the @p

Re: RFR (JAXP) 8176405 : Catalog circular reference check did not work in certain scenarios

2017-03-23 Thread Lance Andersen
Hi Joe, The current version, including our offline discussion, looks good. > On Mar 17, 2017, at 4:22 PM, huizhe wang wrote: > > Hi, > > Please review a fix to the circular reference check that incorrectly treated > duplicate entries as circular. > > JBS: https://bugs.openjdk.java.net/browse

A couple of questions on 8160954: (spec) Runtime.Version regex and $PRE/$OPT issues

2017-03-23 Thread Pavel Rappo
[This is not an RFR] I’ve been investigating JDK-8160954 [1] which mentions two separate problems within the specification of the Runtime.Version class. The first is about boundary matchers (^ and $) in the regular expression that defines the version number ($VNUM): ^[1-9][0-9]*(((\.0)*\.[1-9

Re: RFR (JAXP) 8176405 : Catalog circular reference check did not work in certain scenarios

2017-03-23 Thread huizhe wang
Thanks Roger, Lance! Re-running tests, I'll push the patch once they pass. -Joe On 3/23/2017 1:59 PM, Lance Andersen wrote: Hi Joe, The current version, including our offline discussion, looks good. On Mar 17, 2017, at 4:22 PM, huizhe wang > wrote: Hi, Pleas