On 13/04/2017 19:50, Volker Simonis wrote:
Hi,
can you please review the following change which fixes a problem with
UNC paths on the Windows class path:
http://cr.openjdk.java.net/~simonis/webrevs/2017/8178726/
https://bugs.openjdk.java.net/browse/JDK-8178726
I would appreciate if somebody c
I see some changes:
- relative url won't be supported
- path is no longer canonicalized
Maybe these are no problem for URLClassPath. Just my 2 cents.
--Max
On 04/14/2017 04:41 PM, Alan Bateman wrote:
On 13/04/2017 19:50, Volker Simonis wrote:
Hi,
can you please review the following change
Hi Hamlin,
Thank you very much for contributing these tests.
They look good to me!
I'm particularly happy to see that some of them tests the
API with a smaller image built with jlink.
None of the existing logging tests did that!
best regards
-- daniel
On 14/04/2017 07:33, Hamlin Li wrote:
Wou
Since this is a test development, I think it does not have to go through
the JDK 9 ramp down 2 approval procedures, I suppose now I'm OK to push
the code as usual?
Thank you
-Hamlin
On 2017/4/14 18:31, Daniel Fuchs wrote:
Hi Hamlin,
Thank you very much for contributing these tests.
They
On 14/04/2017 11:49, Hamlin Li wrote:
Since this is a test development, I think it does not have to go through
the JDK 9 ramp down 2 approval procedures, I suppose now I'm OK to push
the code as usual?
That's my understanding as well.
best regards,
-- daniel
Thank you
-Hamlin
On 2017/4/14 18:51, Daniel Fuchs wrote:
On 14/04/2017 11:49, Hamlin Li wrote:
Since this is a test development, I think it does not have to go through
the JDK 9 ramp down 2 approval procedures, I suppose now I'm OK to push
the code as usual?
That's my understanding as well.
Hi Daniel,
Got
On 14/04/2017 10:02, Weijun Wang wrote:
I see some changes:
- relative url won't be supported
- path is no longer canonicalized
Maybe these are no problem for URLClassPath. Just my 2 cents.
The URLs are already constructed from canonicalized file paths but maybe
you are thinking about usages
Volker,
On 13/04/17 19:50, Volker Simonis wrote:
Hi,
can you please review the following change which fixes a problem with
UNC paths on the Windows class path:
http://cr.openjdk.java.net/~simonis/webrevs/2017/8178726/
https://bugs.openjdk.java.net/browse/JDK-8178726
I would appreciate if some
On 14/04/2017 14:02, Chris Hegarty wrote:
I know that Alan has provided some comments on this, but I just
grabbed your patch and sent it through our internal build and test
system. I observed a few failures:
Yes, I think URLClassLoader will be broken (Max is right, I forgot that
URLClassPath i
Hi all,
Please review this changeset that fixes up links around the JDK that point to
the old Collections technotes/guides area. This changeset points them to the
java.util package summary instead.
Most of the changes here simply adjust a link location. The file that's
different is java/util
Hi, Stuart
The changes look fine. You found and changed all the references I could
find. Having the @index I think will be nice.
-Brent
On 4/14/17 3:36 PM, Stuart Marks wrote:
Hi all,
Please review this changeset that fixes up links around the JDK that
point to the old Collections techno
11 matches
Mail list logo
