Re: [PATCH] Enhancement proposal for TimSort and ComparableTimSort

2017-09-24 Thread Martin Buchholz
One learns to be sceptical of such special cases. Especially when so much effort was put into optimizing the original code. if (nRemaining < 2) return; // Arrays of size 0 and 1 are always sorted +//when array's size is 2 we just need to swap items +//if th

Re: RFR 8145635 : Add TCP_QUICKACK socket option

2017-09-24 Thread Chris Hegarty
Vyom, > On 11 Sep 2017, at 16:38, vyom tewari wrote: > > Hi All, > > As jdk.net API already moved out of java.base, Please review the below code > change for jdk10. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8145635 > Webrev: http://cr.openjdk.java.net/~vtewari/8145635/webrev0.1/index.

Re: RFR(m): 8177290 add copy factory methods for unmodifiable List, Set, Map

2017-09-24 Thread David Holmes
On 23/09/2017 6:37 AM, Stuart Marks wrote: On 9/22/17 5:36 AM, Roger Riggs wrote: BTW, I don't think many people are confused by 'immutable' collections appearing to be mutated because one of the objects in the collection is mutable. I'm sure *you* aren't confused by the issues. But I spend a