Re: RFR 8080225: FileInputStream cleanup should be improved

Hi Mandy, Updated the webrev in place:    http://cr.openjdk.java.net/~rriggs/webrev-fis-cleanup-8080225/ On 10/3/2017 7:17 PM, mandy chung wrote: Hi Roger, This looks good overall. 53 * unreachable should explicitly override {@link #finalize} and call {@code close}. Since finalize is depr

Review Request JDK-8188052: JNI_FindClass needs to specify the class loading context used for library lifecycle hooks

This patch separates the JNI `FindClass` issue from the review thread for JDK-8188052 [1] into a different issue. webrev: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8188052/webrev.00/index.html This patch changes `FindClass` to specify the class loading context used for the load and un

[10] RFR(S) 8188775: Module jdk.internal.vm.compiler.management has not been granted accessClassInPackage.org.graalvm.compiler.hotspot

https://bugs.openjdk.java.net/browse/JDK-8188775 Changes for 8182701[1] missed changes in default.policy for new module jdk.internal.vm.compiler.management. Add missing code: src/java.base/share/lib/security/default.policy @@ -154,6 +154,10 @@ permission java.security.AllPermission; };

Re: [10] RFR(S) 8188775: Module jdk.internal.vm.compiler.management has not been granted accessClassInPackage.org.graalvm.compiler.hotspot

+1 Mandy On 10/4/17 4:05 PM, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8188775 Changes for 8182701[1] missed changes in default.policy for new module jdk.internal.vm.compiler.management. Add missing code: src/java.base/share/lib/security/default.policy @@ -154,6 +154,

Re: [10] RFR(S) 8188775: Module jdk.internal.vm.compiler.management has not been granted accessClassInPackage.org.graalvm.compiler.hotspot

Thank you, Mandy Vladimir On 10/4/17 4:07 PM, mandy chung wrote: +1 Mandy On 10/4/17 4:05 PM, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8188775 Changes for 8182701[1] missed changes in default.policy for new module jdk.internal.vm.compiler.management. Add missing cod

[10] RFR(XS) 8188776: jdk.internal.vm.ci can't export package to upgradeable modules

https://bugs.openjdk.java.net/browse/JDK-8188776 8182701 added exports for jdk.vm.ci.runtime package [1] but did not add new exception in the test. Added missing exception in JdkQualifiedExportTest.java test: --- a/test/jdk/jdk/modules/etc/JdkQualifiedExportTest.java +++ b/test/jdk/jdk/modules

Re: [10] RFR(XS) 8188776: jdk.internal.vm.ci can't export package to upgradeable modules

+1 Looks like JDK regression tests were not run before pushing JDK-8182701? Mandy On 10/4/17 4:12 PM, Vladimir Kozlov wrote: https://bugs.openjdk.java.net/browse/JDK-8188776 8182701 added exports for jdk.vm.ci.runtime package [1] but did not add new exception in the test. Added missing exc

Re: Review Request JDK-8164512: Replace ClassLoader use of finalizer with phantom reference to unload native library

Updated webrev: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8164512/webrev.01/ JNI FindClass change has been separated from this patch [1]. I made further clean up to the NativeLibrary implementation and replaced the use of Vector/Stack.  I also added a native test to verify the native li

Re: [10] RFR(XS) 8188776: jdk.internal.vm.ci can't export package to upgradeable modules

Thank you, Mandy On 10/4/17 4:15 PM, mandy chung wrote: +1 Looks like JDK regression tests were not run before pushing JDK-8182701? Yes, only hotspot jtreg tests were run unfortunately before the push. We do run jdk_lang regularly in tier5 Nightly testing. Thanks, Vladimir Mandy On 10/4/

Re: Review Request JDK-8188052: JNI_FindClass needs to specify the class loading context used for library lifecycle hooks

Hi Mandy, On 5/10/2017 4:12 AM, mandy chung wrote: This patch separates the JNI `FindClass` issue from the review thread for JDK-8188052 [1] into a different issue. webrev: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8188052/webrev.00/index.html src/hotspot/share/prims/jni.cpp Okay .

Re: Review Request JDK-8164512: Replace ClassLoader use of finalizer with phantom reference to unload native library

Hi Mandy On 5/10/2017 9:24 AM, mandy chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8164512/webrev.01/ JNI FindClass change has been separated from this patch [1]. I made further clean up to the NativeLibrary implementation and replaced the use of Vector/Stack. 

Re: Review Request JDK-8188052: JNI_FindClass needs to specify the class loading context used for library lifecycle hooks

On 10/4/17 5:44 PM, David Holmes wrote: Hi Mandy, On 5/10/2017 4:12 AM, mandy chung wrote: This patch separates the JNI `FindClass` issue from the review thread for JDK-8188052 [1] into a different issue. webrev: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8188052/webrev.00/index.html

Re: Review Request JDK-8188052: JNI_FindClass needs to specify the class loading context used for library lifecycle hooks

Looks good. Thanks, David On 5/10/2017 12:09 PM, mandy chung wrote: On 10/4/17 5:44 PM, David Holmes wrote: Hi Mandy, On 5/10/2017 4:12 AM, mandy chung wrote: This patch separates the JNI `FindClass` issue from the review thread for JDK-8188052 [1] into a different issue. webrev: http:/

Re: Review Request JDK-8164512: Replace ClassLoader use of finalizer with phantom reference to unload native library

On 10/4/17 6:21 PM, David Holmes wrote: Hi Mandy On 5/10/2017 9:24 AM, mandy chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8164512/webrev.01/ JNI FindClass change has been separated from this patch [1]. I made further clean up to the NativeLibrary implementat

Re: Review Request JDK-8164512: Replace ClassLoader use of finalizer with phantom reference to unload native library

Hi Mandy, On 5/10/2017 3:14 PM, mandy chung wrote: On 10/4/17 6:21 PM, David Holmes wrote: Hi Mandy On 5/10/2017 9:24 AM, mandy chung wrote: Updated webrev: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8164512/webrev.01/ JNI FindClass change has been separated from this patch [1]. I made