Re: [10] RFR(S) 8188775: Module jdk.internal.vm.compiler.management has not been granted accessClassInPackage.org.graalvm.compiler.hotspot

2017-10-05 Thread Jaroslav Tulach
Opps. Sorry for causing the problem. I haven't executed the test in question and thus I thought everything is OK. Thanks Vladimir for creating the fix. -jt On středa 4. října 2017 16:05:33 CEST Vladimir Kozlov wrote: > https://bugs.openjdk.java.net/browse/JDK-8188775 > > Changes for 8182701[1]

Re: Review Request JDK-8164512: Replace ClassLoader use of finalizer with phantom reference to unload native library

2017-10-05 Thread mandy chung
Hi David, This version only modifies ClassLoader.java and the new test: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8164512/webrev.03/ On 10/4/17 11:06 PM, David Holmes wrote: Hi Mandy, Overall the changes seem fine, but I do have a concern about the use of ConcurrentHashMap. This would

Re: Review Request JDK-8164512: Replace ClassLoader use of finalizer with phantom reference to unload native library

2017-10-05 Thread David Holmes
Hi Mandy, On 6/10/2017 8:24 AM, mandy chung wrote: Hi David, This version only modifies ClassLoader.java and the new test: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8164512/webrev.03/ This seems mostly fine now - thanks for simplifying and clarifying the test operation. I agree we c