Re: Incorrect validation of DST in java.util.SimpleTimeZone

2017-11-11 Thread Peter Levart
Hi Venkateswara R Chintala, I would like to remind that TimeZone.clone() is also in the code path of java.time.ZoneId.systemDefault() where it was relied on to be optimized by JIT to never actually allocate the cloned TimeZone object by employing escape analysis. It would be nice to verify if

Re: Incorrect validation of DST in java.util.SimpleTimeZone

2017-11-11 Thread Peter Levart
Hi Venkat, On 11/10/17 13:07, Venkateswara R Chintala wrote: Hi, In a multi-threaded environment, when java.util.SimpleTimeZone object is used to create a default timezone, there can be a race condition between the methods java.util.Timezone.getDefault() and java.util.Timezone.getDefaultRef(

Re: Incorrect validation of DST in java.util.SimpleTimeZone

2017-11-11 Thread David Holmes
Hi Peter, On 11/11/2017 8:06 PM, Peter Levart wrote: Hi Venkateswara R Chintala, I would like to remind that TimeZone.clone() is also in the code path of java.time.ZoneId.systemDefault() where it was relied on to be optimized by JIT to never actually allocate the cloned TimeZone object by em

Re: RFR 8190974 Parallel stream execution within a custom ForkJoinPool should obey the parallelism

2017-11-11 Thread Stefan Zobel
In CustomFJPoolTest#testCustomPools() >>assertEquals(splitsForPC, splitsForPHalfC * 2); I'm sure I'm slow on the uptake, but isn't this bound to fail for every commonParallelism == 2^n + 1 in the closed range [2, 127], i.e., for 3, 5, 9, 17, 33, 65? Regards, Stefan 2017-11-08 22:01 GMT+01

Re: Incorrect validation of DST in java.util.SimpleTimeZone

2017-11-11 Thread Peter Levart
Hi David, On 11/11/17 13:37, David Holmes wrote: Hi Peter, On 11/11/2017 8:06 PM, Peter Levart wrote: Hi Venkateswara R Chintala, I would like to remind that TimeZone.clone() is also in the code path of java.time.ZoneId.systemDefault() where it was relied on to be optimized by JIT to never

Re: Incorrect validation of DST in java.util.SimpleTimeZone

2017-11-11 Thread Peter Levart
Hi David, Venkat, On 11/11/17 21:15, Peter Levart wrote: For example, take the following method: String defaultTZID() {     return TimeZone.getDefault().getID(); } When JIT compiles it and inlines invocations to other methods within it, it can prove that cloned TimeZone instance never escapes