Re: RFR [11] JDK-8179424: Remove terminally deprecated sun.reflect.Reflection.getCallerClass

2018-01-02 Thread Alan Bateman
On 22/12/2017 10:16, Chris Hegarty wrote: On 21/12/17 21:40, mandy chung wrote:  ... > ReflectionFactory or other class in sun.reflect package would do it. and create an issue to follow up sun.reflect.Reflection as flagged as a removed API. That’s what the test now does with my changes. Why s

Re: Adding SocketChannel toString to connection exception messages

2018-01-02 Thread Alan Bateman
On 29/12/2017 00:33, Steven Schlansker wrote: Thanks for the discussion! So, it sounds like amending the message by default is going to be a non-starter -- but at least adding the information otherwise might be possible. There are examples in other area where exceptions include detail informa

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-02 Thread Alan Bateman
On 22/12/2017 21:51, Brian Burkhalter wrote: https://bugs.openjdk.java.net/browse/JDK-8194133 http://cr.openjdk.java.net/~bpb/8194133/webrev.00/ Add jdk.internal.io.IOSupport with copy() methods for InputStream-to-OutputStream copying and modify some classes to use these new methods. One thin

Re: RFR: 8194154 patch for crash at File.getCanonicalPath()

2018-01-02 Thread Alan Bateman
On 25/12/2017 09:40, Wenqian Pei wrote: Hi: Bug: https://bugs.openjdk.java.net/browse/JDK-8194154 We found that if user defines -Duser.dir like "/home/a/b/c/", jvm will crash at  File.getCanonicalPath() in java process bootstrap (before invoking user's java code). The  native implematation of c

Re: Adding SocketChannel toString to connection exception messages

2018-01-02 Thread Steven Schlansker
On Dec 31, 2017, at 7:24 AM, Peter Levart wrote: > > Hi, >> >> I believe there are concerns with too much information that can be >> considered "sensitive" (like host names and IP addresses) appearing in error >> messages due to them ending up in log files and bug reports. >> >> David > > F

Re: RFR 8193842: Refactor InputStream-to-OutputStream copy into a utility method

2018-01-02 Thread Brian Burkhalter
On Jan 2, 2018, at 9:01 AM, Alan Bateman wrote: >> One thing that I noticed when looking at this is that in the fix for >> https://bugs.openjdk.java.net/browse/JDK-8193842, the Files.copy() method >> had a loop like >> >> while ((n = read(…)) > 0) >> >> whereas InputStream.transferTo() had >

Re: FileOutputStream.getFD() vs finalization

2018-01-02 Thread Hans Boehm
Thanks! I had missed the fact that FileDescriptor keeps a list of all owners. Apparently (1) closing a single File*Stream effectively closes all such Streams using the same FileDescriptor? And (2) whenever one such Stream is reachable they are all retained. Thus presumably none can be finalized un

回复:RFR: 8194154 patch for crash at File.getCanonicalPath()

2018-01-02 Thread Wenqian Pei
Can you please review this patch? Thanks in advance! Wenqian Pei --发件人:Alan Bateman 发送时间:2018年1月3日(星期三) 01:30收件人:裴文谦(右席) ; core-libs-dev 抄 送:陆传胜(传胜) ; 李三红(三红) 主 题:Re: RFR: 8194154 patch for crash at File.getCanonicalPath() On 2

RE: RFR [jdk8] : 8193807 : AIX: avoid UnsatisfiedLinkError by providing empty basic implementations of getSystemCpuLoad and getProcessCpuLoad

2018-01-02 Thread Evans, Martin
Hi Volker, Happy new year! Do you have a rough idea as to when it will make it into the regular update? Kind regards, Martin -Original Message- From: Volker Simonis [mailto:volker.simo...@gmail.com] Sent: 22 December 2017 16:25 To: Evans, Martin Cc: Baesken, Matthias ; jdk8u-dev-requ

Re: Adding SocketChannel toString to connection exception messages

2018-01-02 Thread Peter Levart
Hi Steven, Steven Schlansker je 02. 01. 2018 ob 22:25 napisal: On Jan 2, 2018, at 8:35 AM, Alan Bateman wrote: On 29/12/2017 00:33, Steven Schlansker wrote: Thanks for the discussion! So, it sounds like amending the message by default is going to be a non-starter -- but at least adding the