Hi Jason,
On 18/01/2018 21:19, Jason Mehrens wrote:
Daniel,
As long as the org.apache.juli.ClassLoaderLogManager overrides getProperty it
shouldn't really matter what the value format is in the file as long as it is
translated on return.
Is there a code path in j.u.l.LogManager that doesn't c
Hi,
this webrev adds a real test case for javapackager.
I also removed unused variable dontExecuteWithWrongFlags.
http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.03/
Feel free to use this change (webrev03) or
http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.02/
Hello,
Posting this to core-libs-dev.
Please review
http://cr.openjdk.java.net/~goetz/wr18/8195663-fixHelpTest/webrev.02/
which excludes the Oracle proprietary tools from the test.
I can not verify this.
Wouldn't a whitelist work better here than a blacklist? Other
distributions might add ot
Hi team,
In Sept 2009 Josh Bloch, Jon Bentley and I introduced new sorting
algorithm, Dual-Pivot Quicksort, for primitives in JDK 7 and later
I suggested several improvements of Dual-Pivot Quicksort, which
were integrated into JDK 8.
Now I have more optimized and faster version of Dual-Pivot Qui
Hi,
I understand the effects of a whitelist.
But the test is just intended to dig up tools that don't adhere
to the CSR.
It's easy enough to fix if you add a tool of yourself, as you
can see in this change.
Thanks for testing webrev 03.
Feel free to push it if it solves your problems in case it'
Hi,
For the record, I updated the JBS issue [1] with Jason's suggestion
and asked to get feedback from the submitter.
best regards,
-- daniel
[1] https://bugs.openjdk.java.net/browse/JDK-8195096
On 19/01/2018 10:13, Daniel Fuchs wrote:
Hi Jason,
On 18/01/2018 21:19, Jason Mehrens wrote:
Da
Hi Vipin,
A couple of suggestions to make working with serialization filters easier.
JEP 290 enabled logging of filtering actions by setting
java.io.serialization.level = FINEST.
Add that to the logging.properties and supply it on the command line with
"-Djava.util.logging.config.file=logging
Daniel,
Looking at:
https://github.com/apache/tomcat/blob/trunk/java/org/apache/juli/ClassLoaderLogManager.java
it looks like code in "readConfiguration(InputStream, ClassLoader)" does the
digit translation.
The tomcat developers should be able to move some of that code to
CLLM.getProperty to
Daniel,
Double check me on this but, I think I've found the source of why the error
occurs on JDK9 and not JDK8.
In https://bugs.openjdk.java.net/browse/JDK-8191033 the new code should have
been added to initializeGlobalHandlers. That would make the read of ".handers"
lazy and keep the read of
On 19/01/18 14:22, Daniel Fuchs wrote:
> Hi,
>
> For the record, I updated the JBS issue [1] with Jason's suggestion
> and asked to get feedback from the submitter.
Providing feedback, as requested.
Thanks for looking at this so quickly. The speedy response is appreciated.
I did look to try and
Hi Jason,
I'm afraid the issue is more subtle than that.
".handler" has never been handled lazily - it was also eagerly
called in 8.
What changes is that in JDK 9, in ensureLogManagerInitialized(),
I moved the creation of the RootLogger just before calling
the call to readPrimordialConfiguration
Hi Mark,
Would it be possible for you to call super.getProperty()
when you want to see the 'raw' value, and
this.getProperty() when you want to see the 'corrected'
value?
best regards,
-- daniel
On 19/01/2018 17:34, Mark Thomas wrote:
On 19/01/18 14:22, Daniel Fuchs wrote:
Hi,
For the recor
Hi Brian,
Looks good,
A pre-existing typo:
line 67 "{@code skip()}" should be "{@code skip(*long*)}".
Since the public readNBytes suffices for readAllBytes, I would rename
the private readAtMostNBytes
to readNBytes and avoid the duplication of javadoc.
Keeping the existing readAllBytes b
On 19/01/18 19:25, Daniel Fuchs wrote:
> Hi Mark,
>
> Would it be possible for you to call super.getProperty()
> when you want to see the 'raw' value, and
> this.getProperty() when you want to see the 'corrected'
> value?
Hi Daniel,
I see where you are coming from but I don't think so.
Jason ma
On 19/01/18 20:14, Mark Thomas wrote:
> Thanks to both of you for the hints that have got me thinking in new
> directions for a workaround.
Thanks again for the hints. I have a work-around that seems to work:
https://svn.apache.org/viewvc?view=revision&revision=1821708
It feels a bit hacky. I'
Not my call but adding addInitialRootLoggerHandlers() seems too much like a
private detail that would be forever published as part of the public API.
I would rather have have a protected reportError added to LogManager and
redirect all internal errors from directly calling System.err to that met
16 matches
Mail list logo
