Re: RFR: JDK-8144300 : Java does not honor http.nonProxyHosts value having wildcard * both at end and start

Hi, Looks reasonable to me. best regards, -- daniel On 01/03/2018 14:46, Pallavi Sonal wrote: Hi, Please review the following change to fix JDK-8144300. Bug : https://bugs.openjdk.java.net/browse/JDK-8144300 Webrev : http://cr.openjdk.java.net/~rpatil/8144300/webrev.00/ Whenever

Re: Java Float and Double changes, BigDecimal maths class, BigDecimal operators?

Le 06/03/2018 à 05:48, A Z a écrit : > Citation about problems with Java floating point: > https://people.eecs.berkeley.edu/~wkahan/JAVAhurt.pdf This paper is about complex numbers, operation overloading, handling of NaN, /etc./ I don't think that they are making an argument for decimal arithmeti

Re: RFR: 8197538 Remove mention of hotjava paths in MimeTable.java

On 05/03/18 21:32, Roger Riggs wrote: Please review a change to a location where mailcap entries may appear. The mention of "hotjava.home" is ancient history. BTW, if you know whether "user.mailcap" System property is used, I'd be interested if anyone is using it. I may need a CSR to make i

Re: RFR 8196298 Add null Reader and Writer with latest changes

On 05/03/2018 21:45, Patrick Reinhart wrote: I tried to incorporate all feedback I received so far and updated the webrev accordingly: http://cr.openjdk.java.net/~reinhapa/reviews/8196298/webrev.01 I think this looks good now. I

Re: RFR: JDK-8144300 : Java does not honor http.nonProxyHosts value having wildcard * both at end and start

Pallavi, On 01/03/18 14:46, Pallavi Sonal wrote: Hi, Please review the following change to fix JDK-8144300. Bug : https://bugs.openjdk.java.net/browse/JDK-8144300 Webrev : http://cr.openjdk.java.net/~rpatil/8144300/webrev.00/ Looks ok to me. Please add the bugId to the @bug tag in the

Re: RFR 8196298 Add null Reader and Writer with latest changes

Updated the CSR API with webrev's content and finalized it.. -Patrick Am 06.03.2018 um 17:35 schrieb Alan Bateman: > On 05/03/2018 21:45, Patrick Reinhart wrote: >> I tried to incorporate all feedback I received so far and updated the >> webrev accordingly: >> >> http://cr.openjdk.java.net/~reinh

Re: RFR 8196298 Add null Reader and Writer with latest changes

Just a nit, Should append(CharSequence,int,int) also use checkFromIndexSize? Greetings Bernd -- http://bernd.eckenfels.net Von: Alan Bateman Gesendet: Dienstag, 6. März 2018 20:35 An: Patrick Reinhart; core-libs-dev Betreff: Re: RFR 8196298 Add null Reader and Writer with latest changes On 05/0

RFR(XS) [closed] : 8198924: java/lang/StackWalker/LocalsAndOperands.java timeouts with Graal

Hi all, java/lang/StackWalker/LocalsAndOperands.java runs LocalsAndOperands 3 times with following set of jvm flags: 1) -Xint -DtestUnused=true 2) -Xcomp 3) -Xcomp -XX:-TieredCompilation When running with Graal as JIT (-XX:+TieredCompilation -XX:+UseJVMCICompiler -Djvmci.Compiler=graal) 3rd

Re: RFR(XS) [closed] : 8198924: java/lang/StackWalker/LocalsAndOperands.java timeouts with Graal

Running #1 and #2 when Graal is enabled is fine. For the second @test, does it need @bug and @summary to run?  If not, I suggest to take it out as it's already mentioned in the first @test. Mandy On 3/6/18 1:45 PM, Ekaterina Pavlova wrote: Hi all, java/lang/StackWalker/LocalsAndOperands.ja

Re: RFR 8196298 Add null Reader and Writer with latest changes

Yes, I think so and and also the parameter ‘csq' is allowed to be null so Objects.requireNonNull(csq) should be removed at lines 100 and 107 as no NPE is specified for these methods [1, 2]. Thanks, Brian [1] https://download.java.net/java/jdk10/docs/api/java/io/Writer.html#append(java.lang.Ch

Re: RFR(XS) [closed] : 8198924: java/lang/StackWalker/LocalsAndOperands.java timeouts with Graal

Looks good, Katya - thanks. I agree with omitting @bug and @summary from the second @test tag. Thanks, -Brent On 3/6/18 1:59 PM, mandy chung wrote: Running #1 and #2 when Graal is enabled is fine. For the second @test, does it need @bug and @summary to run?  If not, I suggest to take it out a

core-libs-dev Digest, Vol 131, Issue 26

-Whenever there there is an arithmetic continuing carry operation involving Java Float or Double, there can be an underflow or overflow. This means that comparisons at the data level using >, ==,<,<=.>=, .equals(), etc. will begin to misbehave. Whatever the behind the scenes implementation, th

Re: core-libs-dev Digest, Vol 131, Issue 26

"A Z", Can you please post using appropriate subject lines, and formatting and follow basic email etiquette - which includes identifying yourself. You are quoting 20 year old papers. The JavaGrande effort was born in 1998 and died a few years later. David On 7/03/2018 9:38 AM, A Z wrote:

Re: [11] RFR: 4993841: (str) java.lang.Character should have a toString(int) method

Hi Naoto, Thanks for fixing the original issue, and for filing the cleanup followup bug. s'marks On 3/3/18 9:30 AM, naoto.s...@oracle.com wrote: Hi Stuart, Filed an issue for the cleanup: https://bugs.openjdk.java.net/browse/JDK-8198989 Naoto On 3/2/18 5:50 PM, Stuart Marks wrote: Looks

Re: GetPrimitiveArrayCritical vs GetByteArrayRegion: 140x slow-down using -Xcheck:jni and java.util.zip.DeflaterOutputStream

Thanks Ian and Sherman for the excellent presentation and memories of ancient efforts. Yes, Sherman, I still have vague memory that attempts to touch any implementation detail in this area was asking for trouble and someone would complain. I was happy to let you deal with those problems! There's

Java SE Language Changes

from Zachary Mitchell ... 'But you seem to be alone on that score.' -People have in fact just quit on this with one language in time. That doesn't mean that valid points don't continue to exist, and mending changes shouldn't happen. I am in fact quite far from alone. 'Basic Java arithmetic won