Re: RFR: 8195717: test java/lang/invoke/MethodHandlesTest timed out running testAsCollector1

2018-05-01 Thread Paul Sandoz
+1 Thank you for splitting out the all tests marked as slow, this should help reduce the possibility of timeouts when running with certain HotSpot options. Paul. > On May 1, 2018, at 4:38 AM, Vivek Theeyarath > wrote: > > Hi All, > > > > Please review fix for

[11] RFR (XS): 8202484: Unused field in TimeZone

2018-05-01 Thread Naoto Sato
Hi, Please review this cleanup in TimeZone class, where an unused field is removed. Naoto -- diff -r 7fed08d588b5 src/java.base/share/classes/java/util/TimeZone.java --- a/src/java.base/share/classes/java/util/TimeZone.java +++ b/src/java.base/share/classes/java/util/TimeZone.java @@ -1,5

Re: [11] RFR (XS): 8202484: Unused field in TimeZone

2018-05-01 Thread Lance Andersen
+1 > On May 1, 2018, at 2:25 PM, Naoto Sato wrote: > > mainAppContextDefault

Re: 8202507: Remove IO and NIO AtomicAppend tests from problem list

2018-05-01 Thread Lance Andersen
+1 > On May 1, 2018, at 4:57 PM, Brian Burkhalter > wrote: > > Please review this simple fix for [1]. Somehow this did not make it into the > patch I checked in to fix [2]. > > Thanks, > > Brian > > [1] https://bugs.openjdk.java.net/browse/JDK-8202507 > [2]

8202507: Remove IO and NIO AtomicAppend tests from problem list

2018-05-01 Thread Brian Burkhalter
Please review this simple fix for [1]. Somehow this did not make it into the patch I checked in to fix [2]. Thanks, Brian [1] https://bugs.openjdk.java.net/browse/JDK-8202507 [2] https://bugs.openjdk.java.net/browse/JDK-8202284 --- a/test/jdk/ProblemList.txt +++ b/test/jdk/ProblemList.txt @@

Re: RFR(JDK11/NIO) 8202285: (fs) Add a method to Files for comparing file contents

2018-05-01 Thread Joe Wang
Thanks John for the background and detailed information. -Joe On 4/30/2018 6:18 PM, John Rose wrote: On Apr 30, 2018, at 4:47 PM, Joe Wang > wrote: Are there real-life use cases? It may be useful for example to check if the files have

Re: Hashing files/bytes Re: RFR(JDK11/NIO) 8202285: (fs) Add a method to Files for comparing file contents

2018-05-01 Thread forax
- Mail original - > De: "Paul Sandoz" > À: "Remi Forax" > Cc: "Alan Bateman" , "nio-dev" > , "core-libs-dev" > > Envoyé: Mardi 1 Mai 2018 00:37:57 > Objet:

Re: Hashing files/bytes Re: RFR(JDK11/NIO) 8202285: (fs) Add a method to Files for comparing file contents

2018-05-01 Thread John Rose
Here's another potential stacking: Define an interface ByteSequence, similar to CharSequence, as a zero-copy reference to some stored bytes somewhere. (Give it a long length.) Define bulk methods on it like hash and mismatch and transferTo. Then make File and ByteBuffer implement it. Deal with

RFR 8202086 : Improve performance characteristics of sun.security.util.MemoryCache

2018-05-01 Thread Ivan Gerasimov
Hello! This enhancement was generously contributed by Peter Levart [1]. The original webrev is found here [2]. The goal was to improve concurrent accessibility of the cache, while maintaining some additional limitations dictated by the spec. Would you please help review this fix? BUGURL:

RFR: 8195717: test java/lang/invoke/MethodHandlesTest timed out running testAsCollector1

2018-05-01 Thread Vivek Theeyarath
Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8195717 . http://cr.openjdk.java.net/~vtheeyarath/8195717/webrev.02/ The test class has been re factored into multiple classes with the existing MethodHandlesTest.java being made abstract. Testing Done: