Hi all,
- Mail original -
> De: "Alan Bateman"
> À: "David Holmes" , "core-libs-dev"
>
> Envoyé: Mardi 15 Mai 2018 15:53:44
> Objet: Re: [core-libs] RFR (L): 8010319: Implementation of JEP 181:
> Nest-Based Access Control
> On 15/05/2018 01:52, David Holmes wrote:
>> This review is be
Hi David,
Good catch. Copying to the Hotspot list.
Best Regards
Adam Farley
OpenJDK Team
Runtimes
IBM
From: David Holmes
To: Adam Farley8 , core-libs-dev
Date: 16/05/2018 22:32
Subject:Re: Bug Request: Please remove out-of-date files from bug
Done.
Though you sent
Hi Remi,
On 17/05/2018 6:16 PM, Remi Forax wrote:
Hi all,
- Mail original -
De: "Alan Bateman"
À: "David Holmes" , "core-libs-dev"
Envoyé: Mardi 15 Mai 2018 15:53:44
Objet: Re: [core-libs] RFR (L): 8010319: Implementation of JEP 181: Nest-Based
Access Control
On 15/05/2018 01:52
Paul, Alan,
Just a quick thank you for taking a look at this so soon. I will respond
to both of you as soon as practical.
Thanks,
David
On 17/05/2018 4:00 AM, Paul Sandoz wrote:
HI,
Nice thorough work on this, surprisingly tricky in some areas esp. MHs.
Class
—
3857 * If there is any
- Mail original -
> De: "David Holmes"
> À: "Remi Forax" , "Alan Bateman"
> Cc: "core-libs-dev"
> Envoyé: Jeudi 17 Mai 2018 10:37:46
> Objet: Re: [core-libs] RFR (L): 8010319: Implementation of JEP 181:
> Nest-Based Access Control
> Hi Remi,
Hi David
>
> On 17/05/2018 6:16 PM, Rem
Clarification ...
On 17/05/2018 6:37 PM, David Holmes wrote:
Hi Remi,
On 17/05/2018 6:16 PM, Remi Forax wrote:
Hi all,
- Mail original -
De: "Alan Bateman"
À: "David Holmes" , "core-libs-dev"
Envoyé: Mardi 15 Mai 2018 15:53:44
Objet: Re: [core-libs] RFR (L): 8010319: Implementati
Shouldn't this be called "Faster rounding up to nearest power of two"?
Patch looks OK to me, but I'd like to see numbers with the
numberOfLeadingZeros intrinsic
disabled so that we ensure we're not incurring an unreasonable penalty
on platforms who don't
have an intrinsic for this.
Running yo
On 17/05/2018 9:07 PM, Claes Redestad wrote:
Shouldn't this be called "Faster rounding up to nearest power of two"?
Patch looks OK to me, but I'd like to see numbers with the
numberOfLeadingZeros intrinsic
disabled so that we ensure we're not incurring an unreasonable penalty
on platforms who
On 2018-05-17 13:15, David Holmes wrote:
diff -r de35abdfe5da src/java.base/share/classes/java/lang/Integer.java
--- a/src/java.base/share/classes/java/lang/Integer.java Mon May 14
16:21:08 2018 +0200
+++ b/src/java.base/share/classes/java/lang/Integer.java Thu May 17
12:44:53 2018 +0200
@@
On 17/05/2018 9:24 PM, Claes Redestad wrote:
On 2018-05-17 13:15, David Holmes wrote:
diff -r de35abdfe5da src/java.base/share/classes/java/lang/Integer.java
--- a/src/java.base/share/classes/java/lang/Integer.java Mon May 14
16:21:08 2018 +0200
+++ b/src/java.base/share/classes/java/lang/Integ
Yup, I missed FLAG_EFS.
diff --git a/src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipConstants.java
b/src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipConstants.java
--- a/src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipConstants.java
+++ b/src/jdk.zipfs/share/classes/jdk/nio/zipfs/ZipConstants.java
@@ -47,
> On May 17, 2018, at 4:07 AM, Claes Redestad wrote:
>
> Shouldn't this be called "Faster rounding up to nearest power of two"?
>
> Patch looks OK to me, but I'd like to see numbers with the
> numberOfLeadingZeros intrinsic
> disabled so that we ensure we're not incurring an unreasonable pena
On 05/17/2018 07:07 AM, Claes Redestad wrote:
> Shouldn't this be called "Faster rounding up to nearest power of two"?
>
> Patch looks OK to me, but I'd like to see numbers with the
> numberOfLeadingZeros intrinsic
> disabled so that we ensure we're not incurring an unreasonable penalty
> on platf
Hi all,
I have a new version of the code for your consideration:
http://cr.openjdk.java.net/~tonyp/8202788/webrev.1/
I basically combined our two approaches. The usage is as Alan had proposed
it: Users have to use JdkThreadLocal (which is only available within
java.base) and override threadTermi
2018/5/16 18:31:15 -0700, marti...@google.com:
> I've been confused by NULL vs null for years.
That’s because `NULL` in ReferenceQueue.java refers to the singleton
object `ReferenceQueue.NULL`, not the null value. See the long comment
at the top of Reference.java for an explanation.
To improve t
Hi,
Please review the changes to the subject issue:
https://bugs.openjdk.java.net/browse/JDK-8202088
The proposed change is located at:
http://cr.openjdk.java.net/~naoto/8202088/webrev.01/
This is the implementation part of the upcoming Japanese new era,
starting from May 1st, 2019. Current
Hi Tony,
If we anticipate only small number of JdkThreadLocal(s) (there will be
only one for the start) then this is a plausible solution. Then perhaps
this limitation should be written somewhere in the JdkThreadLocal
javadoc so that one day somebody will not be tempted to use
JdkThreadLocal(
Thank you Claes for your review and the detailed analysis!
On 5/17/18 4:07 AM, Claes Redestad wrote:
Shouldn't this be called "Faster rounding up to nearest power of two"?
Yes, it's more accurate.
Patch looks OK to me, but I'd like to see numbers with the
numberOfLeadingZeros intrinsic
disa
“isBlank" was primarily chosen because isBlank has been the name used in Apache
StringUtils for the last fifteen years. The fact that Excel and Kotlin use
isBlank as well might have influenced the choice. Not many other languages have
the isBlank concept, usually requiring several method calls t
The java.time change seems OK to me
Stephen
On 17 May 2018 at 21:31, Naoto Sato wrote:
> Hi,
>
> Please review the changes to the subject issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8202088
>
> The proposed change is located at:
>
> http://cr.openjdk.java.net/~naoto/8202088/webrev.01/
>
>
I owe all of you replies on this, but I don't have time to continue the
discussion, and I suspect you all want to get on with things.
Let me have a quick chat with Paul tomorrow and then I'll propose a path
forward.
s'marks
21 matches
Mail list logo
