Re: RFR: jsr166 jdk integration 2018-05

On 23/05/2018 4:40 PM, Martin Buchholz wrote: On Tue, May 22, 2018 at 3:41 PM, joe darcy wrote: The specification of CME is not sacrosanct. We can and do evolve the specification of types all the time, even ones that have been in the platform for many years. We certainly have constraints on t

RFR: CSR JDK-8203630 Add instance method equivalents for String::format

csr: https://bugs.openjdk.java.net/browse/JDK-8203630

ServiceLoader.load(Class, ClassLoader) does not load services exposed in modules and loaded by parent CL

Hi, I stumbled on a problem of a maven plugin that uses JDK's JavaScript engine and doesn't work when maven is run with JDK 9 or 10. The code in plugin to initialize the JavaScript engine is as follows:     jsEngine = new ScriptEngineManager().getEngineByName("JavaScript");

Re: RFR: 81820709 - Container Awareness JEP

Hi Mandy, I’m finally getting back to your review of this change now that we’ve made some progress on creating tests. BTW: This Jira issue is now an RFE rather than a JEP (https://bugs.openjdk.java.net/browse/JDK-8203357 ) See comments below .

Re: ServiceLoader.load(Class, ClassLoader) does not load services exposed in modules and loaded by parent CL

On 23/05/2018 15:29, Peter Levart wrote: : Maven seems to load plugins in a child class loader of the "system" (application) class loader and also sets this class loader as thread context class loader. ServiceLoader does not find any ScriptEngineFactory services when using this class loader.

Re: ServiceLoader.load(Class, ClassLoader) does not load services exposed in modules and loaded by parent CL

On 05/23/2018 05:08 PM, Alan Bateman wrote: On 23/05/2018 15:29, Peter Levart wrote: : Maven seems to load plugins in a child class loader of the "system" (application) class loader and also sets this class loader as thread context class loader. ServiceLoader does not find any ScriptEngine

Re: ServiceLoader.load(Class, ClassLoader) does not load services exposed in modules and loaded by parent CL

On 05/23/2018 05:39 PM, Peter Levart wrote: On 05/23/2018 05:08 PM, Alan Bateman wrote: On 23/05/2018 15:29, Peter Levart wrote: : Maven seems to load plugins in a child class loader of the "system" (application) class loader and also sets this class loader as thread context class loader

Re: ServiceLoader.load(Class, ClassLoader) does not load services exposed in modules and loaded by parent CL

On 23/05/2018 16:39, Peter Levart wrote: I thought so. This is what debugger told be me about TCCL (debugger calls .toString() on it by default): ClassRealm[plugin>com.marand.misc:misc-mojo-git:1.24, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@1de0aca6] But now that you asked s

RFR: implementation for JEP 334: JVM Constants API

Hi all, Please review the proposed implementation for JEP 334 [1]. The webrev can be found at [2] and the javadoc at [3]. Thanks, Vicente [1] https://bugs.openjdk.java.net/browse/JDK-8203252 [2] http://cr.openjdk.java.net/~vromero/constant.api/webrev.07/constants.api.patch [3] http://cr.ope

Re: ServiceLoader.load(Class, ClassLoader) does not load services exposed in modules and loaded by parent CL

On 05/23/18 19:04, Alan Bateman wrote: On 23/05/2018 16:39, Peter Levart wrote: I thought so. This is what debugger told be me about TCCL (debugger calls .toString() on it by default): ClassRealm[plugin>com.marand.misc:misc-mojo-git:1.24, parent: jdk.internal.loader.ClassLoaders$AppClassL

Re: RFR: CSR JDK-8203630 Add instance method equivalents for String::format

Please, don't call it format too ! Trying to do a :: on a class with instance methods and static methods with the same doesn't work well, and format() being a varargs will not help. I see several reasons to not introduce this method whatever its name (interpolate ?), - String.format is very slow

Re: RFR: CSR JDK-8203630 Add instance method equivalents for String::format

On May 23, 2018, at 2:07 PM, Remi Forax wrote: > > Please, don't call it format too ! > Trying to do a :: on a class with instance methods and static methods with > the same doesn't work well, and format() being a varargs will not help. > > I see several reasons to not introduce this method wha

RFR(s): 8201518 add test for randomized iteration order of unmodifiable Set and Map

Hi all, Please review this new test for testing the randomized iteration order of unmodifiable Set and Map implementations. Bug: https://bugs.openjdk.java.net/browse/JDK-8201518 Webrev: http://cr.openjdk.java.net/~smarks/reviews/8201518/webrev.0/ Thanks, s'marks

RFR (trivial): 8203769: ProblemList test/jdk/java/util/Map/InPlaceOpsCollisions.java

Please approve ProblemListing this test until JDK-8203387 is fixed as it is causing a lot of noise in the CI test results. Thanks, David -- bug: https://bugs.openjdk.java.net/browse/JDK-8203769 diff -r 5e7174bf1259 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt +++ b/test/jdk/Pro

Re: RFR (trivial): 8203769: ProblemList test/jdk/java/util/Map/InPlaceOpsCollisions.java

Hi David, looks good and quite trivial. ..Thomas On Thu, May 24, 2018 at 4:46 AM, David Holmes wrote: > Please approve ProblemListing this test until JDK-8203387 is fixed as it is > causing a lot of noise in the CI test results. > > Thanks, > David > -- > > bug: https://bugs.openjdk.java.net

Re: RFR (trivial): 8203769: ProblemList test/jdk/java/util/Map/InPlaceOpsCollisions.java

Thanks Thomas! David On 24/05/2018 2:58 PM, Thomas Stüfe wrote: Hi David, looks good and quite trivial. ..Thomas On Thu, May 24, 2018 at 4:46 AM, David Holmes wrote: Please approve ProblemListing this test until JDK-8203387 is fixed as it is causing a lot of noise in the CI test results. T

Re: RFR: implementation for JEP 334: JVM Constants API

I think using FieldTypeDescriptor is misleading. since that is used for param types and return types. I propose SimpleTypeDescriptor or VariableTypeDescriptor. On Wed, May 23, 2018 at 11:11 PM, Vicente Romero wrote: > Hi all, > > Please review the proposed implementation for JEP 334 [1]. The web