Re: [12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Thank you, Lance Regards, Chris > On 27 Jul 2018, at 11:57 PM, Lance Andersen wrote: > > Hi Chris, > > This the change is fine >> On Jul 27, 2018, at 4:42 AM, Chris Yin > > wrote: >> >> Please review below minor change to add missing module dependencies >> declara

Re: [12] RFR 8208363: test/jdk/java/lang/Package/PackageFromManifest.java missing module dependencies declaration

Thank you, Mandy Regards, Chris > On 28 Jul 2018, at 12:02 AM, mandy chung wrote: > > Looks fine. This test uses JarUtils instead of jar tool and so > it does not depend on jdk.jar. > > Mandy > > On 7/27/18 1:42 AM, Chris Yin wrote: >> Please review below minor change to add missing module d

Re: [12] RFR 8208279: Add 8 JNDI tests to com/sun/jndi/dns/EnvTests/

Please find the new webrev as below, it addressed some similar issues which mentioned in review comments from another thread RFR 8200151, thanks webrev: http://cr.openjdk.java.net/~xyin/8208279/webrev.01/ Regards, Chris > On 26 Jul 2018, at