Re: Arrays.asList returned List - Its modifying/write-through semantics

2018-08-16 Thread Jaikiran Pai
Hi Ivan, On 15/08/18 4:27 PM, Jaikiran Pai wrote: > Hi Ivan, > > > On 15/08/18 1:20 PM, Ivan Gerasimov wrote: >> Hi Jaikiran! >> >> The first part (the documentation clarification) was requested some >> time ago [1], so it may be eventually fixed. >> >> [1] https://bugs.openjdk.java.net/browse/JDK

Re: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)

2018-08-16 Thread Adam Farley8
Hi Mandy, I request that you review this for 8u. -- @@ -1398,10 +1398,18 @@ bundle = baseBundle; } +keepAlive(loader); return bundle; } /** + * Keeps the argument ClassLoader alive. + */

Re: RFR(XXS) : 8209386 : [error-prone] StreamResourceLeak in jdk.internal.ed module

2018-08-16 Thread Roger Riggs
Hi Igor, Looks fine. Thanks for the fix,  Roger On 8/10/18 4:44 PM, Igor Ignatyev wrote: http://cr.openjdk.java.net/~iignatyev//8209386/webrev.00/index.html 4 lines changed: 1 ins; 0 del; 3 mod; Hi all, could you please review this small fix for the error detected in jdk.internal.ed by err

Re: Arrays.asList returned List - Its modifying/write-through semantics

2018-08-16 Thread Roger Riggs
Hi Jaikiran, Improving the documentation of the current behavior would be a good contribution and first step.  It will need a CSR since it needs to be checked that it accurately describes the behavior but that will be pretty straightforward once the change is reviewed. Note that Collection.r

Re: RFR JDK-8209553: ExceptionInInitializerError can have a default detail message if the cause is given

2018-08-16 Thread mandy chung
On 8/15/18 11:00 PM, David Holmes wrote: Hi Mandy, Not a review - sorry :) On 16/08/2018 7:46 AM, mandy chung wrote: ExceptionInInitializerError(Throwable cause) sets the detail message to null.  It'd be helpful to include a detail message rather than null as in Throwable(Throwable cause)

Re: RFR 8209184: JDK8 ResourceBundle vulnerable to GC (fix included)

2018-08-16 Thread mandy chung
On 8/16/18 2:16 AM, Adam Farley8 wrote: Hi Mandy, I request that you review this for 8u. -- @@ -1398,10 +1398,18 @@          bundle = baseBundle;      } +    keepAlive(loader);      return bundle;  }  /** + * Keeps the argument Class

Re: RFR JDK-8209553: ExceptionInInitializerError can have a default detail message if the cause is given

2018-08-16 Thread David Holmes
On 17/08/2018 1:18 AM, mandy chung wrote: On 8/15/18 11:00 PM, David Holmes wrote: Hi Mandy, Not a review - sorry :) On 16/08/2018 7:46 AM, mandy chung wrote: ExceptionInInitializerError(Throwable cause) sets the detail message to null.  It'd be helpful to include a detail message rather th

Re: RFR JDK-8209553: ExceptionInInitializerError can have a default detail message if the cause is given

2018-08-16 Thread joe darcy
Hello, On 8/15/2018 5:10 PM, mandy chung wrote: On 8/15/18 3:20 PM, Peter Levart wrote: Hi Mandy, Just a question. Why does "private Throwable exception" field in ExceptionInInitializerError exist? Was it there before there was a "cause" in Throwable and later still remained there because

Re: RFR JDK-8209553: ExceptionInInitializerError can have a default detail message if the cause is given

2018-08-16 Thread mandy chung
On 8/16/18 4:48 PM, joe darcy wrote: Just a question. Why does "private Throwable exception" field in ExceptionInInitializerError exist? Was it there before there was a "cause" in Throwable and later still remained there because of serialization format? Would it be possible to "simulate" its

Compile Error

2018-08-16 Thread mr rupplin
Spot what's the issue here: Compiling 4 files for BUILD_JIGSAW_TOOLS Error occurred during initialization of VM java.lang.NullPointerException at jdk.internal.misc.VM.saveAndRemoveProperties(java.base/VM.java:176) at java.lang.System.initPhase1(java.base/System.java:802) >> make/

Re: Arrays.asList returned List - Its modifying/write-through semantics

2018-08-16 Thread Stuart Marks
On 8/16/18 1:38 AM, Jaikiran Pai wrote: [1] https://bugs.openjdk.java.net/browse/JDK-7033681 Is this JIRA/change, something that I can contribute? If so, what would be the typical process for that? I have signed and approved OCA, but I don't know what's involved in submitting changes which i

Re: Compile Error

2018-08-16 Thread David Holmes
Max, On 17/08/2018 11:34 AM, mr rupplin wrote: Spot what's the issue here: Compiling 4 files for BUILD_JIGSAW_TOOLS Error occurred during initialization of VM java.lang.NullPointerException at jdk.internal.misc.VM.saveAndRemoveProperties(java.base/VM.java:176) at java.lang.Sys

RFR: 8209465: [TESTBUG] Fix jtreg test cases of jdk about file name too long in AUFS file system

2018-08-16 Thread Yang Zhang
Hi, Could you please help review the fix to jtreg test cases in jdk? java/io/File/DeleteOnExitLong.java java/io/File/MaxPathLength.java The failure happens in Linux AUFS file system. The maximum file name length in AUFS is 242. JBS: https://bugs.openjdk.java.net/browse/JDK-8209465 Webre