Re: RFR: JDK-8205461 Create Collector which merges results of two other collectors

2018-08-19 Thread Tagir Valeev
Hello, Peter! Yes, I would be happy, though see also Roger note. > Regarding the code, I only have one comment about the naming of the last parameter: "finisher" Sounds reasonable, renamed to "merger". > ...and one comment about handling of IDENTITY_FINISH I think this would complicate the cod

Re: RFR: JDK-8205461 Create Collector which merges results of two other collectors

2018-08-19 Thread Tagir Valeev
Hello, Brian! > Of the three phases, teeing is the most important and least obvious, so > I think something that includes that in the name is going to be > helpful. Perhaps "teeingAndThen" is more evocative and not totally > unwieldy. Ok, sounds acceptable to me. Renamed pairing to teeingAndThen

RFR: JDK-8176553 LdapContext follows referrals infinitely ignoring set limit

2018-08-19 Thread vyom tewari
Hi, Please review the below  code change. Webrev : http://cr.openjdk.java.net/~vtewari/8176553/webrev0.0/index.html bugid    : https://bugs.openjdk.java.net/browse/JDK-8176553 Our  all internal tests are clean, this patch is contributed by Jan Kalina(Redhat). Thanks, Vyom