Re: Compact Number Formatting and Fraction Digits

Aaah, ok, so I *only* must call setMaximumFractionDigits(). That's the part I had missed so far; thanks! --Gunnar Am Fr., 18. Jan. 2019 um 00:35 Uhr schrieb Scott Palmer : > > > On Jan 17, 2019, at 2:22 PM, Gunnar Morling wrote: > > >> since you don’t actually want a minimum. > > > > I'd like to

Re: Jpackage Windows shortcuts

odd, fwiw I didn't have that problem with --create-installer exe. Possibly because I'm doing --create-image as a separate first step? The space-squashing actually happens in that step, and then before either --create-installer I put the spaces back into the exe and cfg filenames ... but possibl

Re: Jpackage Windows shortcuts

FWIW uninstall working for me from Windows 10's "Apps & features" panel. Could it be doing something different when done from "Add/Remove Programs"? And (wild guessing) might that be related to the known bug about old versions not being uninstalled properly during upgrade?

Re: [13] RFR: 8216969: ParseException thrown for certain months with russian locale

Looks Good. Regards, Nishit Jain On 17-01-2019 22:07, Naoto Sato wrote: Hi Nishit, Thanks. Updated: http://cr.openjdk.java.net/~naoto/8216969/webrev.01/ Naoto On 1/17/19 2:57 AM, Nishit Jain wrote: Hi Naoto, Looks good to me. Just a small suggestion. - To improve readability, can we decla

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

Hi Roger, Naoto, > The size of Integer.MAX_VALUE - 2 is implementation specific, I think more typically max -8 is used to get the biggest allocation. When Integer.MAX_VALUE - 8 is used, the decode methods do not throw the added OOME, because the computed value does not overflow Integer.MAX_VAL

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation (update 2)

On 2019-01-17 16:06, Andy Herrick wrote: If I remove the line -nologo from lib-jdk.jpackage.gmk: 69 LDFLAGS_windows := -nologo, \ I get the logo during build (same with console andnon-console version): Microsoft (R) Incremental Linker Version 14.12.25835.0 Copyright (C) Microsoft Corp

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

On 17/01/2019 14:27, Andrew Dinn wrote: : Vladimir and I have reviewed the JEP, it will need an area lead to endorse, I think it can be Brian or Mikael in this case. Ok, thanks for the above answers. Looking forward to hearing further from Brian and/or Mikael (Vidstedt, I assume? :-). I had a b

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

Hi Alan, On 1/18/19 2:32 PM, Alan Bateman wrote: On 17/01/2019 14:27, Andrew Dinn wrote: : Vladimir and I have reviewed the JEP, it will need an area lead to endorse, I think it can be Brian or Mikael in this case. Ok, thanks for the above answers. Looking forward to hearing further from Bria

RFR: JDK-8217269: jpackage Makefile improvments

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes all the jpackage Makefile Improvements listed in [1], other than what is covered by [4], and also includes fix for white space err

Re: RFR: 8207851 JEP Draft: Support ByteBuffer mapped over non-volatile memory

On 1/18/19 3:11 PM, Peter Levart wrote: You meant package-private constructor, right? Protected constructor would allow subclassing MapMode by arbitrary user class which is not what would be desirable. ...unless you actually want users to construct their own MapMode(s), like you mentioned

Re: RFR 8213031: (zipfs) Add support for POSIX file permissions

On 12/01/2019 13:02, Langer, Christoph wrote: Hi Alan, as I did not hear back from you I continued to work on the POSIX file permission support for zipfs and specified/implemented the value of 'null' for zip entries with no permission information associated (vs. UnsupportedOperationException)

Re: jpackage OS X minimum OS version

> On Jan 17, 2019, at 8:37 AM, Michael Hall wrote: > > It appears there is a minimum OS version? I created a toy app. From command > line… > > open outputdir/TestApp.app > LSOpenURLsWithRole() failed with error -10825 for the file > /Users/mjh/HalfPipe/Test/outputdir/TestApp.app. > > Doubl

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

Hi Nishit, Looks good, with a minor fix. ok, the rationale for MAX_VALUE-2 make sense. TestEncodingDecodingLength: Line 61 and 68,   The error message will be more readable with a ": " before the methodname is appended. Thanks, Roger On 01/18/2019 06:03 AM, Nishit Jain wrote: Hi Roger, Na

Re: jpackage OS X minimum OS version

> On Jan 18, 2019, at 9:09 AM, Michael Hall wrote: > > > >> On Jan 17, 2019, at 8:37 AM, Michael Hall wrote: >> >> It appears there is a minimum OS version? I created a toy app. From command >> line… >> >> open outputdir/TestApp.app >> LSOpenURLsWithRole() failed with error -10825 for th

RFR(JDK 13/java.xml) 8206132: DOM parser does not honor DocumentBuilderFactory.setExpandEntityReferences(false)

Please review a change to the DOM parser so that it complies with the specification with regard to the ExpandEntityReferences feature. This change corrects the behavior so that the resulting DOM tree includes EntityReference nodes but not the expanded Text nodes when the feature is off. It als

Re: Jpackage Windows shortcuts

Add/Remove programs is called Apps & Features now, I guess. So we are in the same place. I’m going to reboot, as I have a Windows update to install anyway.. I think maybe the msi database is very confused. Scott > On Jan 18, 2019, at 3:59 AM, Rachel Greenham wrote: > > FWIW uninstall worki

Re: RFR(JDK 13/java.xml) 8206132: DOM parser does not honor DocumentBuilderFactory.setExpandEntityReferences(false)

Please hold on reviewing the webrevs as the tests passed while the new tests were commented out as Lance pointed out. Thanks, Joe On 1/18/19, 10:05 AM, Joe Wang wrote: Please review a change to the DOM parser so that it complies with the specification with regard to the ExpandEntityReferences

Re: Jpackage Windows shortcuts

For there record, a reboot fixed my uninstall issues. Scott > On Jan 18, 2019, at 1:18 PM, Scott Palmer wrote: > > Add/Remove programs is called Apps & Features now, I guess. So we are in > the same place. I’m going to reboot, as I have a Windows update to install > anyway.. I think maybe

[13] RFR (S): 8213234: Move LambdaForm.Hidden to jdk.internal.vm.annotation

http://cr.openjdk.java.net/~vlivanov/8213234/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8213234 Move LambdaForm.Hidden to jdk.internal.vm.annotation, so it can be shared across JDK until a standard solution is provided [1]. Testing: tier1-2 Best regards, Vladimir Ivanov [1] https://

Re: [13] RFR (S): 8213234: Move LambdaForm.Hidden to jdk.internal.vm.annotation

On 1/18/19 3:05 PM, Vladimir Ivanov wrote: http://cr.openjdk.java.net/~vlivanov/8213234/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8213234 Move LambdaForm.Hidden to jdk.internal.vm.annotation, so it can be shared across JDK until a standard solution is provided [1]. Looks good. 

Review Request JDK-8213932: [TESTBUG] assertEquals is invoked with the arguments in the wrong order

Small test fix.   SpecialStatic.java is a junit test but passes the expected argument to the wrong argument in assertEquals method.  I took a pass on the java.lang.invoke tests and spotted a couple others. Webrev: http://cr.openjdk.java.net/~mchung/jdk13/webrevs/8213932/webrev.00/ Thanks Mandy

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

Looks good, Nishit. Naoto On 1/18/19 3:03 AM, Nishit Jain wrote: Hi Roger, Naoto, > The size of Integer.MAX_VALUE - 2 is implementation specific, I think more typically max -8 is used to get the biggest allocation. When Integer.MAX_VALUE - 8 is used, the decode methods do not throw the adde

Re: [13] RFR: 8216969: ParseException thrown for certain months with russian locale

Gentle reminder. Still waiting for reviews from OpenJDK Reviewers. Naoto On 1/18/19 1:57 AM, Nishit Jain wrote: Looks Good. Regards, Nishit Jain On 17-01-2019 22:07, Naoto Sato wrote: Hi Nishit, Thanks. Updated: http://cr.openjdk.java.net/~naoto/8216969/webrev.01/ Naoto On 1/17/19 2:57 AM

Re: RFR: JDK-8217269: jpackage Makefile improvments

Hi Andy, Looks good. Thanks, Alexander On 1/18/2019 6:18 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). The webrev includes all the jpackage Makefile Improvements listed i

Re: [13] RFR: 8210583: Base64.Encoder incorrectly throws NegativeArraySizeException

How long does the regression test take to run on machines that have enough memory? Thanks, -Joe On 1/18/2019 3:38 PM, naoto.s...@oracle.com wrote: Looks good, Nishit. Naoto On 1/18/19 3:03 AM, Nishit Jain wrote: Hi Roger, Naoto,  > The size of Integer.MAX_VALUE - 2 is implementation speci

jpackage java.library.path

How is java.library.path supposed to work? I’m not seeing anything on a quick browse of the —help. It used to be I would manually move jni libraries into the MacOS directory which was the default setting. Is there a better way for jpackage?

Re: Review Request JDK-8213932: [TESTBUG] assertEquals is invoked with the arguments in the wrong order

+1 > On Jan 18, 2019, at 6:30 PM, Mandy Chung wrote: > > Small test fix. SpecialStatic.java is a junit test but passes the expected > argument to the wrong argument in assertEquals method. I took a pass on the > java.lang.invoke tests and spotted a couple others. > > Webrev: > http://cr.ope

jpackage errors

Trying for an actual jpackage build of one my applications on OS X I got… java.lang.NoClassDefFoundError: javax/script/ScriptException Remembering that the JDK in use might be incomplete I tried to --runtime-image some older installed JRE’s for 8, 9, and 11. Like… --runtime-image /Library/Java

Re: [13] RFR (S): 8213234: Move LambdaForm.Hidden to jdk.internal.vm.annotation

Thanks, Mandy & Dean. Updated in-place: http://cr.openjdk.java.net/~vlivanov/8213234/webrev.00/ Javadoc for Hidden now says the following: 30 /** 31 * A method or constructor may be annotated as "hidden" to hint it is desirable 32 * to omit it from stack traces. 33 * 34 * @imp