Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

Naoto, > On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote: > > ... > > https://bugs.openjdk.java.net/browse/JDK-8217938 > http://cr.openjdk.java.net/~naoto/8216546/webrev.00/ This looks good. Just a few very minor comments. 1) To be consistent can you please include the addition of the

Re: [12] RFR: 8217892: Clarify the support for the new Japanese era in java.time.chrono.JapaneseEra

Naoto, > On 31 Jan 2019, at 00:51, naoto.s...@oracle.com wrote: > > .. > https://bugs.openjdk.java.net/browse/JDK-8217939 > http://cr.openjdk.java.net/~naoto/8217892/webrev.00/ The changes look good. Reviewed. -Chris.

Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields

Hi Mandy, I've made the changes to the webrev and uploaded the corrected version. I've also uploaded the zips in the csr and bug. As for the test, I have mentioned that the test is attached to the bug. I attached the same test to the CSR. Are you saying that the test supplied is not a suitabl

Re: [testbug] RFR: 8195716: BootstrapLoggerTest : Executor still alive

Hi Mandy, Thanks for the review. On 30/01/2019 22:24, Mandy Chung wrote: Looks okay.  This gets quite complicated to verify the executor gets GC'ed.  It may be helpful to add a comment to describe the situation when a new one may be created. I have added some comments: http://cr.openjdk.java.

Re: RFR: JDK-8216528: test/jdk/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java failing with Xcomp

Pushed On 01/30/2019 10:12 PM, Jie Fu wrote: Hi Roger, I really hope you can still sponsor this. Could you help me, please? Thanks again. Best regards, Jie On 2019/1/31 上午10:59, David Holmes wrote: On 31/01/2019 12:44 pm, Jie Fu wrote: Hi David, I prefer the original patch[1]. Could you

Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

Hi Chris, Thank you for the comments. I updated the CSR and the webrev: https://bugs.openjdk.java.net/browse/JDK-8217938 https://cr.openjdk.java.net/~naoto/8216546/webrev.01/ Naoto On 1/31/19 1:15 AM, Chris Hegarty wrote: Naoto, On 31 Jan 2019, at 00:35, naoto.s...@oracle.com wrote: ... h

Re: [12] RFR: 8216546: Support new Japanese era in java.lang.Character for Java SE 11

> On 31 Jan 2019, at 17:07, Naoto Sato wrote: > > Hi Chris, > > Thank you for the comments. I updated the CSR and the webrev: > > https://bugs.openjdk.java.net/browse/JDK-8217938 > https://cr.openjdk.java.net/~naoto/8216546/webrev.01/ Thanks Naoto. Reviewed. -Chris

Re: [testbug] RFR: 8195716: BootstrapLoggerTest : Executor still alive

On 1/31/19 6:56 AM, Daniel Fuchs wrote: I have added some comments: http://cr.openjdk.java.net/~dfuchs/webrev_8195716/webrev.01 +1 Mandy

Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails to throw IllegalAccessException for final fields

On 1/31/19 4:18 AM, Adam Farley8 wrote: Hi Mandy, I've made the changes to the webrev and uploaded the corrected version. I've also uploaded the zips in the csr and bug. As for the test, I have mentioned that the test is attached to the bug. I attached the same test to the CSR. I did loo

RFR (JDK 13/java.xml) 8186321: Cleanup: SourceTreeManager not used

Please review a cleanup of an unused class. All core and xml tests passed. JBS: https://bugs.openjdk.java.net/browse/JDK-8186321 webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8186321/webrev/ Thanks, Joe

Re: RFR (JDK 13/java.xml) 8186321: Cleanup: SourceTreeManager not used

+1 > On Jan 31, 2019, at 2:18 PM, Joe Wang wrote: > > Please review a cleanup of an unused class. All core and xml tests passed. > > JBS: https://bugs.openjdk.java.net/browse/JDK-8186321 > webrevs: http://cr.openjdk.java.net/~joehw/jdk13/8186321/webrev/ > > Thanks, > Joe >

Re: RFR (JDK 13/java.xml) 8186321: Cleanup: SourceTreeManager not used

Hi Joe, It looks like lines 65-66 of src/java.xml/share/classes/com/sun/org/apache/xpath/internal/functions/FuncDoclocation.java can go away as well: //int owner = dtm.getDocument(); //fileLocation = xctxt.getSourceTreeManager().findURIFromDoc(owner); Thanks, Brian > On Jan 3

Re: RFR (JDK 13/java.xml) 8186321: Cleanup: SourceTreeManager not used

On 1/31/19, 11:30 AM, Brian Burkhalter wrote: Hi Joe, It looks like lines 65-66 of src/java.xml/share/classes/com/sun/org/apache/xpath/internal/functions/FuncDoclocation.java can go away as well: //int owner = dtm.getDocument(); //fileLocation = xctxt.getSourceTreeManager(

Re: RFR (JDK 13/java.xml) 8186321: Cleanup: SourceTreeManager not used

+1 Thanks, Brian > On Jan 31, 2019, at 12:01 PM, Joe Wang wrote: > > Done. > > Updated the webrev with the addition of FuncDoclocation: > http://cr.openjdk.java.net/~joehw/jdk13/8186321/webrev/ >

Re: RFR (JDK 13/java.xml) 8186321: Cleanup: SourceTreeManager not used

Thanks Brian, Lance! Changeset was pushed. -Joe On 1/31/19, 12:02 PM, Brian Burkhalter wrote: +1 Thanks, Brian On Jan 31, 2019, at 12:01 PM, Joe Wang > wrote: Done. Updated the webrev with the addition of FuncDoclocation: http://cr.openjdk.java.net/~joehw/j

Re: RFR: JDK-8216528: test/jdk/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java failing with Xcomp

Thanks Roger. On 2019/1/31 下午11:16, Roger Riggs wrote: Pushed On 01/30/2019 10:12 PM, Jie Fu wrote: Hi Roger, I really hope you can still sponsor this. Could you help me, please? Thanks again. Best regards, Jie On 2019/1/31 上午10:59, David Holmes wrote: On 31/01/2019 12:44 pm, Jie Fu wrote

RFR: JDK-8217317 : Create jpackage native library for windows

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - jpackage launcher will now build same as Linux and OS X using SetupBuildLauncher. - jpackage.dll was added based on Windows jpackage.exe launcher whi